| Message ID | 20201222151347.7886-3-martin.kepplinger@puri.sm (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | small Librem 5 phone dts updates | expand |
On Tue, Dec 22, 2020 at 04:13:45PM +0100, Martin Kepplinger wrote: > In order for the touchscreen interrupt line to work, describe it properly. > Otherwise it can work if defaults are ok, but we cannot be sure. > > Fixes: 8f0216b006e5 ("arm64: dts: Add a device tree for the Librem 5 phone") > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Tue, Dec 22, 2020 at 04:13:45PM +0100, Martin Kepplinger wrote: > In order for the touchscreen interrupt line to work, describe it properly. > Otherwise it can work if defaults are ok, but we cannot be sure. > > Fixes: 8f0216b006e5 ("arm64: dts: Add a device tree for the Librem 5 phone") > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > index 55268fc0622e..a60df09d90f7 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > @@ -459,6 +459,13 @@ > >; > }; > > + pinctrl_touch: touchgrp { > + fsl,pins = < > + /* TP_INT */ > + MX8MQ_IOMUXC_ENET_RD1_GPIO1_IO27 0x80 Miss indentation for these two lines. I fixed it up and applied the series. Shawn > + >; > + }; > + > pinctrl_typec: typecgrp { > fsl,pins = < > /* TYPEC_MUX_EN */ > @@ -880,6 +887,8 @@ > touchscreen@38 { > compatible = "edt,edt-ft5506"; > reg = <0x38>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_touch>; > interrupt-parent = <&gpio1>; > interrupts = <27 IRQ_TYPE_EDGE_FALLING>; > touchscreen-size-x = <720>; > -- > 2.20.1 >
On 11.01.21 01:29, Shawn Guo wrote: > On Tue, Dec 22, 2020 at 04:13:45PM +0100, Martin Kepplinger wrote: >> In order for the touchscreen interrupt line to work, describe it properly. >> Otherwise it can work if defaults are ok, but we cannot be sure. >> >> Fixes: 8f0216b006e5 ("arm64: dts: Add a device tree for the Librem 5 phone") >> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> >> --- >> arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi >> index 55268fc0622e..a60df09d90f7 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi >> @@ -459,6 +459,13 @@ >> >; >> }; >> >> + pinctrl_touch: touchgrp { >> + fsl,pins = < >> + /* TP_INT */ >> + MX8MQ_IOMUXC_ENET_RD1_GPIO1_IO27 0x80 > > Miss indentation for these two lines. > > I fixed it up and applied the series. > > Shawn > thanks for this! martin
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi index 55268fc0622e..a60df09d90f7 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi @@ -459,6 +459,13 @@ >; }; + pinctrl_touch: touchgrp { + fsl,pins = < + /* TP_INT */ + MX8MQ_IOMUXC_ENET_RD1_GPIO1_IO27 0x80 + >; + }; + pinctrl_typec: typecgrp { fsl,pins = < /* TYPEC_MUX_EN */ @@ -880,6 +887,8 @@ touchscreen@38 { compatible = "edt,edt-ft5506"; reg = <0x38>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_touch>; interrupt-parent = <&gpio1>; interrupts = <27 IRQ_TYPE_EDGE_FALLING>; touchscreen-size-x = <720>;
In order for the touchscreen interrupt line to work, describe it properly. Otherwise it can work if defaults are ok, but we cannot be sure. Fixes: 8f0216b006e5 ("arm64: dts: Add a device tree for the Librem 5 phone") Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> --- arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)