| Message ID | 1608770889-9403-4-git-send-email-yongqiang.niu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | support gce on mt8192 platform | expand |
Hi, Yongqiang: Yongqiang Niu <yongqiang.niu@mediatek.com> 於 2020年12月24日 週四 上午8:55寫道： > > add mt8192 support > > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index 75378e3..7f243e1 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -607,6 +607,7 @@ static int cmdq_probe(struct platform_device *pdev) > {.compatible = "mediatek,mt8173-gce", .data = (void *)&gce_plat_v2}, > {.compatible = "mediatek,mt8183-gce", .data = (void *)&gce_plat_v3}, > {.compatible = "mediatek,mt6779-gce", .data = (void *)&gce_plat_v4}, > + {.compatible = "mediatek,mt8192-gce", .data = (void *)&gce_plat_v4}, In the view of hardware function, is mt8192-gce identical to mt6779-gce? If these two are identical, you need not to modify driver, and the compatible should be compatible = "mediatek,mt8192-gce", "mediatek,mt6779-gce"; If they are not identical, what's the different? Regards, Chun-Kuang. > {} > }; > > -- > 1.8.1.1.dirty > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
On Thu, 2020-12-24 at 22:28 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu <yongqiang.niu@mediatek.com> 於 2020年12月24日 週四 上午8:55寫道： > > > > add mt8192 support > > > > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com> > > --- > > drivers/mailbox/mtk-cmdq-mailbox.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > > index 75378e3..7f243e1 100644 > > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > > @@ -607,6 +607,7 @@ static int cmdq_probe(struct platform_device *pdev) > > {.compatible = "mediatek,mt8173-gce", .data = (void *)&gce_plat_v2}, > > {.compatible = "mediatek,mt8183-gce", .data = (void *)&gce_plat_v3}, > > {.compatible = "mediatek,mt6779-gce", .data = (void *)&gce_plat_v4}, > > + {.compatible = "mediatek,mt8192-gce", .data = (void *)&gce_plat_v4}, > > In the view of hardware function, is mt8192-gce identical to > mt6779-gce? If these two are identical, you need not to modify driver, > and the compatible should be > > compatible = "mediatek,mt8192-gce", "mediatek,mt6779-gce"; > > If they are not identical, what's the different? > > Regards, > Chun-Kuang. irq id is different mt8192 dts https://patchwork.kernel.org/project/linux-mediatek/patch/1608770889-9403-3-git-send-email-yongqiang.niu@mediatek.com/ mt6779 dts https://patchwork.kernel.org/project/linux-mediatek/patch/1574327552-11806-6-git-send-email-dennis-yc.hsieh@mediatek.com/ and gce event id also different https://patchwork.kernel.org/project/linux-mediatek/patch/1608770889-9403-2-git-send-email-yongqiang.niu@mediatek.com/ https://patchwork.kernel.org/project/linux-mediatek/patch/1574327552-11806-2-git-send-email-dennis-yc.hsieh@mediatek.com/ > > > {} > > }; > > > > -- > > 1.8.1.1.dirty > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-mediatek
diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index 75378e3..7f243e1 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -607,6 +607,7 @@ static int cmdq_probe(struct platform_device *pdev) {.compatible = "mediatek,mt8173-gce", .data = (void *)&gce_plat_v2}, {.compatible = "mediatek,mt8183-gce", .data = (void *)&gce_plat_v3}, {.compatible = "mediatek,mt6779-gce", .data = (void *)&gce_plat_v4}, + {.compatible = "mediatek,mt8192-gce", .data = (void *)&gce_plat_v4}, {} };
add mt8192 support Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com> --- drivers/mailbox/mtk-cmdq-mailbox.c | 1 + 1 file changed, 1 insertion(+)