| Message ID | 20201227125638.260195-1-perex@perex.cz (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: AMD Renoir - add DMI entry for Lenovo ThinkPad E14 Gen 2 | expand |
Hi Jaroslav,
I love your patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on next-20201223]
[cannot apply to v5.10]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jaroslav-Kysela/ASoC-AMD-Renoir-add-DMI-entry-for-Lenovo-ThinkPad-E14-Gen-2/20201227-205839
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/4c2b19465ca61045cefe0b024981c0ab6fe4f85b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jaroslav-Kysela/ASoC-AMD-Renoir-add-DMI-entry-for-Lenovo-ThinkPad-E14-Gen-2/20201227-205839
git checkout 4c2b19465ca61045cefe0b024981c0ab6fe4f85b
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> sound/soc/amd/renoir/rn-pci-acp3x.c:174:14: warning: initialized field overwritten [-Woverride-init]
174 | .matches = {
| ^
sound/soc/amd/renoir/rn-pci-acp3x.c:174:14: note: (near initialization for 'rn_acp_quirk_table[0].matches')
vim +174 sound/soc/amd/renoir/rn-pci-acp3x.c
165
166 static const struct dmi_system_id rn_acp_quirk_table[] = {
167 {
168 /* Lenovo IdeaPad Flex 5 14ARE05, IdeaPad 5 15ARE05 */
169 .matches = {
170 DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
171 DMI_EXACT_MATCH(DMI_BOARD_NAME, "LNVNB161216"),
172 },
173 /* Lenovo ThinkPad E14 Gen 2 */
> 174 .matches = {
175 DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
176 DMI_EXACT_MATCH(DMI_BOARD_NAME, "20T6CTO1WW"),
177 }
178 },
179 {}
180 };
181
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c b/sound/soc/amd/renoir/rn-pci-acp3x.c index fa169bf09886..749e520eaca9 100644 --- a/sound/soc/amd/renoir/rn-pci-acp3x.c +++ b/sound/soc/amd/renoir/rn-pci-acp3x.c @@ -169,6 +169,11 @@ static const struct dmi_system_id rn_acp_quirk_table[] = { .matches = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_BOARD_NAME, "LNVNB161216"), + }, + /* Lenovo ThinkPad E14 Gen 2 */ + .matches = { + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_BOARD_NAME, "20T6CTO1WW"), } }, {}
The ThinkPad E14 Gen 2 latop does not have the internal digital microphone connected to the AMD's ACP bridge, but it's advertised via BIOS. The internal microphone is connected to the HDA codec. Use DMI to block the microphone PCM device for this platform. Reported-by: Eliot Blennerhassett <eliot@blennerhassett.gen.nz> Cc: <stable@kernel.org> Cc: Mark Brown <broonie@kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz> --- sound/soc/amd/renoir/rn-pci-acp3x.c | 5 +++++ 1 file changed, 5 insertions(+)