[00/24] NetBSD fixes

Message

Manuel Bouyer Dec. 14, 2020, 4:35 p.m. UTC

Hello,
here is a set of 24 patches, which are needed to build and run the
tools on NetBSD. They are extracted from NetBSD's pkgsrc repository for
Xen 4.13, and ported to 4.15. 

Manuel Bouyer (24):
  Fix lock directory path for NetBSD
  NetBSD doens't need xenbackendd with xl toolstack
  Fix lock directory path for NetBSD
  Make it build on NetBSD
  Introduce locking functions for block device setup on NetBSD
  Handle the case where vifname is not present in xenstore.
  Remove NetBSD's system headers. We'll use the system-provided ones,
    which are up to date.
  Make it build on NetBSD
  Use xen/xenio.h on NetBSD
  Make it build on NetBSD
  Implement foreignmemory on NetBSD
  Implement gnttab on NetBSD
  Don't assume tv_sec is a unsigned long (for NetBSD)
  Pass bridge name to qemu When starting qemu, set an environnement
    variable XEN_DOMAIN_ID, to be used by qemu helper scripts
  Make it build on NetBSD
  Switch NetBSD to QEMU_XEN (!traditional)
  Make it build on NetBSD
  This doens't need xen/sys/evtchn.h (NetBSD fix)
  errno may not be a gobal R/W variable, use a local variable instead
    (fix build on NetBSD)
  If FILENAME_MAX is defined, use it instead of arbitrary value (fix
    format-truncation errors with GCC >= 7)
  Fix unused functions/variables error
  If PTHREAD_STACK_MIN is not defined, use DEFAULT_THREAD_STACKSIZE
  Use xen/xenio.h on NetBSD
  Fix error: array subscript has type 'char' [-Werror=char-subscripts]

 m4/paths.m4                                   |   2 +-
 tools/Makefile                                |   1 -
 tools/configure                               |   2 +-
 tools/debugger/gdbsx/xg/xg_main.c             |  11 +
 tools/hotplug/NetBSD/Makefile                 |   1 +
 tools/hotplug/NetBSD/block                    |   5 +-
 tools/hotplug/NetBSD/locking.sh               |  72 +++++
 tools/hotplug/NetBSD/vif-bridge               |   5 +-
 tools/hotplug/NetBSD/vif-ip                   |   4 +
 tools/include/Makefile                        |   2 +-
 tools/include/xen-sys/NetBSD/evtchn.h         |  86 ------
 tools/include/xen-sys/NetBSD/privcmd.h        | 106 -------
 tools/libs/call/netbsd.c                      |  18 +-
 tools/libs/call/private.h                     |   8 +-
 tools/libs/ctrl/xc_private.h                  |   4 +
 tools/libs/evtchn/netbsd.c                    |   8 +-
 tools/libs/foreignmemory/Makefile             |   2 +-
 tools/libs/foreignmemory/netbsd.c             |  76 ++++-
 tools/libs/foreignmemory/private.h            |  10 +-
 tools/libs/gnttab/Makefile                    |   2 +-
 tools/libs/gnttab/netbsd.c                    | 267 ++++++++++++++++++
 tools/libs/light/libxl_create.c               |   8 +-
 tools/libs/light/libxl_dm.c                   |  19 ++
 tools/libs/light/libxl_netbsd.c               |   2 +-
 tools/libs/light/libxl_qmp.c                  |   2 +-
 tools/libs/light/libxl_uuid.c                 |   4 +-
 tools/libs/stat/xenstat_netbsd.c              |  11 -
 tools/libs/store/xs.c                         |   4 +
 tools/ocaml/libs/eventchn/xeneventchn_stubs.c |   1 -
 tools/xenpaging/xenpaging.c                   |   5 +-
 tools/xenpmd/xenpmd.c                         |   4 +
 tools/xentrace/xentrace.c                     |   2 +-
 xen/tools/symbols.c                           |   4 +-
 33 files changed, 508 insertions(+), 250 deletions(-)
 create mode 100644 tools/hotplug/NetBSD/locking.sh
 delete mode 100644 tools/include/xen-sys/NetBSD/evtchn.h
 delete mode 100644 tools/include/xen-sys/NetBSD/privcmd.h
 create mode 100644 tools/libs/gnttab/netbsd.c

Comments

Roger Pau Monne Dec. 29, 2020, 3:23 p.m. UTC | #1

On Mon, Dec 14, 2020 at 05:35:59PM +0100, Manuel Bouyer wrote:
> Hello,
> here is a set of 24 patches, which are needed to build and run the
> tools on NetBSD. They are extracted from NetBSD's pkgsrc repository for
> Xen 4.13, and ported to 4.15. 

Thanks! I think they are mostly fine. All of them are however missing
a Signed-off-by tag, which is mandatory for getting them accepted.
Also you should Cc the maintainers on patches, so they can review
them. There's a script in tree to do that, you can use it against the
patch files and it will append the appropriate Cc's:

% ./scripts/add_maintainers.pl -d patch/directory

Optionally use the --reroll-count when sending new versions of the
series (2,3...)

Thanks, Roger.