| Message ID | 20210104143103.56510-1-alexandru.ardelean@analog.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8b835da61774d4482864bc081dfb428104842ad3 |
| Headers | show |
| Series | [v2] spi: stm32: update dev_dbg() print format for SPI params | expand |
On Mon, Jan 4, 2021 at 4:27 PM Alexandru Ardelean <alexandru.ardelean@analog.com> wrote: > > With the introduction of the 'include/uapi/linux/spi/spi.h' header, the > type of the macros are enforced to 'unsigned long int' via the _BITUL() > macro. > > This causes some -Wformat warnings in the spi-stm32 driver. > This patch adds a double-negation operator to the bit-masks. Essentially, > the important values for debugging are 0 or 1, while masking them directly > would show 0 or BIT(x) values. > This way, the type of the arguments are automatically re-cast. Thanks! Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Fixes: f7005142dace ("spi: uapi: unify SPI modes into a single spi.h header") > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > --- > > Changelog v1 -> v2: > * revert to using '%d' specifiers > * add !! operatior to bit-masking; this way the types are automatically > re-cast > * add 'Reported-by: kernel test robot <lkp@intel.com>' > > drivers/spi/spi-stm32.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c > index 6017209c6d2f..be0fb169d7a7 100644 > --- a/drivers/spi/spi-stm32.c > +++ b/drivers/spi/spi-stm32.c > @@ -1028,10 +1028,10 @@ static int stm32_spi_prepare_msg(struct spi_master *master, > clrb |= spi->cfg->regs->lsb_first.mask; > > dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > - spi_dev->mode & SPI_CPOL, > - spi_dev->mode & SPI_CPHA, > - spi_dev->mode & SPI_LSB_FIRST, > - spi_dev->mode & SPI_CS_HIGH); > + !!(spi_dev->mode & SPI_CPOL), > + !!(spi_dev->mode & SPI_CPHA), > + !!(spi_dev->mode & SPI_LSB_FIRST), > + !!(spi_dev->mode & SPI_CS_HIGH)); > > spin_lock_irqsave(&spi->lock, flags); > > -- > 2.17.1 >
On Mon, 4 Jan 2021 16:31:03 +0200, Alexandru Ardelean wrote: > With the introduction of the 'include/uapi/linux/spi/spi.h' header, the > type of the macros are enforced to 'unsigned long int' via the _BITUL() > macro. > > This causes some -Wformat warnings in the spi-stm32 driver. > This patch adds a double-negation operator to the bit-masks. Essentially, > the important values for debugging are 0 or 1, while masking them directly > would show 0 or BIT(x) values. > This way, the type of the arguments are automatically re-cast. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: stm32: update dev_dbg() print format for SPI params commit: 8b835da61774d4482864bc081dfb428104842ad3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index 6017209c6d2f..be0fb169d7a7 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -1028,10 +1028,10 @@ static int stm32_spi_prepare_msg(struct spi_master *master, clrb |= spi->cfg->regs->lsb_first.mask; dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", - spi_dev->mode & SPI_CPOL, - spi_dev->mode & SPI_CPHA, - spi_dev->mode & SPI_LSB_FIRST, - spi_dev->mode & SPI_CS_HIGH); + !!(spi_dev->mode & SPI_CPOL), + !!(spi_dev->mode & SPI_CPHA), + !!(spi_dev->mode & SPI_LSB_FIRST), + !!(spi_dev->mode & SPI_CS_HIGH)); spin_lock_irqsave(&spi->lock, flags);
With the introduction of the 'include/uapi/linux/spi/spi.h' header, the type of the macros are enforced to 'unsigned long int' via the _BITUL() macro. This causes some -Wformat warnings in the spi-stm32 driver. This patch adds a double-negation operator to the bit-masks. Essentially, the important values for debugging are 0 or 1, while masking them directly would show 0 or BIT(x) values. This way, the type of the arguments are automatically re-cast. Fixes: f7005142dace ("spi: uapi: unify SPI modes into a single spi.h header") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> --- Changelog v1 -> v2: * revert to using '%d' specifiers * add !! operatior to bit-masking; this way the types are automatically re-cast * add 'Reported-by: kernel test robot <lkp@intel.com>' drivers/spi/spi-stm32.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)