| Message ID | 20201222105726.16906-6-arnaud.pouliquen@foss.st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | introduce generic IOCTL interface for RPMsg channels management | expand |
On Tue 22 Dec 04:57 CST 2020, Arnaud Pouliquen wrote: > By default driver_override should be 0 to avoid to force > the channel creation with a specified name.The local variable > is not initialized. > The same problem exists in qcom_glink_native, qcom_smd and rpmsg_char. Regards, Bjorn > Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com> > --- > drivers/rpmsg/rpmsg_ns.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/rpmsg/rpmsg_ns.c b/drivers/rpmsg/rpmsg_ns.c > index 762ff1ae279f..a526bff62947 100644 > --- a/drivers/rpmsg/rpmsg_ns.c > +++ b/drivers/rpmsg/rpmsg_ns.c > @@ -55,6 +55,7 @@ static int rpmsg_ns_cb(struct rpmsg_device *rpdev, void *data, int len, > strncpy(chinfo.name, msg->name, sizeof(chinfo.name)); > chinfo.src = RPMSG_ADDR_ANY; > chinfo.dst = rpmsg32_to_cpu(rpdev, msg->addr); > + chinfo.driver_override = NULL; > > dev_info(dev, "%sing channel %s addr 0x%x\n", > rpmsg32_to_cpu(rpdev, msg->flags) & RPMSG_NS_DESTROY ? > -- > 2.17.1 >
On 1/5/21 1:38 AM, Bjorn Andersson wrote: > On Tue 22 Dec 04:57 CST 2020, Arnaud Pouliquen wrote: > >> By default driver_override should be 0 to avoid to force >> the channel creation with a specified name.The local variable >> is not initialized. >> > > The same problem exists in qcom_glink_native, qcom_smd and rpmsg_char. Right! And perhaps initializing the structure on declaration would be a better method. Thanks, Arnaud > > Regards, > Bjorn > >> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com> >> --- >> drivers/rpmsg/rpmsg_ns.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/rpmsg/rpmsg_ns.c b/drivers/rpmsg/rpmsg_ns.c >> index 762ff1ae279f..a526bff62947 100644 >> --- a/drivers/rpmsg/rpmsg_ns.c >> +++ b/drivers/rpmsg/rpmsg_ns.c >> @@ -55,6 +55,7 @@ static int rpmsg_ns_cb(struct rpmsg_device *rpdev, void *data, int len, >> strncpy(chinfo.name, msg->name, sizeof(chinfo.name)); >> chinfo.src = RPMSG_ADDR_ANY; >> chinfo.dst = rpmsg32_to_cpu(rpdev, msg->addr); >> + chinfo.driver_override = NULL; >> >> dev_info(dev, "%sing channel %s addr 0x%x\n", >> rpmsg32_to_cpu(rpdev, msg->flags) & RPMSG_NS_DESTROY ? >> -- >> 2.17.1 >>
diff --git a/drivers/rpmsg/rpmsg_ns.c b/drivers/rpmsg/rpmsg_ns.c index 762ff1ae279f..a526bff62947 100644 --- a/drivers/rpmsg/rpmsg_ns.c +++ b/drivers/rpmsg/rpmsg_ns.c @@ -55,6 +55,7 @@ static int rpmsg_ns_cb(struct rpmsg_device *rpdev, void *data, int len, strncpy(chinfo.name, msg->name, sizeof(chinfo.name)); chinfo.src = RPMSG_ADDR_ANY; chinfo.dst = rpmsg32_to_cpu(rpdev, msg->addr); + chinfo.driver_override = NULL; dev_info(dev, "%sing channel %s addr 0x%x\n", rpmsg32_to_cpu(rpdev, msg->flags) & RPMSG_NS_DESTROY ?
By default driver_override should be 0 to avoid to force the channel creation with a specified name.The local variable is not initialized. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com> --- drivers/rpmsg/rpmsg_ns.c | 1 + 1 file changed, 1 insertion(+)