| Message ID | 20210105091908.15290-1-mika.westerberg@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c14556fc0c7c115ffb4a287560e1ec9f7869aac3 |
| Headers | show |
| Series | thunderbolt: Drop duplicated 0x prefix from format string | expand |
On Tue, Jan 5, 2021 at 11:19 AM Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > > The tb_dbg() call is using %#x that already adds the 0x prefix so don't > duplicate it. > > Fixes: 9039387e166e ("thunderbolt: Add USB4 router operation proxy for firmware connection manager") > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- > drivers/thunderbolt/icm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c > index 8b7f941a9bb7..b8c4159bc32d 100644 > --- a/drivers/thunderbolt/icm.c > +++ b/drivers/thunderbolt/icm.c > @@ -2316,7 +2316,7 @@ static int icm_usb4_switch_nvm_authenticate_status(struct tb_switch *sw, > > if (auth && auth->reply.route_hi == sw->config.route_hi && > auth->reply.route_lo == sw->config.route_lo) { > - tb_dbg(tb, "NVM_AUTH found for %llx flags 0x%#x status %#x\n", > + tb_dbg(tb, "NVM_AUTH found for %llx flags %#x status %#x\n", > tb_route(sw), auth->reply.hdr.flags, auth->reply.status); > if (auth->reply.hdr.flags & ICM_FLAGS_ERROR) > ret = -EIO; > -- > 2.29.2 > Reviewed-by: Yehezkel Bernat <YehezkelShB@gmail.com>
On Tue, Jan 05, 2021 at 12:08:32PM +0200, Yehezkel Bernat wrote: > On Tue, Jan 5, 2021 at 11:19 AM Mika Westerberg > <mika.westerberg@linux.intel.com> wrote: > > > > The tb_dbg() call is using %#x that already adds the 0x prefix so don't > > duplicate it. > > > > Fixes: 9039387e166e ("thunderbolt: Add USB4 router operation proxy for firmware connection manager") > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > --- > > drivers/thunderbolt/icm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c > > index 8b7f941a9bb7..b8c4159bc32d 100644 > > --- a/drivers/thunderbolt/icm.c > > +++ b/drivers/thunderbolt/icm.c > > @@ -2316,7 +2316,7 @@ static int icm_usb4_switch_nvm_authenticate_status(struct tb_switch *sw, > > > > if (auth && auth->reply.route_hi == sw->config.route_hi && > > auth->reply.route_lo == sw->config.route_lo) { > > - tb_dbg(tb, "NVM_AUTH found for %llx flags 0x%#x status %#x\n", > > + tb_dbg(tb, "NVM_AUTH found for %llx flags %#x status %#x\n", > > tb_route(sw), auth->reply.hdr.flags, auth->reply.status); > > if (auth->reply.hdr.flags & ICM_FLAGS_ERROR) > > ret = -EIO; > > -- > > 2.29.2 > > > > Reviewed-by: Yehezkel Bernat <YehezkelShB@gmail.com> Thanks! Applied now.
diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c index 8b7f941a9bb7..b8c4159bc32d 100644 --- a/drivers/thunderbolt/icm.c +++ b/drivers/thunderbolt/icm.c @@ -2316,7 +2316,7 @@ static int icm_usb4_switch_nvm_authenticate_status(struct tb_switch *sw, if (auth && auth->reply.route_hi == sw->config.route_hi && auth->reply.route_lo == sw->config.route_lo) { - tb_dbg(tb, "NVM_AUTH found for %llx flags 0x%#x status %#x\n", + tb_dbg(tb, "NVM_AUTH found for %llx flags %#x status %#x\n", tb_route(sw), auth->reply.hdr.flags, auth->reply.status); if (auth->reply.hdr.flags & ICM_FLAGS_ERROR) ret = -EIO;
The tb_dbg() call is using %#x that already adds the 0x prefix so don't duplicate it. Fixes: 9039387e166e ("thunderbolt: Add USB4 router operation proxy for firmware connection manager") Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- drivers/thunderbolt/icm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)