| Message ID | 20210102223109.996781-9-roderick@gaikai.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: new driver for PS5 'DualSense' controller | expand |
Hi 2021. január 2., szombat 23:31 keltezéssel, Roderick Colenbrander írta: > From: Roderick Colenbrander <roderick.colenbrander@sony.com> > > The DualSense features a haptics system based on voicecoil motors, > which requires PCM data (or special HID packets using Bluetooth). There > is no appropriate API yet in the Linux kernel to expose these. The > controller also provides a classic rumble feature for backwards > compatibility. Expose this classic rumble feature using the FF framework. > > Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com> > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index ef175c1cb15c..e6c67aaa1a1a 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -863,6 +863,14 @@ config HID_PLAYSTATION > its special functionalities e.g. touchpad, lights and motion > sensors. > > +config PLAYSTATION_FF I'm wondering if HID_PLAYSTATION_FF would be a better name? > + bool "PlayStation force feedback support" > + depends on HID_PLAYSTATION > + select INPUT_FF_MEMLESS > + help > + Say Y here if you would like to enable force feedback support for > + PlayStation game controllers. > + > config HID_PRIMAX > tristate "Primax non-fully HID-compliant devices" > depends on HID > diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c > index 552a52a50b78..36a904b2f93f 100644 > --- a/drivers/hid/hid-playstation.c > +++ b/drivers/hid/hid-playstation.c > [...] > @@ -136,6 +151,63 @@ struct dualsense_input_report { > uint8_t reserved4[11]; > } __packed; > > +/* Common data between DualSense BT/USB main output report. */ > +struct dualsense_output_report_common { > + uint8_t valid_flag0; > + uint8_t valid_flag1; > + > + /* For DualShock 4 compatibility mode. */ > + uint8_t motor_right; > + uint8_t motor_left; > + > + /* Audio controls */ > + uint8_t reserved[4]; > + uint8_t mute_button_led; > + > + uint8_t power_save_control; > + uint8_t reserved2[28]; > + > + /* LEDs and lightbar */ > + uint8_t valid_flag2; > + uint8_t reserved3[2]; > + uint8_t lightbar_setup; > + uint8_t led_brightness; > + uint8_t player_leds; > + uint8_t lightbar_red; > + uint8_t lightbar_green; > + uint8_t lightbar_blue; > +} __packed; > + > +struct dualsense_output_report_bt { > + uint8_t report_id; /* 0x31 */ > + uint8_t seq_tag; > + uint8_t tag; > + struct dualsense_output_report_common common; > + uint8_t reserved[24]; > + __le32 crc32; > +} __packed; > + > +struct dualsense_output_report_usb { > + uint8_t report_id; /* 0x02 */ > + struct dualsense_output_report_common common; > +} __packed; > + I think it'd be good if you could add static_asserts to check the sizes of the __packed structs at compile time. > +/* The DualSense has a main output report used to control most features. It is > + * largely the same between Bluetooth and USB except for different headers and CRC. > + * This structure hide the differences between the two to simplify sending output reports. > + */ > +struct dualsense_output_report { > + uint8_t *data; /* Start of data */ > + uint8_t len; /* Size of output report */ > + > + /* Points to Bluetooth data payload in case for a Bluetooth report else NULL. */ > + struct dualsense_output_report_bt *bt; > + /* Points to USB data payload in case for a USB report else NULL. */ > + struct dualsense_output_report_usb *usb; > + /* Points to common section of report, so past any headers */ > + struct dualsense_output_report_common *common; > +}; > [...] > +static void dualsense_init_output_report(struct dualsense *ds, struct dualsense_output_report *rp, > + void *buf) If the dualsense struct is already passed in, couldn't this function use `ds->output_report_dmabuf` directly? > +{ > + struct hid_device *hdev = ds->base.hdev; > + > + if (hdev->bus == BUS_BLUETOOTH) { > + struct dualsense_output_report_bt *bt = buf; > + > + memset(bt, 0, sizeof(*bt)); > + bt->report_id = DS_OUTPUT_REPORT_BT; > + bt->tag = 0x10; /* Magic number must be set to 0x10 */ I think it would be preferable if that 0x10 were named. > + > + /* Highest 4-bit is a sequence number, which needs to be increased > + * every report. Lowest 4-bit is tag and can be zero for now. > + */ > + bt->seq_tag = (ds->output_seq << 4) | 0x0; > + if (++ds->output_seq == 15) > + ds->output_seq = 0; If I see it correctly, the maximum sequence number is 14; is that intentional? Or am I missing something? > + > + rp->data = buf; > + rp->len = sizeof(*bt); > + rp->bt = bt; > + rp->usb = NULL; > + rp->common = &bt->common; > + } else { /* USB */ > + struct dualsense_output_report_usb *usb = buf; > + > + memset(usb, 0, sizeof(*usb)); > + usb->report_id = DS_OUTPUT_REPORT_USB; > + > + rp->data = buf; > + rp->len = sizeof(*usb); > + rp->bt = NULL; > + rp->usb = usb; > + rp->common = &usb->common; > + } > +} > + > +/* Helper function to send DualSense output reports. Applies a CRC at the end of a report > + * for Bluetooth reports. > + */ > +static void dualsense_send_output_report(struct dualsense *ds, > + struct dualsense_output_report *report) > +{ > + struct hid_device *hdev = ds->base.hdev; > + > + /* Bluetooth packets need to be signed with a CRC in the last 4 bytes. */ > + if (report->bt) { > + uint32_t crc; > + uint8_t seed = 0xA2; Maybe this '0xA2' could be named as well? And I think it would be better if all hexadecimal constants would either be lowercase or uppercase. > + > + crc = crc32_le(0xFFFFFFFF, &seed, 1); > + crc = ~crc32_le(crc, report->data, report->len - 4); > + > + report->bt->crc32 = cpu_to_le32(crc); > + } > + > + hid_hw_output_report(hdev, report->data, report->len); > +} > [...] > static struct ps_device *dualsense_create(struct hid_device *hdev) > { > struct dualsense *ds; > struct ps_device *ps_dev; > + uint8_t max_output_report_size; > int ret; > > ds = devm_kzalloc(&hdev->dev, sizeof(*ds), GFP_KERNEL); > @@ -696,8 +882,14 @@ static struct ps_device *dualsense_create(struct hid_device *hdev) > ps_dev->battery_capacity = 100; /* initial value until parse_report. */ > ps_dev->battery_status = POWER_SUPPLY_STATUS_UNKNOWN; > ps_dev->parse_report = dualsense_parse_report; > + INIT_WORK(&ds->output_worker, dualsense_output_worker); > hid_set_drvdata(hdev, ds); > > + max_output_report_size = sizeof(struct dualsense_output_report_bt); I think `max(sizeof(..._bt), sizeof(..._usb))` (linux/minmax.h) would be more expressive? > + ds->output_report_dmabuf = devm_kzalloc(&hdev->dev, max_output_report_size, GFP_KERNEL); > + if (!ds->output_report_dmabuf) > + return ERR_PTR(-ENOMEM); > + > ret = dualsense_get_mac_address(ds); > if (ret < 0) { > hid_err(hdev, "Failed to get MAC address from DualSense\n"); > @@ -715,7 +907,7 @@ static struct ps_device *dualsense_create(struct hid_device *hdev) > goto err; > } > > - ds->gamepad = ps_gamepad_create(hdev); > + ds->gamepad = ps_gamepad_create(hdev, dualsense_play_effect); > if (IS_ERR(ds->gamepad)) { > ret = PTR_ERR(ds->gamepad); > goto err; > > Regards, Barnabás Pőcze
2021. január 7., csütörtök 21:41 keltezéssel, Barnabás Pőcze írta: > [...] > > +struct dualsense_output_report { > > + uint8_t *data; /* Start of data */ > > + uint8_t len; /* Size of output report */ > > + > > + /* Points to Bluetooth data payload in case for a Bluetooth report else NULL. */ > > + struct dualsense_output_report_bt *bt; > > + /* Points to USB data payload in case for a USB report else NULL. */ > > + struct dualsense_output_report_usb *usb; > > + /* Points to common section of report, so past any headers */ > > + struct dualsense_output_report_common *common; > > +}; > > [...] > > +static void dualsense_init_output_report(struct dualsense *ds, struct dualsense_output_report *rp, > > + void *buf) > > If the dualsense struct is already passed in, couldn't this function use > `ds->output_report_dmabuf` directly? > [...] Never mind, sorry, the next patch answered this question.
Hi Barnabás, Thanks for your comments. On Thu, Jan 7, 2021 at 12:41 PM Barnabás Pőcze <pobrn@protonmail.com> wrote: > > Hi > > > 2021. január 2., szombat 23:31 keltezéssel, Roderick Colenbrander írta: > > > From: Roderick Colenbrander <roderick.colenbrander@sony.com> > > > > The DualSense features a haptics system based on voicecoil motors, > > which requires PCM data (or special HID packets using Bluetooth). There > > is no appropriate API yet in the Linux kernel to expose these. The > > controller also provides a classic rumble feature for backwards > > compatibility. Expose this classic rumble feature using the FF framework. > > > > Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com> > > > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > > index ef175c1cb15c..e6c67aaa1a1a 100644 > > --- a/drivers/hid/Kconfig > > +++ b/drivers/hid/Kconfig > > @@ -863,6 +863,14 @@ config HID_PLAYSTATION > > its special functionalities e.g. touchpad, lights and motion > > sensors. > > > > +config PLAYSTATION_FF > > I'm wondering if HID_PLAYSTATION_FF would be a better name? I'm not sure. Other drivers use "NAME_FF". It seems that FF-only drivers use HID_NAME_FF. > > > + bool "PlayStation force feedback support" > > + depends on HID_PLAYSTATION > > + select INPUT_FF_MEMLESS > > + help > > + Say Y here if you would like to enable force feedback support for > > + PlayStation game controllers. > > + > > config HID_PRIMAX > > tristate "Primax non-fully HID-compliant devices" > > depends on HID > > diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c > > index 552a52a50b78..36a904b2f93f 100644 > > --- a/drivers/hid/hid-playstation.c > > +++ b/drivers/hid/hid-playstation.c > > [...] > > @@ -136,6 +151,63 @@ struct dualsense_input_report { > > uint8_t reserved4[11]; > > } __packed; > > > > +/* Common data between DualSense BT/USB main output report. */ > > +struct dualsense_output_report_common { > > + uint8_t valid_flag0; > > + uint8_t valid_flag1; > > + > > + /* For DualShock 4 compatibility mode. */ > > + uint8_t motor_right; > > + uint8_t motor_left; > > + > > + /* Audio controls */ > > + uint8_t reserved[4]; > > + uint8_t mute_button_led; > > + > > + uint8_t power_save_control; > > + uint8_t reserved2[28]; > > + > > + /* LEDs and lightbar */ > > + uint8_t valid_flag2; > > + uint8_t reserved3[2]; > > + uint8_t lightbar_setup; > > + uint8_t led_brightness; > > + uint8_t player_leds; > > + uint8_t lightbar_red; > > + uint8_t lightbar_green; > > + uint8_t lightbar_blue; > > +} __packed; > > + > > +struct dualsense_output_report_bt { > > + uint8_t report_id; /* 0x31 */ > > + uint8_t seq_tag; > > + uint8_t tag; > > + struct dualsense_output_report_common common; > > + uint8_t reserved[24]; > > + __le32 crc32; > > +} __packed; > > + > > +struct dualsense_output_report_usb { > > + uint8_t report_id; /* 0x02 */ > > + struct dualsense_output_report_common common; > > +} __packed; > > + > > I think it'd be good if you could add static_asserts to check the sizes of > the __packed structs at compile time. Good idea. Added some checks. > > > > +/* The DualSense has a main output report used to control most features. It is > > + * largely the same between Bluetooth and USB except for different headers and CRC. > > + * This structure hide the differences between the two to simplify sending output reports. > > + */ > > +struct dualsense_output_report { > > + uint8_t *data; /* Start of data */ > > + uint8_t len; /* Size of output report */ > > + > > + /* Points to Bluetooth data payload in case for a Bluetooth report else NULL. */ > > + struct dualsense_output_report_bt *bt; > > + /* Points to USB data payload in case for a USB report else NULL. */ > > + struct dualsense_output_report_usb *usb; > > + /* Points to common section of report, so past any headers */ > > + struct dualsense_output_report_common *common; > > +}; > > [...] > > +static void dualsense_init_output_report(struct dualsense *ds, struct dualsense_output_report *rp, > > + void *buf) > > If the dualsense struct is already passed in, couldn't this function use > `ds->output_report_dmabuf` directly? > > > > +{ > > + struct hid_device *hdev = ds->base.hdev; > > + > > + if (hdev->bus == BUS_BLUETOOTH) { > > + struct dualsense_output_report_bt *bt = buf; > > + > > + memset(bt, 0, sizeof(*bt)); > > + bt->report_id = DS_OUTPUT_REPORT_BT; > > + bt->tag = 0x10; /* Magic number must be set to 0x10 */ > > I think it would be preferable if that 0x10 were named. Not sure yet what I want to do. I was only given this magic number and I don't even know what it is, so even for me it is magic :) > > > + > > + /* Highest 4-bit is a sequence number, which needs to be increased > > + * every report. Lowest 4-bit is tag and can be zero for now. > > + */ > > + bt->seq_tag = (ds->output_seq << 4) | 0x0; > > + if (++ds->output_seq == 15) > > + ds->output_seq = 0; > > If I see it correctly, the maximum sequence number is 14; is that intentional? > Or am I missing something? > > > > + > > + rp->data = buf; > > + rp->len = sizeof(*bt); > > + rp->bt = bt; > > + rp->usb = NULL; > > + rp->common = &bt->common; > > + } else { /* USB */ > > + struct dualsense_output_report_usb *usb = buf; > > + > > + memset(usb, 0, sizeof(*usb)); > > + usb->report_id = DS_OUTPUT_REPORT_USB; > > + > > + rp->data = buf; > > + rp->len = sizeof(*usb); > > + rp->bt = NULL; > > + rp->usb = usb; > > + rp->common = &usb->common; > > + } > > +} > > + > > +/* Helper function to send DualSense output reports. Applies a CRC at the end of a report > > + * for Bluetooth reports. > > + */ > > +static void dualsense_send_output_report(struct dualsense *ds, > > + struct dualsense_output_report *report) > > +{ > > + struct hid_device *hdev = ds->base.hdev; > > + > > + /* Bluetooth packets need to be signed with a CRC in the last 4 bytes. */ > > + if (report->bt) { > > + uint32_t crc; > > + uint8_t seed = 0xA2; > > Maybe this '0xA2' could be named as well? And I think it would be better if > all hexadecimal constants would either be lowercase or uppercase. I will see if I can find an appropriate name.. > > > + > > + crc = crc32_le(0xFFFFFFFF, &seed, 1); > > + crc = ~crc32_le(crc, report->data, report->len - 4); > > + > > + report->bt->crc32 = cpu_to_le32(crc); > > + } > > + > > + hid_hw_output_report(hdev, report->data, report->len); > > +} > > [...] > > static struct ps_device *dualsense_create(struct hid_device *hdev) > > { > > struct dualsense *ds; > > struct ps_device *ps_dev; > > + uint8_t max_output_report_size; > > int ret; > > > > ds = devm_kzalloc(&hdev->dev, sizeof(*ds), GFP_KERNEL); > > @@ -696,8 +882,14 @@ static struct ps_device *dualsense_create(struct hid_device *hdev) > > ps_dev->battery_capacity = 100; /* initial value until parse_report. */ > > ps_dev->battery_status = POWER_SUPPLY_STATUS_UNKNOWN; > > ps_dev->parse_report = dualsense_parse_report; > > + INIT_WORK(&ds->output_worker, dualsense_output_worker); > > hid_set_drvdata(hdev, ds); > > > > + max_output_report_size = sizeof(struct dualsense_output_report_bt); > > I think `max(sizeof(..._bt), sizeof(..._usb))` (linux/minmax.h) would be > more expressive? > > > > + ds->output_report_dmabuf = devm_kzalloc(&hdev->dev, max_output_report_size, GFP_KERNEL); > > + if (!ds->output_report_dmabuf) > > + return ERR_PTR(-ENOMEM); > > + > > ret = dualsense_get_mac_address(ds); > > if (ret < 0) { > > hid_err(hdev, "Failed to get MAC address from DualSense\n"); > > @@ -715,7 +907,7 @@ static struct ps_device *dualsense_create(struct hid_device *hdev) > > goto err; > > } > > > > - ds->gamepad = ps_gamepad_create(hdev); > > + ds->gamepad = ps_gamepad_create(hdev, dualsense_play_effect); > > if (IS_ERR(ds->gamepad)) { > > ret = PTR_ERR(ds->gamepad); > > goto err; > > > > > > > Regards, > Barnabás Pőcze Regards, Roderick
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index ef175c1cb15c..e6c67aaa1a1a 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -863,6 +863,14 @@ config HID_PLAYSTATION its special functionalities e.g. touchpad, lights and motion sensors. +config PLAYSTATION_FF + bool "PlayStation force feedback support" + depends on HID_PLAYSTATION + select INPUT_FF_MEMLESS + help + Say Y here if you would like to enable force feedback support for + PlayStation game controllers. + config HID_PRIMAX tristate "Primax non-fully HID-compliant devices" depends on HID diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c index 552a52a50b78..36a904b2f93f 100644 --- a/drivers/hid/hid-playstation.c +++ b/drivers/hid/hid-playstation.c @@ -48,6 +48,8 @@ struct ps_calibration_data { #define DS_INPUT_REPORT_USB 0x01 #define DS_INPUT_REPORT_BT 0x31 +#define DS_OUTPUT_REPORT_USB 0x02 +#define DS_OUTPUT_REPORT_BT 0x31 #define DS_FEATURE_REPORT_CALIBRATION 5 #define DS_FEATURE_REPORT_CALIBRATION_SIZE 41 @@ -82,6 +84,10 @@ struct ps_calibration_data { */ #define DS_TOUCH_POINT_INACTIVE BIT(7) +/* Flags for DualSense output report. */ +#define DS_OUTPUT_VALID_FLAG0_COMPATIBLE_VIBRATION BIT(0) +#define DS_OUTPUT_VALID_FLAG0_HAPTICS_SELECT BIT(1) + /* DualSense hardware limits */ #define DS_ACC_RES_PER_G 8192 #define DS_ACC_RANGE (4*DS_ACC_RES_PER_G) @@ -104,6 +110,15 @@ struct dualsense { bool sensor_timestamp_initialized; uint32_t prev_sensor_timestamp; uint32_t sensor_timestamp_us; + + /* Compatible rumble state */ + bool update_rumble; + uint8_t motor_left; + uint8_t motor_right; + + struct work_struct output_worker; + void *output_report_dmabuf; + uint8_t output_seq; /* Sequence number for output report. */ }; struct dualsense_touch_point { @@ -136,6 +151,63 @@ struct dualsense_input_report { uint8_t reserved4[11]; } __packed; +/* Common data between DualSense BT/USB main output report. */ +struct dualsense_output_report_common { + uint8_t valid_flag0; + uint8_t valid_flag1; + + /* For DualShock 4 compatibility mode. */ + uint8_t motor_right; + uint8_t motor_left; + + /* Audio controls */ + uint8_t reserved[4]; + uint8_t mute_button_led; + + uint8_t power_save_control; + uint8_t reserved2[28]; + + /* LEDs and lightbar */ + uint8_t valid_flag2; + uint8_t reserved3[2]; + uint8_t lightbar_setup; + uint8_t led_brightness; + uint8_t player_leds; + uint8_t lightbar_red; + uint8_t lightbar_green; + uint8_t lightbar_blue; +} __packed; + +struct dualsense_output_report_bt { + uint8_t report_id; /* 0x31 */ + uint8_t seq_tag; + uint8_t tag; + struct dualsense_output_report_common common; + uint8_t reserved[24]; + __le32 crc32; +} __packed; + +struct dualsense_output_report_usb { + uint8_t report_id; /* 0x02 */ + struct dualsense_output_report_common common; +} __packed; + +/* The DualSense has a main output report used to control most features. It is + * largely the same between Bluetooth and USB except for different headers and CRC. + * This structure hide the differences between the two to simplify sending output reports. + */ +struct dualsense_output_report { + uint8_t *data; /* Start of data */ + uint8_t len; /* Size of output report */ + + /* Points to Bluetooth data payload in case for a Bluetooth report else NULL. */ + struct dualsense_output_report_bt *bt; + /* Points to USB data payload in case for a USB report else NULL. */ + struct dualsense_output_report_usb *usb; + /* Points to common section of report, so past any headers */ + struct dualsense_output_report_common *common; +}; + /* Common gamepad buttons across DualShock 3 / 4 and DualSense. * Note: for device with a touchpad, touchpad button is not included * as it will be part of the touchpad device. @@ -297,7 +369,8 @@ static bool ps_check_crc32(uint8_t seed, uint8_t *data, size_t len, uint32_t rep return crc == report_crc; } -static struct input_dev *ps_gamepad_create(struct hid_device *hdev) +static struct input_dev *ps_gamepad_create(struct hid_device *hdev, + int (*play_effect)(struct input_dev *, void *, struct ff_effect *)) { struct input_dev *gamepad; unsigned int i; @@ -320,6 +393,13 @@ static struct input_dev *ps_gamepad_create(struct hid_device *hdev) for (i = 0; i < ARRAY_SIZE(ps_gamepad_buttons); i++) input_set_capability(gamepad, EV_KEY, ps_gamepad_buttons[i]); +#if IS_ENABLED(CONFIG_PLAYSTATION_FF) + if (play_effect) { + input_set_capability(gamepad, EV_FF, FF_RUMBLE); + input_ff_create_memless(gamepad, NULL, play_effect); + } +#endif + ret = input_register_device(gamepad); if (ret) return ERR_PTR(ret); @@ -521,6 +601,92 @@ static int dualsense_get_mac_address(struct dualsense *ds) return ret; } +static void dualsense_init_output_report(struct dualsense *ds, struct dualsense_output_report *rp, + void *buf) +{ + struct hid_device *hdev = ds->base.hdev; + + if (hdev->bus == BUS_BLUETOOTH) { + struct dualsense_output_report_bt *bt = buf; + + memset(bt, 0, sizeof(*bt)); + bt->report_id = DS_OUTPUT_REPORT_BT; + bt->tag = 0x10; /* Magic number must be set to 0x10 */ + + /* Highest 4-bit is a sequence number, which needs to be increased + * every report. Lowest 4-bit is tag and can be zero for now. + */ + bt->seq_tag = (ds->output_seq << 4) | 0x0; + if (++ds->output_seq == 15) + ds->output_seq = 0; + + rp->data = buf; + rp->len = sizeof(*bt); + rp->bt = bt; + rp->usb = NULL; + rp->common = &bt->common; + } else { /* USB */ + struct dualsense_output_report_usb *usb = buf; + + memset(usb, 0, sizeof(*usb)); + usb->report_id = DS_OUTPUT_REPORT_USB; + + rp->data = buf; + rp->len = sizeof(*usb); + rp->bt = NULL; + rp->usb = usb; + rp->common = &usb->common; + } +} + +/* Helper function to send DualSense output reports. Applies a CRC at the end of a report + * for Bluetooth reports. + */ +static void dualsense_send_output_report(struct dualsense *ds, + struct dualsense_output_report *report) +{ + struct hid_device *hdev = ds->base.hdev; + + /* Bluetooth packets need to be signed with a CRC in the last 4 bytes. */ + if (report->bt) { + uint32_t crc; + uint8_t seed = 0xA2; + + crc = crc32_le(0xFFFFFFFF, &seed, 1); + crc = ~crc32_le(crc, report->data, report->len - 4); + + report->bt->crc32 = cpu_to_le32(crc); + } + + hid_hw_output_report(hdev, report->data, report->len); +} + +static void dualsense_output_worker(struct work_struct *work) +{ + struct dualsense *ds = container_of(work, struct dualsense, output_worker); + struct dualsense_output_report report; + struct dualsense_output_report_common *common; + unsigned long flags; + + dualsense_init_output_report(ds, &report, ds->output_report_dmabuf); + common = report.common; + + spin_lock_irqsave(&ds->base.lock, flags); + + if (ds->update_rumble) { + /* Select classic rumble style haptics and enable it. */ + common->valid_flag0 |= DS_OUTPUT_VALID_FLAG0_HAPTICS_SELECT; + common->valid_flag0 |= DS_OUTPUT_VALID_FLAG0_COMPATIBLE_VIBRATION; + common->motor_left = ds->motor_left; + common->motor_right = ds->motor_right; + ds->update_rumble = false; + } + + spin_unlock_irqrestore(&ds->base.lock, flags); + + dualsense_send_output_report(ds, &report); +} + static int dualsense_parse_report(struct ps_device *ps_dev, struct hid_report *report, u8 *data, int size) { @@ -676,10 +842,30 @@ static int dualsense_parse_report(struct ps_device *ps_dev, struct hid_report *r return 0; } +static int dualsense_play_effect(struct input_dev *dev, void *data, struct ff_effect *effect) +{ + struct hid_device *hdev = input_get_drvdata(dev); + struct dualsense *ds = hid_get_drvdata(hdev); + unsigned long flags; + + if (effect->type != FF_RUMBLE) + return 0; + + spin_lock_irqsave(&ds->base.lock, flags); + ds->update_rumble = true; + ds->motor_left = effect->u.rumble.strong_magnitude / 256; + ds->motor_right = effect->u.rumble.weak_magnitude / 256; + spin_unlock_irqrestore(&ds->base.lock, flags); + + schedule_work(&ds->output_worker); + return 0; +} + static struct ps_device *dualsense_create(struct hid_device *hdev) { struct dualsense *ds; struct ps_device *ps_dev; + uint8_t max_output_report_size; int ret; ds = devm_kzalloc(&hdev->dev, sizeof(*ds), GFP_KERNEL); @@ -696,8 +882,14 @@ static struct ps_device *dualsense_create(struct hid_device *hdev) ps_dev->battery_capacity = 100; /* initial value until parse_report. */ ps_dev->battery_status = POWER_SUPPLY_STATUS_UNKNOWN; ps_dev->parse_report = dualsense_parse_report; + INIT_WORK(&ds->output_worker, dualsense_output_worker); hid_set_drvdata(hdev, ds); + max_output_report_size = sizeof(struct dualsense_output_report_bt); + ds->output_report_dmabuf = devm_kzalloc(&hdev->dev, max_output_report_size, GFP_KERNEL); + if (!ds->output_report_dmabuf) + return ERR_PTR(-ENOMEM); + ret = dualsense_get_mac_address(ds); if (ret < 0) { hid_err(hdev, "Failed to get MAC address from DualSense\n"); @@ -715,7 +907,7 @@ static struct ps_device *dualsense_create(struct hid_device *hdev) goto err; } - ds->gamepad = ps_gamepad_create(hdev); + ds->gamepad = ps_gamepad_create(hdev, dualsense_play_effect); if (IS_ERR(ds->gamepad)) { ret = PTR_ERR(ds->gamepad); goto err;