| Message ID | 20210111052759.2144758-7-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | MAINTAINERS: remove inactive folks from networking | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | fail | Series targets non-next tree, but doesn't contain any Fixes tags |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 3 maintainers not CCed: matthias.bgg@gmail.com linux-mediatek@lists.infradead.org linux-arm-kernel@lists.infradead.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote: > Drop Felix from Mediatek Ethernet driver maintainers. > We haven't seen any tags since the initial submission. [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -11165,7 +11165,6 @@ F: Documentation/devicetree/bindings/dma/mtk-* > F: drivers/dma/mediatek/ > > > MEDIATEK ETHERNET DRIVER > -M: Felix Fietkau <nbd@nbd.name> > M: John Crispin <john@phrozen.org> > M: Sean Wang <sean.wang@mediatek.com> > M: Mark Lee <Mark-MC.Lee@mediatek.com> I think your script is broken as there are multiple subdirectories for this entry and Felix is active. For instance: commit 9716ef046b46a6426b2a11301ea5232fc8cdce63 Author: Felix Fietkau <nbd@nbd.name> Date: Sat Nov 21 18:23:35 2020 +0100 mt76: attempt to free up more room when filling the tx queue Run dma cleanup immediately if the queue is almost full, instead of waiting for the tx interrupt Signed-off-by: Felix Fietkau <nbd@nbd.name>
On Sun, 10 Jan 2021 21:45:46 -0800 Joe Perches wrote: > On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote: > > Drop Felix from Mediatek Ethernet driver maintainers. > > We haven't seen any tags since the initial submission. > [] > > diff --git a/MAINTAINERS b/MAINTAINERS > [] > > @@ -11165,7 +11165,6 @@ F: Documentation/devicetree/bindings/dma/mtk-* > > F: drivers/dma/mediatek/ > > > > > > MEDIATEK ETHERNET DRIVER > > -M: Felix Fietkau <nbd@nbd.name> > > M: John Crispin <john@phrozen.org> > > M: Sean Wang <sean.wang@mediatek.com> > > M: Mark Lee <Mark-MC.Lee@mediatek.com> > > I think your script is broken as there are multiple subdirectories > for this entry and Quite the opposite, the script intentionally only counts contributions only to the code under the MAINTAINERS entry. People lose interest and move on to working on other parts of the kernel (or maybe were never that interested in maintaining something in the first place?). We want to list folks who are likely to give us reviews. > Felix is active. Which I tried to state in the commit message as well :)
On Mon, 2021-01-11 at 09:41 -0800, Jakub Kicinski wrote: > On Sun, 10 Jan 2021 21:45:46 -0800 Joe Perches wrote: > > On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote: > > > Drop Felix from Mediatek Ethernet driver maintainers. > > > We haven't seen any tags since the initial submission. > > [] > > > diff --git a/MAINTAINERS b/MAINTAINERS > > [] > > > @@ -11165,7 +11165,6 @@ F: Documentation/devicetree/bindings/dma/mtk-* > > > F: drivers/dma/mediatek/ > > > > > > > > > MEDIATEK ETHERNET DRIVER > > > -M: Felix Fietkau <nbd@nbd.name> > > > M: John Crispin <john@phrozen.org> > > > M: Sean Wang <sean.wang@mediatek.com> > > > M: Mark Lee <Mark-MC.Lee@mediatek.com> > > > > I think your script is broken as there are multiple subdirectories > > for this entry and > > Quite the opposite, the script intentionally only counts contributions > only to the code under the MAINTAINERS entry. My mistake. I'd seen Felix's name fairly often. I ran this command: $ git log --pretty=oneline --since=5-years-ago --grep="-by: Felix Fietkau" drivers/net/ethernet/mediatek/ 656e705243fd0c2864b89634ea16ed444ef64dc6 net-next: mediatek: add support for MT7623 ethernet Saw that felix had worked on mediatek and then looked up files in drivers/net with mediatek and conflated the wireless files and ethernet files. btw: because I didn't see the script published and so can't verify what's being done here, the MAINTAINERS file shows: F: *Files* and directories wildcard patterns. A trailing slash includes all files and subdirectory files. F: drivers/net/ all files in and below drivers/net F: drivers/net/* all files in drivers/net, but not below cheers, Joe
On 2021-01-11 18:41, Jakub Kicinski wrote: > On Sun, 10 Jan 2021 21:45:46 -0800 Joe Perches wrote: >> On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote: >> > Drop Felix from Mediatek Ethernet driver maintainers. >> > We haven't seen any tags since the initial submission. >> [] >> > diff --git a/MAINTAINERS b/MAINTAINERS >> [] >> > @@ -11165,7 +11165,6 @@ F: Documentation/devicetree/bindings/dma/mtk-* >> > F: drivers/dma/mediatek/ >> > >> > >> > MEDIATEK ETHERNET DRIVER >> > -M: Felix Fietkau <nbd@nbd.name> >> > M: John Crispin <john@phrozen.org> >> > M: Sean Wang <sean.wang@mediatek.com> >> > M: Mark Lee <Mark-MC.Lee@mediatek.com> >> >> I think your script is broken as there are multiple subdirectories >> for this entry and > > Quite the opposite, the script intentionally only counts contributions > only to the code under the MAINTAINERS entry. People lose interest and > move on to working on other parts of the kernel (or maybe were never > that interested in maintaining something in the first place?). > > We want to list folks who are likely to give us reviews. > >> Felix is active. > > Which I tried to state in the commit message as well :) Sorry for the delayed response. I'm going to submit a bunch of work on this driver in the near future. The patches have already been written, just need a bit more time for testing/review. - Felix
On Mon, 11 Jan 2021 20:21:23 +0100 Felix Fietkau wrote: > On 2021-01-11 18:41, Jakub Kicinski wrote: > > On Sun, 10 Jan 2021 21:45:46 -0800 Joe Perches wrote: > >> On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote: > >> > Drop Felix from Mediatek Ethernet driver maintainers. > >> > We haven't seen any tags since the initial submission. > >> [] > >> > diff --git a/MAINTAINERS b/MAINTAINERS > >> [] > >> > @@ -11165,7 +11165,6 @@ F: Documentation/devicetree/bindings/dma/mtk-* > >> > F: drivers/dma/mediatek/ > >> > > >> > > >> > MEDIATEK ETHERNET DRIVER > >> > -M: Felix Fietkau <nbd@nbd.name> > >> > M: John Crispin <john@phrozen.org> > >> > M: Sean Wang <sean.wang@mediatek.com> > >> > M: Mark Lee <Mark-MC.Lee@mediatek.com> > >> > >> I think your script is broken as there are multiple subdirectories > >> for this entry and > > > > Quite the opposite, the script intentionally only counts contributions > > only to the code under the MAINTAINERS entry. People lose interest and > > move on to working on other parts of the kernel (or maybe were never > > that interested in maintaining something in the first place?). > > > > We want to list folks who are likely to give us reviews. > > > >> Felix is active. > > > > Which I tried to state in the commit message as well :) > Sorry for the delayed response. I'm going to submit a bunch of work on > this driver in the near future. > The patches have already been written, just need a bit more time for > testing/review. Great, I'll drop this patch from the series. Thanks!
diff --git a/MAINTAINERS b/MAINTAINERS index 92fdc134ca14..b3e88594808a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11165,7 +11165,6 @@ F: Documentation/devicetree/bindings/dma/mtk-* F: drivers/dma/mediatek/ MEDIATEK ETHERNET DRIVER -M: Felix Fietkau <nbd@nbd.name> M: John Crispin <john@phrozen.org> M: Sean Wang <sean.wang@mediatek.com> M: Mark Lee <Mark-MC.Lee@mediatek.com>
Drop Felix from Mediatek Ethernet driver maintainers. We haven't seen any tags since the initial submission. Not adding a CREDITS entry because summarizing Felix's contributions as "initial Mediatek MT7623 driver" is really selling it short. And Felix is not gone, so he can write his own description :P Subsystem MEDIATEK ETHERNET DRIVER Changes 39 / 196 (19%) Last activity: 2020-04-07 Felix Fietkau <nbd@nbd.name>: John Crispin <john@phrozen.org>: Author 6427dc1da51d 2017-08-09 00:00:00 28 Tags 6427dc1da51d 2017-08-09 00:00:00 38 Sean Wang <sean.wang@mediatek.com>: Author 880c2d4b2fdf 2019-06-03 00:00:00 50 Tags a5d75538295b 2020-04-07 00:00:00 55 Mark Lee <Mark-MC.Lee@mediatek.com>: Author 8d66a8183d0c 2019-11-14 00:00:00 4 Tags 8d66a8183d0c 2019-11-14 00:00:00 4 Top reviewers: [8]: andrew@lunn.ch [7]: f.fainelli@gmail.com INACTIVE MAINTAINER Felix Fietkau <nbd@nbd.name> Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: Felix Fietkau <nbd@nbd.name> CC: John Crispin <john@phrozen.org> CC: Sean Wang <sean.wang@mediatek.com> CC: Mark Lee <Mark-MC.Lee@mediatek.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-)