| Message ID | 20210112084605.7110-1-dong.menglong@zte.com.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | edac: remove redundant error print in xgene_edac_probe | expand |
On 12.01.21 00:46:05, menglong8.dong@gmail.com wrote: > From: Menglong Dong <dong.menglong@zte.com.cn> > > Coccinelle reports a redundant error print in xgene_edac_probe. > As 'platform_get_irq' already prints the error message, error > print here is redundant and can be removed. > > Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn> > --- > drivers/edac/xgene_edac.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c > index 1d2c27a00a4a..1d583f0ea4dc 100644 > --- a/drivers/edac/xgene_edac.c > +++ b/drivers/edac/xgene_edac.c > @@ -1918,7 +1918,6 @@ static int xgene_edac_probe(struct platform_device *pdev) > for (i = 0; i < 3; i++) { > irq = platform_get_irq(pdev, i); > if (irq < 0) { > - dev_err(&pdev->dev, "No IRQ resource\n"); Better call platform_get_irq_optional() instead. That would keep the same error message patterns for all error paths of the probe function. -Robert > rc = -EINVAL; > goto out_err; > } > -- > 2.17.1 >
diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c index 1d2c27a00a4a..1d583f0ea4dc 100644 --- a/drivers/edac/xgene_edac.c +++ b/drivers/edac/xgene_edac.c @@ -1918,7 +1918,6 @@ static int xgene_edac_probe(struct platform_device *pdev) for (i = 0; i < 3; i++) { irq = platform_get_irq(pdev, i); if (irq < 0) { - dev_err(&pdev->dev, "No IRQ resource\n"); rc = -EINVAL; goto out_err; }