drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST

Commit Message

Sean Paul Jan. 6, 2021, 10:38 p.m. UTC

From: Sean Paul <[e-mail]>

The HDCP 1.4 spec does not require the QUERY_STREAM_ENCRYPTION_STATUS
check, it was always a nice-to-have. After deploying this across various
devices, we've determined that some MST bridge chips do not properly
support this call for HDCP 1.4 (namely Synaptics and Realtek).

I had considered creating a quirk for this, but I think it's more
prudent to just disable the check entirely since I don't have an idea
how widespread support is.

Signed-off-by: Sean Paul <[e-mail]>
---
 drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 26 +-------------------
 1 file changed, 1 insertion(+), 25 deletions(-)

Comments

Jani Nikula Jan. 12, 2021, 5:51 p.m. UTC | #1

Anshuman, please review.

BR,
Jani.

On Wed, 06 Jan 2021, Sean Paul <[e-mail]> wrote:
> From: Sean Paul <[e-mail]>
>
> The HDCP 1.4 spec does not require the QUERY_STREAM_ENCRYPTION_STATUS
> check, it was always a nice-to-have. After deploying this across various
> devices, we've determined that some MST bridge chips do not properly
> support this call for HDCP 1.4 (namely Synaptics and Realtek).
>
> I had considered creating a quirk for this, but I think it's more
> prudent to just disable the check entirely since I don't have an idea
> how widespread support is.
>
> Signed-off-by: Sean Paul <[e-mail]>
> ---
>  drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 26 +-------------------
>  1 file changed, 1 insertion(+), 25 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> index 03424d20e9f7..b6a9606bf09a 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> @@ -640,30 +640,6 @@ intel_dp_mst_hdcp_toggle_signalling(struct intel_digital_port *dig_port,
>  	return ret;
>  }
>  
> -static
> -bool intel_dp_mst_hdcp_check_link(struct intel_digital_port *dig_port,
> -				  struct intel_connector *connector)
> -{
> -	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
> -	struct intel_dp *intel_dp = &dig_port->dp;
> -	struct drm_dp_query_stream_enc_status_ack_reply reply;
> -	int ret;
> -
> -	if (!intel_dp_hdcp_check_link(dig_port, connector))
> -		return false;
> -
> -	ret = drm_dp_send_query_stream_enc_status(&intel_dp->mst_mgr,
> -						  connector->port, &reply);
> -	if (ret) {
> -		drm_dbg_kms(&i915->drm,
> -			    "[CONNECTOR:%d:%s] failed QSES ret=%d\n",
> -			    connector->base.base.id, connector->base.name, ret);
> -		return false;
> -	}
> -
> -	return reply.auth_completed && reply.encryption_enabled;
> -}
> -
>  static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
>  	.write_an_aksv = intel_dp_hdcp_write_an_aksv,
>  	.read_bksv = intel_dp_hdcp_read_bksv,
> @@ -674,7 +650,7 @@ static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
>  	.read_ksv_fifo = intel_dp_hdcp_read_ksv_fifo,
>  	.read_v_prime_part = intel_dp_hdcp_read_v_prime_part,
>  	.toggle_signalling = intel_dp_mst_hdcp_toggle_signalling,
> -	.check_link = intel_dp_mst_hdcp_check_link,
> +	.check_link = intel_dp_hdcp_check_link,
>  	.hdcp_capable = intel_dp_hdcp_capable,
>  
>  	.protocol = HDCP_PROTOCOL_DP,

Gupta, Anshuman Jan. 13, 2021, 10:19 a.m. UTC | #2

On 2021-01-07 at 04:08:58 +0530, Sean Paul wrote:
> From: Sean Paul <[e-mail]>
> 
> The HDCP 1.4 spec does not require the QUERY_STREAM_ENCRYPTION_STATUS
IMHO DP 1.4 vesa specs I.3.5 mark QSES as desirale for both HDCP 1.4 and HDCP 2.2.
"The MST Source device may use a QUERY_STREAM_ENCRYPTION_STATUS message
transaction to query the downstream status for a particular stream."

I feel it useful for scenario in which a non hdcp supported monitor
is hot plugged to MST branch. Source really doesn't know about the hdcp
capable device on MST branch, it just know the capability of immediate 
downstream device. QSES can fetch the HDCP capability from MST topology. 
We don't require to enable stream encryption for such streams. 
> check, it was always a nice-to-have. After deploying this across various
> devices, we've determined that some MST bridge chips do not properly
> support this call for HDCP 1.4 (namely Synaptics and Realtek).
> 
> I had considered creating a quirk for this, but I think it's more
> prudent to just disable the check entirely since I don't have an idea
> how widespread support is.
May be we can remove it from the link check and can retain as utility ?
Thanks,
Anshuman Gupta.
> 
> Signed-off-by: Sean Paul <[e-mail]>
> ---
>  drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 26 +-------------------
>  1 file changed, 1 insertion(+), 25 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> index 03424d20e9f7..b6a9606bf09a 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> @@ -640,30 +640,6 @@ intel_dp_mst_hdcp_toggle_signalling(struct intel_digital_port *dig_port,
>  	return ret;
>  }
>  
> -static
> -bool intel_dp_mst_hdcp_check_link(struct intel_digital_port *dig_port,
> -				  struct intel_connector *connector)
> -{
> -	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
> -	struct intel_dp *intel_dp = &dig_port->dp;
> -	struct drm_dp_query_stream_enc_status_ack_reply reply;
> -	int ret;
> -
> -	if (!intel_dp_hdcp_check_link(dig_port, connector))
> -		return false;
> -
> -	ret = drm_dp_send_query_stream_enc_status(&intel_dp->mst_mgr,
> -						  connector->port, &reply);
> -	if (ret) {
> -		drm_dbg_kms(&i915->drm,
> -			    "[CONNECTOR:%d:%s] failed QSES ret=%d\n",
> -			    connector->base.base.id, connector->base.name, ret);
> -		return false;
> -	}
> -
> -	return reply.auth_completed && reply.encryption_enabled;
> -}
> -
>  static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
>  	.write_an_aksv = intel_dp_hdcp_write_an_aksv,
>  	.read_bksv = intel_dp_hdcp_read_bksv,
> @@ -674,7 +650,7 @@ static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
>  	.read_ksv_fifo = intel_dp_hdcp_read_ksv_fifo,
>  	.read_v_prime_part = intel_dp_hdcp_read_v_prime_part,
>  	.toggle_signalling = intel_dp_mst_hdcp_toggle_signalling,
> -	.check_link = intel_dp_mst_hdcp_check_link,
> +	.check_link = intel_dp_hdcp_check_link,
>  	.hdcp_capable = intel_dp_hdcp_capable,
>  
>  	.protocol = HDCP_PROTOCOL_DP,
> -- 
> Sean Paul, Software Engineer, Google / Chromium OS
> 
> _______________________________________________
> Intel-gfx mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Sean Paul Jan. 13, 2021, 1:39 p.m. UTC | #3

On Wed, Jan 13, 2021 at 5:34 AM Anshuman Gupta <[e-mail]> wrote:
>
> On 2021-01-07 at 04:08:58 +0530, Sean Paul wrote:
> > From: Sean Paul <[e-mail]>
> >
> > The HDCP 1.4 spec does not require the QUERY_STREAM_ENCRYPTION_STATUS
> IMHO DP 1.4 vesa specs I.3.5 mark QSES as desirale for both HDCP 1.4 and HDCP 2.2.
> "The MST Source device may use a QUERY_STREAM_ENCRYPTION_STATUS message
> transaction to query the downstream status for a particular stream."
>
> I feel it useful for scenario in which a non hdcp supported monitor
> is hot plugged to MST branch. Source really doesn't know about the hdcp
> capable device on MST branch, it just know the capability of immediate
> downstream device. QSES can fetch the HDCP capability from MST topology.
> We don't require to enable stream encryption for such streams.

I agree it's useful when it works, but unfortunately it's broken on at
least 2 MST bridge chips I've encountered :/

Until we can figure out a) how to fix them (ie: firmware updates), or
b) how to enumerate all of the broken chips to create quirks, we
probably just want to disable QSES for HDCP 1.4.

Sean

> > check, it was always a nice-to-have. After deploying this across various
> > devices, we've determined that some MST bridge chips do not properly
> > support this call for HDCP 1.4 (namely Synaptics and Realtek).
> >
> > I had considered creating a quirk for this, but I think it's more
> > prudent to just disable the check entirely since I don't have an idea
> > how widespread support is.
> May be we can remove it from the link check and can retain as utility ?
> Thanks,
> Anshuman Gupta.
> >
> > Signed-off-by: Sean Paul <[e-mail]>
> > ---
> >  drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 26 +-------------------
> >  1 file changed, 1 insertion(+), 25 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > index 03424d20e9f7..b6a9606bf09a 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > @@ -640,30 +640,6 @@ intel_dp_mst_hdcp_toggle_signalling(struct intel_digital_port *dig_port,
> >       return ret;
> >  }
> >
> > -static
> > -bool intel_dp_mst_hdcp_check_link(struct intel_digital_port *dig_port,
> > -                               struct intel_connector *connector)
> > -{
> > -     struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
> > -     struct intel_dp *intel_dp = &dig_port->dp;
> > -     struct drm_dp_query_stream_enc_status_ack_reply reply;
> > -     int ret;
> > -
> > -     if (!intel_dp_hdcp_check_link(dig_port, connector))
> > -             return false;
> > -
> > -     ret = drm_dp_send_query_stream_enc_status(&intel_dp->mst_mgr,
> > -                                               connector->port, &reply);
> > -     if (ret) {
> > -             drm_dbg_kms(&i915->drm,
> > -                         "[CONNECTOR:%d:%s] failed QSES ret=%d\n",
> > -                         connector->base.base.id, connector->base.name, ret);
> > -             return false;
> > -     }
> > -
> > -     return reply.auth_completed && reply.encryption_enabled;
> > -}
> > -
> >  static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
> >       .write_an_aksv = intel_dp_hdcp_write_an_aksv,
> >       .read_bksv = intel_dp_hdcp_read_bksv,
> > @@ -674,7 +650,7 @@ static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
> >       .read_ksv_fifo = intel_dp_hdcp_read_ksv_fifo,
> >       .read_v_prime_part = intel_dp_hdcp_read_v_prime_part,
> >       .toggle_signalling = intel_dp_mst_hdcp_toggle_signalling,
> > -     .check_link = intel_dp_mst_hdcp_check_link,
> > +     .check_link = intel_dp_hdcp_check_link,
> >       .hdcp_capable = intel_dp_hdcp_capable,
> >
> >       .protocol = HDCP_PROTOCOL_DP,
> > --
> > Sean Paul, Software Engineer, Google / Chromium OS
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > [e-mail]
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Daniel Vetter Jan. 13, 2021, 2:31 p.m. UTC | #4

On Wed, Jan 13, 2021 at 2:39 PM Sean Paul <[e-mail]> wrote:
>
> On Wed, Jan 13, 2021 at 5:34 AM Anshuman Gupta <[e-mail]> wrote:
> >
> > On 2021-01-07 at 04:08:58 +0530, Sean Paul wrote:
> > > From: Sean Paul <[e-mail]>
> > >
> > > The HDCP 1.4 spec does not require the QUERY_STREAM_ENCRYPTION_STATUS
> > IMHO DP 1.4 vesa specs I.3.5 mark QSES as desirale for both HDCP 1.4 and HDCP 2.2.
> > "The MST Source device may use a QUERY_STREAM_ENCRYPTION_STATUS message
> > transaction to query the downstream status for a particular stream."
> >
> > I feel it useful for scenario in which a non hdcp supported monitor
> > is hot plugged to MST branch. Source really doesn't know about the hdcp
> > capable device on MST branch, it just know the capability of immediate
> > downstream device. QSES can fetch the HDCP capability from MST topology.
> > We don't require to enable stream encryption for such streams.
>
> I agree it's useful when it works, but unfortunately it's broken on at
> least 2 MST bridge chips I've encountered :/
>
> Until we can figure out a) how to fix them (ie: firmware updates), or
> b) how to enumerate all of the broken chips to create quirks, we
> probably just want to disable QSES for HDCP 1.4.

What happens when the user plugs in a non-hdcp screen into a hub which
doesn't do QSES? Just black screen?

That would suck a bit, otoh with broken hw I don't see how we could do
better :-/
-Daniel

> Sean
>
> > > check, it was always a nice-to-have. After deploying this across various
> > > devices, we've determined that some MST bridge chips do not properly
> > > support this call for HDCP 1.4 (namely Synaptics and Realtek).
> > >
> > > I had considered creating a quirk for this, but I think it's more
> > > prudent to just disable the check entirely since I don't have an idea
> > > how widespread support is.
> > May be we can remove it from the link check and can retain as utility ?
> > Thanks,
> > Anshuman Gupta.
> > >
> > > Signed-off-by: Sean Paul <[e-mail]>
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 26 +-------------------
> > >  1 file changed, 1 insertion(+), 25 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > index 03424d20e9f7..b6a9606bf09a 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > @@ -640,30 +640,6 @@ intel_dp_mst_hdcp_toggle_signalling(struct intel_digital_port *dig_port,
> > >       return ret;
> > >  }
> > >
> > > -static
> > > -bool intel_dp_mst_hdcp_check_link(struct intel_digital_port *dig_port,
> > > -                               struct intel_connector *connector)
> > > -{
> > > -     struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
> > > -     struct intel_dp *intel_dp = &dig_port->dp;
> > > -     struct drm_dp_query_stream_enc_status_ack_reply reply;
> > > -     int ret;
> > > -
> > > -     if (!intel_dp_hdcp_check_link(dig_port, connector))
> > > -             return false;
> > > -
> > > -     ret = drm_dp_send_query_stream_enc_status(&intel_dp->mst_mgr,
> > > -                                               connector->port, &reply);
> > > -     if (ret) {
> > > -             drm_dbg_kms(&i915->drm,
> > > -                         "[CONNECTOR:%d:%s] failed QSES ret=%d\n",
> > > -                         connector->base.base.id, connector->base.name, ret);
> > > -             return false;
> > > -     }
> > > -
> > > -     return reply.auth_completed && reply.encryption_enabled;
> > > -}
> > > -
> > >  static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
> > >       .write_an_aksv = intel_dp_hdcp_write_an_aksv,
> > >       .read_bksv = intel_dp_hdcp_read_bksv,
> > > @@ -674,7 +650,7 @@ static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
> > >       .read_ksv_fifo = intel_dp_hdcp_read_ksv_fifo,
> > >       .read_v_prime_part = intel_dp_hdcp_read_v_prime_part,
> > >       .toggle_signalling = intel_dp_mst_hdcp_toggle_signalling,
> > > -     .check_link = intel_dp_mst_hdcp_check_link,
> > > +     .check_link = intel_dp_hdcp_check_link,
> > >       .hdcp_capable = intel_dp_hdcp_capable,
> > >
> > >       .protocol = HDCP_PROTOCOL_DP,
> > > --
> > > Sean Paul, Software Engineer, Google / Chromium OS
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > [e-mail]
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> dri-devel mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Sean Paul Jan. 13, 2021, 6:33 p.m. UTC | #5

On Wed, Jan 13, 2021 at 9:31 AM Daniel Vetter <[e-mail]> wrote:
>
> On Wed, Jan 13, 2021 at 2:39 PM Sean Paul <[e-mail]> wrote:
> >
> > On Wed, Jan 13, 2021 at 5:34 AM Anshuman Gupta <[e-mail]> wrote:
> > >
> > > On 2021-01-07 at 04:08:58 +0530, Sean Paul wrote:
> > > > From: Sean Paul <[e-mail]>
> > > >
> > > > The HDCP 1.4 spec does not require the QUERY_STREAM_ENCRYPTION_STATUS
> > > IMHO DP 1.4 vesa specs I.3.5 mark QSES as desirale for both HDCP 1.4 and HDCP 2.2.
> > > "The MST Source device may use a QUERY_STREAM_ENCRYPTION_STATUS message
> > > transaction to query the downstream status for a particular stream."
> > >
> > > I feel it useful for scenario in which a non hdcp supported monitor
> > > is hot plugged to MST branch. Source really doesn't know about the hdcp
> > > capable device on MST branch, it just know the capability of immediate
> > > downstream device. QSES can fetch the HDCP capability from MST topology.
> > > We don't require to enable stream encryption for such streams.
> >
> > I agree it's useful when it works, but unfortunately it's broken on at
> > least 2 MST bridge chips I've encountered :/
> >
> > Until we can figure out a) how to fix them (ie: firmware updates), or
> > b) how to enumerate all of the broken chips to create quirks, we
> > probably just want to disable QSES for HDCP 1.4.
>
> What happens when the user plugs in a non-hdcp screen into a hub which
> doesn't do QSES? Just black screen?
>

Good question, thanks for forcing me to explain myself more thoroughly :)

This patch doesn't change that behavior, QSES is currently only used
as a means for verifying the stream continues to be encrypted in
steady-state (ie: after auth has already completed and the pixels are
flowing).

If one wanted to check HDCP 1.4 capability upfront, QSES wouldn't be
the way to do it. Instead you would tunnel a remote DPCD to the sink
to read the BCAPS register (ie: the same way we check non-MST
connectors).

So QSES is currently only around in HDCP 1.4 as an extra precaution
against a bug in the code preventing the MST stream from being
encrypted. IMO broken HW overrules suspenders when we already have a
belt :)


Sean

> That would suck a bit, otoh with broken hw I don't see how we could do
> better :-/
> -Daniel
>
> > Sean
> >
> > > > check, it was always a nice-to-have. After deploying this across various
> > > > devices, we've determined that some MST bridge chips do not properly
> > > > support this call for HDCP 1.4 (namely Synaptics and Realtek).
> > > >
> > > > I had considered creating a quirk for this, but I think it's more
> > > > prudent to just disable the check entirely since I don't have an idea
> > > > how widespread support is.
> > > May be we can remove it from the link check and can retain as utility ?
> > > Thanks,
> > > Anshuman Gupta.
> > > >
> > > > Signed-off-by: Sean Paul <[e-mail]>
> > > > ---
> > > >  drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 26 +-------------------
> > > >  1 file changed, 1 insertion(+), 25 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > > index 03424d20e9f7..b6a9606bf09a 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > > @@ -640,30 +640,6 @@ intel_dp_mst_hdcp_toggle_signalling(struct intel_digital_port *dig_port,
> > > >       return ret;
> > > >  }
> > > >
> > > > -static
> > > > -bool intel_dp_mst_hdcp_check_link(struct intel_digital_port *dig_port,
> > > > -                               struct intel_connector *connector)
> > > > -{
> > > > -     struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
> > > > -     struct intel_dp *intel_dp = &dig_port->dp;
> > > > -     struct drm_dp_query_stream_enc_status_ack_reply reply;
> > > > -     int ret;
> > > > -
> > > > -     if (!intel_dp_hdcp_check_link(dig_port, connector))
> > > > -             return false;
> > > > -
> > > > -     ret = drm_dp_send_query_stream_enc_status(&intel_dp->mst_mgr,
> > > > -                                               connector->port, &reply);
> > > > -     if (ret) {
> > > > -             drm_dbg_kms(&i915->drm,
> > > > -                         "[CONNECTOR:%d:%s] failed QSES ret=%d\n",
> > > > -                         connector->base.base.id, connector->base.name, ret);
> > > > -             return false;
> > > > -     }
> > > > -
> > > > -     return reply.auth_completed && reply.encryption_enabled;
> > > > -}
> > > > -
> > > >  static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
> > > >       .write_an_aksv = intel_dp_hdcp_write_an_aksv,
> > > >       .read_bksv = intel_dp_hdcp_read_bksv,
> > > > @@ -674,7 +650,7 @@ static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
> > > >       .read_ksv_fifo = intel_dp_hdcp_read_ksv_fifo,
> > > >       .read_v_prime_part = intel_dp_hdcp_read_v_prime_part,
> > > >       .toggle_signalling = intel_dp_mst_hdcp_toggle_signalling,
> > > > -     .check_link = intel_dp_mst_hdcp_check_link,
> > > > +     .check_link = intel_dp_hdcp_check_link,
> > > >       .hdcp_capable = intel_dp_hdcp_capable,
> > > >
> > > >       .protocol = HDCP_PROTOCOL_DP,
> > > > --
> > > > Sean Paul, Software Engineer, Google / Chromium OS
> > > >
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > [e-mail]
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > _______________________________________________
> > dri-devel mailing list
> > [e-mail]
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

Daniel Vetter Jan. 13, 2021, 8:45 p.m. UTC | #6

On Wed, Jan 13, 2021 at 7:34 PM Sean Paul <[e-mail]> wrote:
>
> On Wed, Jan 13, 2021 at 9:31 AM Daniel Vetter <[e-mail]> wrote:
> >
> > On Wed, Jan 13, 2021 at 2:39 PM Sean Paul <[e-mail]> wrote:
> > >
> > > On Wed, Jan 13, 2021 at 5:34 AM Anshuman Gupta <[e-mail]> wrote:
> > > >
> > > > On 2021-01-07 at 04:08:58 +0530, Sean Paul wrote:
> > > > > From: Sean Paul <[e-mail]>
> > > > >
> > > > > The HDCP 1.4 spec does not require the QUERY_STREAM_ENCRYPTION_STATUS
> > > > IMHO DP 1.4 vesa specs I.3.5 mark QSES as desirale for both HDCP 1.4 and HDCP 2.2.
> > > > "The MST Source device may use a QUERY_STREAM_ENCRYPTION_STATUS message
> > > > transaction to query the downstream status for a particular stream."
> > > >
> > > > I feel it useful for scenario in which a non hdcp supported monitor
> > > > is hot plugged to MST branch. Source really doesn't know about the hdcp
> > > > capable device on MST branch, it just know the capability of immediate
> > > > downstream device. QSES can fetch the HDCP capability from MST topology.
> > > > We don't require to enable stream encryption for such streams.
> > >
> > > I agree it's useful when it works, but unfortunately it's broken on at
> > > least 2 MST bridge chips I've encountered :/
> > >
> > > Until we can figure out a) how to fix them (ie: firmware updates), or
> > > b) how to enumerate all of the broken chips to create quirks, we
> > > probably just want to disable QSES for HDCP 1.4.
> >
> > What happens when the user plugs in a non-hdcp screen into a hub which
> > doesn't do QSES? Just black screen?
> >
>
> Good question, thanks for forcing me to explain myself more thoroughly :)
>
> This patch doesn't change that behavior, QSES is currently only used
> as a means for verifying the stream continues to be encrypted in
> steady-state (ie: after auth has already completed and the pixels are
> flowing).
>
> If one wanted to check HDCP 1.4 capability upfront, QSES wouldn't be
> the way to do it. Instead you would tunnel a remote DPCD to the sink
> to read the BCAPS register (ie: the same way we check non-MST
> connectors).
>
> So QSES is currently only around in HDCP 1.4 as an extra precaution
> against a bug in the code preventing the MST stream from being
> encrypted. IMO broken HW overrules suspenders when we already have a
> belt :)

I think with the above explanation added to the commit message this
makes sense to merge. Fwiw, i.e. not much: Acked-by: Daniel Vetter
<[e-mail]>

Cheers, Daniel

>
>
> Sean
>
> > That would suck a bit, otoh with broken hw I don't see how we could do
> > better :-/
> > -Daniel
> >
> > > Sean
> > >
> > > > > check, it was always a nice-to-have. After deploying this across various
> > > > > devices, we've determined that some MST bridge chips do not properly
> > > > > support this call for HDCP 1.4 (namely Synaptics and Realtek).
> > > > >
> > > > > I had considered creating a quirk for this, but I think it's more
> > > > > prudent to just disable the check entirely since I don't have an idea
> > > > > how widespread support is.
> > > > May be we can remove it from the link check and can retain as utility ?
> > > > Thanks,
> > > > Anshuman Gupta.
> > > > >
> > > > > Signed-off-by: Sean Paul <[e-mail]>
> > > > > ---
> > > > >  drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 26 +-------------------
> > > > >  1 file changed, 1 insertion(+), 25 deletions(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > > > index 03424d20e9f7..b6a9606bf09a 100644
> > > > > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > > > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > > > @@ -640,30 +640,6 @@ intel_dp_mst_hdcp_toggle_signalling(struct intel_digital_port *dig_port,
> > > > >       return ret;
> > > > >  }
> > > > >
> > > > > -static
> > > > > -bool intel_dp_mst_hdcp_check_link(struct intel_digital_port *dig_port,
> > > > > -                               struct intel_connector *connector)
> > > > > -{
> > > > > -     struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
> > > > > -     struct intel_dp *intel_dp = &dig_port->dp;
> > > > > -     struct drm_dp_query_stream_enc_status_ack_reply reply;
> > > > > -     int ret;
> > > > > -
> > > > > -     if (!intel_dp_hdcp_check_link(dig_port, connector))
> > > > > -             return false;
> > > > > -
> > > > > -     ret = drm_dp_send_query_stream_enc_status(&intel_dp->mst_mgr,
> > > > > -                                               connector->port, &reply);
> > > > > -     if (ret) {
> > > > > -             drm_dbg_kms(&i915->drm,
> > > > > -                         "[CONNECTOR:%d:%s] failed QSES ret=%d\n",
> > > > > -                         connector->base.base.id, connector->base.name, ret);
> > > > > -             return false;
> > > > > -     }
> > > > > -
> > > > > -     return reply.auth_completed && reply.encryption_enabled;
> > > > > -}
> > > > > -
> > > > >  static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
> > > > >       .write_an_aksv = intel_dp_hdcp_write_an_aksv,
> > > > >       .read_bksv = intel_dp_hdcp_read_bksv,
> > > > > @@ -674,7 +650,7 @@ static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
> > > > >       .read_ksv_fifo = intel_dp_hdcp_read_ksv_fifo,
> > > > >       .read_v_prime_part = intel_dp_hdcp_read_v_prime_part,
> > > > >       .toggle_signalling = intel_dp_mst_hdcp_toggle_signalling,
> > > > > -     .check_link = intel_dp_mst_hdcp_check_link,
> > > > > +     .check_link = intel_dp_hdcp_check_link,
> > > > >       .hdcp_capable = intel_dp_hdcp_capable,
> > > > >
> > > > >       .protocol = HDCP_PROTOCOL_DP,
> > > > > --
> > > > > Sean Paul, Software Engineer, Google / Chromium OS
> > > > >
> > > > > _______________________________________________
> > > > > Intel-gfx mailing list
> > > > > [e-mail]
> > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > _______________________________________________
> > > dri-devel mailing list
> > > [e-mail]
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> >
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch

Gupta, Anshuman Jan. 15, 2021, 10:22 a.m. UTC | #7

> -----Original Message-----
> From: Sean Paul <[e-mail]>
> Sent: Thursday, January 14, 2021 12:04 AM
> To: Daniel Vetter <[e-mail]>
> Cc: Gupta, Anshuman <[e-mail]>; David Airlie
> <[e-mail]>; [e-mail]; Sean Paul
> <[e-mail]>; [e-mail]
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Disable the QSES check for
> HDCP 1.4 over MST
> 
> On Wed, Jan 13, 2021 at 9:31 AM Daniel Vetter <[e-mail]> wrote:
> >
> > On Wed, Jan 13, 2021 at 2:39 PM Sean Paul <[e-mail]> wrote:
> > >
> > > On Wed, Jan 13, 2021 at 5:34 AM Anshuman Gupta
> <[e-mail]> wrote:
> > > >
> > > > On 2021-01-07 at 04:08:58 +0530, Sean Paul wrote:
> > > > > From: Sean Paul <[e-mail]>
> > > > >
> > > > > The HDCP 1.4 spec does not require the
> > > > > QUERY_STREAM_ENCRYPTION_STATUS
> > > > IMHO DP 1.4 vesa specs I.3.5 mark QSES as desirale for both HDCP 1.4
> and HDCP 2.2.
> > > > "The MST Source device may use a
> QUERY_STREAM_ENCRYPTION_STATUS
> > > > message transaction to query the downstream status for a particular
> stream."
> > > >
> > > > I feel it useful for scenario in which a non hdcp supported
> > > > monitor is hot plugged to MST branch. Source really doesn't know
> > > > about the hdcp capable device on MST branch, it just know the
> > > > capability of immediate downstream device. QSES can fetch the HDCP
> capability from MST topology.
> > > > We don't require to enable stream encryption for such streams.
> > >
> > > I agree it's useful when it works, but unfortunately it's broken on
> > > at least 2 MST bridge chips I've encountered :/
> > >
> > > Until we can figure out a) how to fix them (ie: firmware updates),
> > > or
> > > b) how to enumerate all of the broken chips to create quirks, we
> > > probably just want to disable QSES for HDCP 1.4.
> >
> > What happens when the user plugs in a non-hdcp screen into a hub which
> > doesn't do QSES? Just black screen?
> >
> 
> Good question, thanks for forcing me to explain myself more thoroughly :)
> 
> This patch doesn't change that behavior, QSES is currently only used as a
> means for verifying the stream continues to be encrypted in steady-state
> (ie: after auth has already completed and the pixels are flowing).
> 
> If one wanted to check HDCP 1.4 capability upfront, QSES wouldn't be the
> way to do it. Instead you would tunnel a remote DPCD to the sink to read
> the BCAPS register (ie: the same way we check non-MST connectors).
AFAIK in case of MST topology source can only  get BCAPS/RXCAPS of the immediate downstream sink 
(in this particular case it will be BCAPS/RXCAPS of MST hub).
Ex. I have a HDCP 2.2 (DP-6 immediate downstream) and HDCP 1.4 (DP-7) connector setup in daisy chain setup, DP-7 just reports the RXCAPS of DP-6.
cat /sys/kernel/debug/dri/0/DP-7/i915_hdcp_sink_capability
DP-7:369 HDCP version: HDCP1.4 HDCP2.2
root@linux-Tiger-Lake-Client-Platform:/home/linux# dmesg
[180919.808209] [drm:drm_dp_dpcd_read] AUX B/DDI B/PHY B: 0x68028 AUX -> (ret=  1) 03
[180919.809089] [drm:drm_dp_dpcd_read] AUX B/DDI B/PHY B: 0x6921d AUX -> (ret=  3) 02 00 03 
I was planning to use QSES to query HDCP  in MST topology but now not sure what to do with not supported MST hubs.

However agree with you for this patch, it seems to disable the QSES link check the right thing to do.
It would require to rebase.
Reviewed-by: Anshuman Gupta <[e-mail]>
  
> 
> So QSES is currently only around in HDCP 1.4 as an extra precaution against
> a bug in the code preventing the MST stream from being encrypted. IMO
> broken HW overrules suspenders when we already have a belt :)
> 
> 
> Sean
> 
> > That would suck a bit, otoh with broken hw I don't see how we could do
> > better :-/ -Daniel
> >
> > > Sean
> > >
> > > > > check, it was always a nice-to-have. After deploying this across
> > > > > various devices, we've determined that some MST bridge chips do
> > > > > not properly support this call for HDCP 1.4 (namely Synaptics and
> Realtek).
> > > > >
> > > > > I had considered creating a quirk for this, but I think it's
> > > > > more prudent to just disable the check entirely since I don't
> > > > > have an idea how widespread support is.
> > > > May be we can remove it from the link check and can retain as utility
> ?
> > > > Thanks,
> > > > Anshuman Gupta.
> > > > >
> > > > > Signed-off-by: Sean Paul <[e-mail]>
> > > > > ---
> > > > >  drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 26
> > > > > +-------------------
> > > > >  1 file changed, 1 insertion(+), 25 deletions(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > > > b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > > > index 03424d20e9f7..b6a9606bf09a 100644
> > > > > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > > > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > > > @@ -640,30 +640,6 @@
> intel_dp_mst_hdcp_toggle_signalling(struct intel_digital_port *dig_port,
> > > > >       return ret;
> > > > >  }
> > > > >
> > > > > -static
> > > > > -bool intel_dp_mst_hdcp_check_link(struct intel_digital_port
> *dig_port,
> > > > > -                               struct intel_connector *connector)
> > > > > -{
> > > > > -     struct drm_i915_private *i915 = to_i915(dig_port-
> >base.base.dev);
> > > > > -     struct intel_dp *intel_dp = &dig_port->dp;
> > > > > -     struct drm_dp_query_stream_enc_status_ack_reply reply;
> > > > > -     int ret;
> > > > > -
> > > > > -     if (!intel_dp_hdcp_check_link(dig_port, connector))
> > > > > -             return false;
> > > > > -
> > > > > -     ret = drm_dp_send_query_stream_enc_status(&intel_dp-
> >mst_mgr,
> > > > > -                                               connector->port, &reply);
> > > > > -     if (ret) {
> > > > > -             drm_dbg_kms(&i915->drm,
> > > > > -                         "[CONNECTOR:%d:%s] failed QSES ret=%d\n",
> > > > > -                         connector->base.base.id, connector->base.name,
> ret);
> > > > > -             return false;
> > > > > -     }
> > > > > -
> > > > > -     return reply.auth_completed && reply.encryption_enabled;
> > > > > -}
> > > > > -
> > > > >  static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
> > > > >       .write_an_aksv = intel_dp_hdcp_write_an_aksv,
> > > > >       .read_bksv = intel_dp_hdcp_read_bksv, @@ -674,7 +650,7 @@
> > > > > static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
> > > > >       .read_ksv_fifo = intel_dp_hdcp_read_ksv_fifo,
> > > > >       .read_v_prime_part = intel_dp_hdcp_read_v_prime_part,
> > > > >       .toggle_signalling = intel_dp_mst_hdcp_toggle_signalling,
> > > > > -     .check_link = intel_dp_mst_hdcp_check_link,
> > > > > +     .check_link = intel_dp_hdcp_check_link,
> > > > >       .hdcp_capable = intel_dp_hdcp_capable,
> > > > >
> > > > >       .protocol = HDCP_PROTOCOL_DP,
> > > > > --
> > > > > Sean Paul, Software Engineer, Google / Chromium OS
> > > > >
> > > > > _______________________________________________
> > > > > Intel-gfx mailing list
> > > > > [e-mail]
> > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > _______________________________________________
> > > dri-devel mailing list
> > > [e-mail]
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> >
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch

Gupta, Anshuman Jan. 25, 2021, 3:26 p.m. UTC | #8

Hi Lakshmi ,
We need to merge the patch https://patchwork.freedesktop.org/series/85555/
Below are the gem failures causing the BAT to fail , those were not seen on Rev1 of this patch.
Could you please rereport-the results to trigger CI-IGT run.
Thanks,
Anshuman Gupta.

From: Intel-gfx <[e-mail]> On Behalf Of Patchwork
Sent: Friday, January 22, 2021 8:13 AM
To: Sean Paul <[e-mail]>
Cc: [e-mail]
Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)

Patch Details 
Series:
drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)
URL:
https://patchwork.freedesktop.org/series/85555/
State:
failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/index.html
CI Bug Log - changes from CI_DRM_9666 -> Patchwork_19447
Summary
FAILURE
Serious unknown changes coming with Patchwork_19447 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19447, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/index.html
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_19447:
IGT changes
Possible regressions
• igt@i915_selftest@live@gt_lrc:
o fi-bsw-n3050: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
Known issues
Here are the changes found in Patchwork_19447 that come from known issues:
IGT changes
Issues hit
• igt@gem_mmap_gtt@basic:
o fi-tgl-y: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-y/igt@[e-mail] -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-tgl-y/igt@[e-mail] (https://gitlab.freedesktop.org/drm/intel/issues/402) +2 similar issues
• igt@i915_selftest@live@hugepages:
o fi-bsw-n3050: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-bsw-n3050/igt@i915_selftest@[e-mail] -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-n3050/igt@i915_selftest@[e-mail] (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +20 similar issues
• igt@i915_selftest@live@ring_submission:
o fi-bsw-n3050: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-n3050/igt@i915_selftest@live@ring_submission.html (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +2 similar issues
• igt@kms_chamelium@dp-crc-fast:
o fi-kbl-7500u: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-kbl-7500u/igt@[e-mail] -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-kbl-7500u/igt@[e-mail] (https://gitlab.freedesktop.org/drm/intel/issues/1161 / https://gitlab.freedesktop.org/drm/intel/issues/262)
Possible fixes
• igt@gem_tiled_blits@basic:
o fi-tgl-y: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-y/igt@[e-mail] (https://gitlab.freedesktop.org/drm/intel/issues/402) -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-tgl-y/igt@[e-mail] +1 similar issue
Warnings
• igt@i915_selftest@live@execlists:
o fi-bsw-n3050: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-bsw-n3050/igt@i915_selftest@[e-mail] (https://gitlab.freedesktop.org/drm/intel/issues/2940) -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-n3050/igt@i915_selftest@[e-mail] (https://bugs.freedesktop.org/show_bug.cgi?id=109271)
Participating hosts (41 -> 37)
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u 
Build changes
• Linux: CI_DRM_9666 -> Patchwork_19447
CI-20190529: 20190529
CI_DRM_9666: 9ccbc653bf2948d1f7e9ff300dd7679b888ffa25 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19447: 69d7db003fa406df7851ab08239dd409a78f4421 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
69d7db003fa4 drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST

Vudum, Lakshminarayana Jan. 25, 2021, 4:41 p.m. UTC | #9

Hi, 

CI bug log crashes while creating an issue but I have created bug in gitlab. I will try to create issue in CI bug log again later today.
https://gitlab.freedesktop.org/drm/intel/-/issues/2998

Thanks,
Lakshmi.
-----Original Message-----
From: Gupta, Anshuman <[e-mail]> 
Sent: Monday, January 25, 2021 7:26 AM
To: [e-mail]; Vudum, Lakshminarayana <[e-mail]>
Cc: Sean Paul <[e-mail]>
Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)

Hi Lakshmi ,
We need to merge the patch https://patchwork.freedesktop.org/series/85555/
Below are the gem failures causing the BAT to fail , those were not seen on Rev1 of this patch.
Could you please rereport-the results to trigger CI-IGT run.
Thanks,
Anshuman Gupta.

From: Intel-gfx <[e-mail]> On Behalf Of Patchwork
Sent: Friday, January 22, 2021 8:13 AM
To: Sean Paul <[e-mail]>
Cc: [e-mail]
Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)

Patch Details
Series:
drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)
URL:
https://patchwork.freedesktop.org/series/85555/
State:
failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/index.html
CI Bug Log - changes from CI_DRM_9666 -> Patchwork_19447 Summary FAILURE Serious unknown changes coming with Patchwork_19447 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_19447, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/index.html
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_19447:
IGT changes
Possible regressions
• igt@i915_selftest@live@gt_lrc:
o fi-bsw-n3050: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
Known issues
Here are the changes found in Patchwork_19447 that come from known issues:
IGT changes
Issues hit
• igt@gem_mmap_gtt@basic:
o fi-tgl-y: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-y/igt@[e-mail] -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-tgl-y/igt@[e-mail] (https://gitlab.freedesktop.org/drm/intel/issues/402) +2 similar issues • igt@i915_selftest@live@hugepages:
o fi-bsw-n3050: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-bsw-n3050/igt@i915_selftest@[e-mail] -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-n3050/igt@i915_selftest@[e-mail] (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +20 similar issues • igt@i915_selftest@live@ring_submission:
o fi-bsw-n3050: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-n3050/igt@i915_selftest@live@ring_submission.html (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +2 similar issues • igt@kms_chamelium@dp-crc-fast:
o fi-kbl-7500u: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-kbl-7500u/igt@[e-mail] -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-kbl-7500u/igt@[e-mail] (https://gitlab.freedesktop.org/drm/intel/issues/1161 / https://gitlab.freedesktop.org/drm/intel/issues/262)
Possible fixes
• igt@gem_tiled_blits@basic:
o fi-tgl-y: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-y/igt@[e-mail] (https://gitlab.freedesktop.org/drm/intel/issues/402) -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-tgl-y/igt@[e-mail] +1 similar issue Warnings • igt@i915_selftest@live@execlists:
o fi-bsw-n3050: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-bsw-n3050/igt@i915_selftest@[e-mail] (https://gitlab.freedesktop.org/drm/intel/issues/2940) -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-n3050/igt@i915_selftest@[e-mail] (https://bugs.freedesktop.org/show_bug.cgi?id=109271)
Participating hosts (41 -> 37)
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u Build changes • Linux: CI_DRM_9666 -> Patchwork_19447
CI-20190529: 20190529
CI_DRM_9666: 9ccbc653bf2948d1f7e9ff300dd7679b888ffa25 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19447: 69d7db003fa406df7851ab08239dd409a78f4421 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
69d7db003fa4 drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST

Vudum, Lakshminarayana Jan. 25, 2021, 5:10 p.m. UTC | #10

Re-reported.

-----Original Message-----
From: Gupta, Anshuman <[e-mail]> 
Sent: Monday, January 25, 2021 7:26 AM
To: [e-mail]; Vudum, Lakshminarayana <[e-mail]>
Cc: Sean Paul <[e-mail]>
Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)

Hi Lakshmi ,
We need to merge the patch https://patchwork.freedesktop.org/series/85555/
Below are the gem failures causing the BAT to fail , those were not seen on Rev1 of this patch.
Could you please rereport-the results to trigger CI-IGT run.
Thanks,
Anshuman Gupta.

From: Intel-gfx <[e-mail]> On Behalf Of Patchwork
Sent: Friday, January 22, 2021 8:13 AM
To: Sean Paul <[e-mail]>
Cc: [e-mail]
Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)

Patch Details
Series:
drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)
URL:
https://patchwork.freedesktop.org/series/85555/
State:
failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/index.html
CI Bug Log - changes from CI_DRM_9666 -> Patchwork_19447 Summary FAILURE Serious unknown changes coming with Patchwork_19447 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_19447, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/index.html
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_19447:
IGT changes
Possible regressions
• igt@i915_selftest@live@gt_lrc:
o fi-bsw-n3050: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
Known issues
Here are the changes found in Patchwork_19447 that come from known issues:
IGT changes
Issues hit
• igt@gem_mmap_gtt@basic:
o fi-tgl-y: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-y/igt@[e-mail] -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-tgl-y/igt@[e-mail] (https://gitlab.freedesktop.org/drm/intel/issues/402) +2 similar issues • igt@i915_selftest@live@hugepages:
o fi-bsw-n3050: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-bsw-n3050/igt@i915_selftest@[e-mail] -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-n3050/igt@i915_selftest@[e-mail] (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +20 similar issues • igt@i915_selftest@live@ring_submission:
o fi-bsw-n3050: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-n3050/igt@i915_selftest@live@ring_submission.html (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +2 similar issues • igt@kms_chamelium@dp-crc-fast:
o fi-kbl-7500u: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-kbl-7500u/igt@[e-mail] -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-kbl-7500u/igt@[e-mail] (https://gitlab.freedesktop.org/drm/intel/issues/1161 / https://gitlab.freedesktop.org/drm/intel/issues/262)
Possible fixes
• igt@gem_tiled_blits@basic:
o fi-tgl-y: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-y/igt@[e-mail] (https://gitlab.freedesktop.org/drm/intel/issues/402) -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-tgl-y/igt@[e-mail] +1 similar issue Warnings • igt@i915_selftest@live@execlists:
o fi-bsw-n3050: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-bsw-n3050/igt@i915_selftest@[e-mail] (https://gitlab.freedesktop.org/drm/intel/issues/2940) -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-n3050/igt@i915_selftest@[e-mail] (https://bugs.freedesktop.org/show_bug.cgi?id=109271)
Participating hosts (41 -> 37)
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u Build changes • Linux: CI_DRM_9666 -> Patchwork_19447
CI-20190529: 20190529
CI_DRM_9666: 9ccbc653bf2948d1f7e9ff300dd7679b888ffa25 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19447: 69d7db003fa406df7851ab08239dd409a78f4421 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
69d7db003fa4 drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST

Gupta, Anshuman Jan. 27, 2021, 5:20 a.m. UTC | #11

Thanks Lakshmi for re-reporting it.
May I know that re-reporting will also trigger a CI-IGT run.
I am not able to see this series in CI Queue https://intel-gfx-ci.01.org/queue/index.html
Currently this patch Rev2 is not showing any CI-IGT results.

Br,
Anshuman

> -----Original Message-----
> From: Vudum, Lakshminarayana <[e-mail]>
> Sent: Monday, January 25, 2021 10:40 PM
> To: Gupta, Anshuman <[e-mail]>; intel-
> [e-mail]
> Cc: Sean Paul <[e-mail]>
> Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable the
> QSES check for HDCP 1.4 over MST (rev2)
> 
> Re-reported.
> 
> -----Original Message-----
> From: Gupta, Anshuman <[e-mail]>
> Sent: Monday, January 25, 2021 7:26 AM
> To: [e-mail]; Vudum, Lakshminarayana
> <[e-mail]>
> Cc: Sean Paul <[e-mail]>
> Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable the
> QSES check for HDCP 1.4 over MST (rev2)
> 
> Hi Lakshmi ,
> We need to merge the patch
> https://patchwork.freedesktop.org/series/85555/
> Below are the gem failures causing the BAT to fail , those were not seen on
> Rev1 of this patch.
> Could you please rereport-the results to trigger CI-IGT run.
> Thanks,
> Anshuman Gupta.
> 
> From: Intel-gfx <[e-mail]> On Behalf Of
> Patchwork
> Sent: Friday, January 22, 2021 8:13 AM
> To: Sean Paul <[e-mail]>
> Cc: [e-mail]
> Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable the QSES
> check for HDCP 1.4 over MST (rev2)
> 
> Patch Details
> Series:
> drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)
> URL:
> https://patchwork.freedesktop.org/series/85555/
> State:
> failure
> Details:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/index.html
> CI Bug Log - changes from CI_DRM_9666 -> Patchwork_19447 Summary
> FAILURE Serious unknown changes coming with Patchwork_19447
> absolutely need to be verified manually.
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_19447, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
> External URL: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_19447/index.html
> Possible new issues
> Here are the unknown changes that may have been introduced in
> Patchwork_19447:
> IGT changes
> Possible regressions
> • igt@i915_selftest@live@gt_lrc:
> o fi-bsw-n3050: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> bsw-n3050/igt@i915_selftest@live@gt_lrc.html -> https://intel-gfx-
> ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-
> n3050/igt@i915_selftest@live@gt_lrc.html
> Known issues
> Here are the changes found in Patchwork_19447 that come from known
> issues:
> IGT changes
> Issues hit
> • igt@gem_mmap_gtt@basic:
> o fi-tgl-y: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-
> y/igt@[e-mail] -> https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_19447/fi-tgl-y/igt@[e-mail]
> (https://gitlab.freedesktop.org/drm/intel/issues/402) +2 similar issues •
> igt@i915_selftest@live@hugepages:
> o fi-bsw-n3050: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> bsw-n3050/igt@i915_selftest@[e-mail] -> https://intel-gfx-
> ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-
> n3050/igt@i915_selftest@[e-mail]
> (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +20 similar issues
> • igt@i915_selftest@live@ring_submission:
> o fi-bsw-n3050: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_19447/fi-bsw-
> n3050/igt@i915_selftest@live@ring_submission.html
> (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +2 similar issues
> • igt@kms_chamelium@dp-crc-fast:
> o fi-kbl-7500u: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> kbl-7500u/igt@[e-mail] -> https://intel-gfx-
> ci.01.org/tree/drm-tip/Patchwork_19447/fi-kbl-
> 7500u/igt@[e-mail]
> (https://gitlab.freedesktop.org/drm/intel/issues/1161 /
> https://gitlab.freedesktop.org/drm/intel/issues/262)
> Possible fixes
> • igt@gem_tiled_blits@basic:
> o fi-tgl-y: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-
> y/igt@[e-mail]
> (https://gitlab.freedesktop.org/drm/intel/issues/402) -> https://intel-gfx-
> ci.01.org/tree/drm-tip/Patchwork_19447/fi-tgl-
> y/igt@[e-mail] +1 similar issue Warnings •
> igt@i915_selftest@live@execlists:
> o fi-bsw-n3050: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> bsw-n3050/igt@i915_selftest@[e-mail]
> (https://gitlab.freedesktop.org/drm/intel/issues/2940) -> https://intel-gfx-
> ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-
> n3050/igt@i915_selftest@[e-mail]
> (https://bugs.freedesktop.org/show_bug.cgi?id=109271)
> Participating hosts (41 -> 37)
> Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u Build
> changes • Linux: CI_DRM_9666 -> Patchwork_19447
> CI-20190529: 20190529
> CI_DRM_9666: 9ccbc653bf2948d1f7e9ff300dd7679b888ffa25 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_19447: 69d7db003fa406df7851ab08239dd409a78f4421 @
> git://anongit.freedesktop.org/gfx-ci/linux
> == Linux commits ==
> 69d7db003fa4 drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over
> MST

Vudum, Lakshminarayana Jan. 27, 2021, 5:29 a.m. UTC | #12

Re-reporting will just re-report the results once more time. Re-reporting will re-check if there is an existing bug for the regression failures or not. If a bug is found, series shows as success (as the failure is not a regression). Regression failures will find a bug when a re-report as I either file a new bug or I will associate the regression failure to an existing bug before I re-report.

But re-reporting will not trigger re-run to see version 2 results. Let me know if you have any further questions.

Thanks,
Lakshmi.
-----Original Message-----
From: Gupta, Anshuman <[e-mail]> 
Sent: Tuesday, January 26, 2021 9:20 PM
To: Vudum, Lakshminarayana <[e-mail]>; [e-mail]
Cc: Sean Paul <[e-mail]>
Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)

Thanks Lakshmi for re-reporting it.
May I know that re-reporting will also trigger a CI-IGT run.
I am not able to see this series in CI Queue https://intel-gfx-ci.01.org/queue/index.html
Currently this patch Rev2 is not showing any CI-IGT results.

Br,
Anshuman

> -----Original Message-----
> From: Vudum, Lakshminarayana <[e-mail]>
> Sent: Monday, January 25, 2021 10:40 PM
> To: Gupta, Anshuman <[e-mail]>; intel- 
> [e-mail]
> Cc: Sean Paul <[e-mail]>
> Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: 
> Disable the QSES check for HDCP 1.4 over MST (rev2)
> 
> Re-reported.
> 
> -----Original Message-----
> From: Gupta, Anshuman <[e-mail]>
> Sent: Monday, January 25, 2021 7:26 AM
> To: [e-mail]; Vudum, Lakshminarayana 
> <[e-mail]>
> Cc: Sean Paul <[e-mail]>
> Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: 
> Disable the QSES check for HDCP 1.4 over MST (rev2)
> 
> Hi Lakshmi ,
> We need to merge the patch
> https://patchwork.freedesktop.org/series/85555/
> Below are the gem failures causing the BAT to fail , those were not 
> seen on
> Rev1 of this patch.
> Could you please rereport-the results to trigger CI-IGT run.
> Thanks,
> Anshuman Gupta.
> 
> From: Intel-gfx <[e-mail]> On Behalf Of 
> Patchwork
> Sent: Friday, January 22, 2021 8:13 AM
> To: Sean Paul <[e-mail]>
> Cc: [e-mail]
> Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable 
> the QSES check for HDCP 1.4 over MST (rev2)
> 
> Patch Details
> Series:
> drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)
> URL:
> https://patchwork.freedesktop.org/series/85555/
> State:
> failure
> Details:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/index.html
> CI Bug Log - changes from CI_DRM_9666 -> Patchwork_19447 Summary 
> FAILURE Serious unknown changes coming with Patchwork_19447 absolutely 
> need to be verified manually.
> If you think the reported changes have nothing to do with the changes 
> introduced in Patchwork_19447, please notify your bug team to allow 
> them to document this new failure mode, which will reduce false positives in CI.
> External URL: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_19447/index.html
> Possible new issues
> Here are the unknown changes that may have been introduced in
> Patchwork_19447:
> IGT changes
> Possible regressions
> • igt@i915_selftest@live@gt_lrc:
> o fi-bsw-n3050: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> bsw-n3050/igt@i915_selftest@live@gt_lrc.html -> https://intel-gfx-
> ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-
> n3050/igt@i915_selftest@live@gt_lrc.html
> Known issues
> Here are the changes found in Patchwork_19447 that come from known
> issues:
> IGT changes
> Issues hit
> • igt@gem_mmap_gtt@basic:
> o fi-tgl-y: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-
> y/igt@[e-mail] -> https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_19447/fi-tgl-y/igt@[e-mail]
> (https://gitlab.freedesktop.org/drm/intel/issues/402) +2 similar 
> issues •
> igt@i915_selftest@live@hugepages:
> o fi-bsw-n3050: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> bsw-n3050/igt@i915_selftest@[e-mail] -> https://intel-gfx-
> ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-
> n3050/igt@i915_selftest@[e-mail]
> (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +20 similar 
> issues • igt@i915_selftest@live@ring_submission:
> o fi-bsw-n3050: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_19447/fi-bsw-
> n3050/igt@i915_selftest@live@ring_submission.html
> (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +2 similar 
> issues • igt@kms_chamelium@dp-crc-fast:
> o fi-kbl-7500u: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> kbl-7500u/igt@[e-mail] -> https://intel-gfx-
> ci.01.org/tree/drm-tip/Patchwork_19447/fi-kbl-
> 7500u/igt@[e-mail]
> (https://gitlab.freedesktop.org/drm/intel/issues/1161 /
> https://gitlab.freedesktop.org/drm/intel/issues/262)
> Possible fixes
> • igt@gem_tiled_blits@basic:
> o fi-tgl-y: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-
> y/igt@[e-mail]
> (https://gitlab.freedesktop.org/drm/intel/issues/402) -> 
> https://intel-gfx-
> ci.01.org/tree/drm-tip/Patchwork_19447/fi-tgl-
> y/igt@[e-mail] +1 similar issue Warnings •
> igt@i915_selftest@live@execlists:
> o fi-bsw-n3050: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> bsw-n3050/igt@i915_selftest@[e-mail]
> (https://gitlab.freedesktop.org/drm/intel/issues/2940) -> 
> https://intel-gfx-
> ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-
> n3050/igt@i915_selftest@[e-mail]
> (https://bugs.freedesktop.org/show_bug.cgi?id=109271)
> Participating hosts (41 -> 37)
> Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u Build 
> changes • Linux: CI_DRM_9666 -> Patchwork_19447
> CI-20190529: 20190529
> CI_DRM_9666: 9ccbc653bf2948d1f7e9ff300dd7679b888ffa25 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @ 
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_19447: 69d7db003fa406df7851ab08239dd409a78f4421 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> == Linux commits ==
> 69d7db003fa4 drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over 
> MST

Gupta, Anshuman Jan. 27, 2021, 7:37 a.m. UTC | #13

> -----Original Message-----
> From: Vudum, Lakshminarayana <[e-mail]>
> Sent: Wednesday, January 27, 2021 11:00 AM
> To: Gupta, Anshuman <[e-mail]>; intel-
> [e-mail]
> Cc: Sean Paul <[e-mail]>
> Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable the
> QSES check for HDCP 1.4 over MST (rev2)
> 
> Re-reporting will just re-report the results once more time. Re-reporting will
> re-check if there is an existing bug for the regression failures or not. If a bug
> is found, series shows as success (as the failure is not a regression).
> Regression failures will find a bug when a re-report as I either file a new bug
> or I will associate the regression failure to an existing bug before I re-report.
> 
> But re-reporting will not trigger re-run to see version 2 results. Let me know
> if you have any further questions.
We don't have CI-IGT (full) results for the series https://patchwork.freedesktop.org/series/85555/#rev2 yet.
In order to merge this patch we would require CI pre merge results.
Thanks,
Anshuman Gupta.
> 
> Thanks,
> Lakshmi.
> -----Original Message-----
> From: Gupta, Anshuman <[e-mail]>
> Sent: Tuesday, January 26, 2021 9:20 PM
> To: Vudum, Lakshminarayana <[e-mail]>; intel-
> [e-mail]
> Cc: Sean Paul <[e-mail]>
> Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable the
> QSES check for HDCP 1.4 over MST (rev2)
> 
> Thanks Lakshmi for re-reporting it.
> May I know that re-reporting will also trigger a CI-IGT run.
> I am not able to see this series in CI Queue https://intel-gfx-
> ci.01.org/queue/index.html
> Currently this patch Rev2 is not showing any CI-IGT results.
> 
> Br,
> Anshuman
> 
> > -----Original Message-----
> > From: Vudum, Lakshminarayana <[e-mail]>
> > Sent: Monday, January 25, 2021 10:40 PM
> > To: Gupta, Anshuman <[e-mail]>; intel-
> > [e-mail]
> > Cc: Sean Paul <[e-mail]>
> > Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp:
> > Disable the QSES check for HDCP 1.4 over MST (rev2)
> >
> > Re-reported.
> >
> > -----Original Message-----
> > From: Gupta, Anshuman <[e-mail]>
> > Sent: Monday, January 25, 2021 7:26 AM
> > To: [e-mail]; Vudum, Lakshminarayana
> > <[e-mail]>
> > Cc: Sean Paul <[e-mail]>
> > Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp:
> > Disable the QSES check for HDCP 1.4 over MST (rev2)
> >
> > Hi Lakshmi ,
> > We need to merge the patch
> > https://patchwork.freedesktop.org/series/85555/
> > Below are the gem failures causing the BAT to fail , those were not
> > seen on
> > Rev1 of this patch.
> > Could you please rereport-the results to trigger CI-IGT run.
> > Thanks,
> > Anshuman Gupta.
> >
> > From: Intel-gfx <[e-mail]> On Behalf Of
> > Patchwork
> > Sent: Friday, January 22, 2021 8:13 AM
> > To: Sean Paul <[e-mail]>
> > Cc: [e-mail]
> > Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable
> > the QSES check for HDCP 1.4 over MST (rev2)
> >
> > Patch Details
> > Series:
> > drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)
> > URL:
> > https://patchwork.freedesktop.org/series/85555/
> > State:
> > failure
> > Details:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/index.html
> > CI Bug Log - changes from CI_DRM_9666 -> Patchwork_19447 Summary
> > FAILURE Serious unknown changes coming with Patchwork_19447
> absolutely
> > need to be verified manually.
> > If you think the reported changes have nothing to do with the changes
> > introduced in Patchwork_19447, please notify your bug team to allow
> > them to document this new failure mode, which will reduce false positives
> in CI.
> > External URL: https://intel-gfx-ci.01.org/tree/drm-
> > tip/Patchwork_19447/index.html
> > Possible new issues
> > Here are the unknown changes that may have been introduced in
> > Patchwork_19447:
> > IGT changes
> > Possible regressions
> > • igt@i915_selftest@live@gt_lrc:
> > o fi-bsw-n3050:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> > bsw-n3050/igt@i915_selftest@live@gt_lrc.html -> https://intel-gfx-
> > ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-
> > n3050/igt@i915_selftest@live@gt_lrc.html
> > Known issues
> > Here are the changes found in Patchwork_19447 that come from known
> > issues:
> > IGT changes
> > Issues hit
> > • igt@gem_mmap_gtt@basic:
> > o fi-tgl-y:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-
> > y/igt@[e-mail] -> https://intel-gfx-
> ci.01.org/tree/drm-
> > tip/Patchwork_19447/fi-tgl-y/igt@[e-mail]
> > (https://gitlab.freedesktop.org/drm/intel/issues/402) +2 similar
> > issues •
> > igt@i915_selftest@live@hugepages:
> > o fi-bsw-n3050:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> > bsw-n3050/igt@i915_selftest@[e-mail] -> https://intel-gfx-
> > ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-
> > n3050/igt@i915_selftest@[e-mail]
> > (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +20 similar
> > issues • igt@i915_selftest@live@ring_submission:
> > o fi-bsw-n3050: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-
> > tip/Patchwork_19447/fi-bsw-
> > n3050/igt@i915_selftest@live@ring_submission.html
> > (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +2 similar
> > issues • igt@kms_chamelium@dp-crc-fast:
> > o fi-kbl-7500u:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> > kbl-7500u/igt@[e-mail] -> https://intel-gfx-
> > ci.01.org/tree/drm-tip/Patchwork_19447/fi-kbl-
> > 7500u/igt@[e-mail]
> > (https://gitlab.freedesktop.org/drm/intel/issues/1161 /
> > https://gitlab.freedesktop.org/drm/intel/issues/262)
> > Possible fixes
> > • igt@gem_tiled_blits@basic:
> > o fi-tgl-y:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-
> > y/igt@[e-mail]
> > (https://gitlab.freedesktop.org/drm/intel/issues/402) ->
> > https://intel-gfx-
> > ci.01.org/tree/drm-tip/Patchwork_19447/fi-tgl-
> > y/igt@[e-mail] +1 similar issue Warnings •
> > igt@i915_selftest@live@execlists:
> > o fi-bsw-n3050:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> > bsw-n3050/igt@i915_selftest@[e-mail]
> > (https://gitlab.freedesktop.org/drm/intel/issues/2940) ->
> > https://intel-gfx-
> > ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-
> > n3050/igt@i915_selftest@[e-mail]
> > (https://bugs.freedesktop.org/show_bug.cgi?id=109271)
> > Participating hosts (41 -> 37)
> > Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u Build
> > changes • Linux: CI_DRM_9666 -> Patchwork_19447
> > CI-20190529: 20190529
> > CI_DRM_9666: 9ccbc653bf2948d1f7e9ff300dd7679b888ffa25 @
> > git://anongit.freedesktop.org/gfx-ci/linux
> > IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @
> > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > Patchwork_19447: 69d7db003fa406df7851ab08239dd409a78f4421 @
> > git://anongit.freedesktop.org/gfx-ci/linux
> > == Linux commits ==
> > 69d7db003fa4 drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over
> > MST

Vudum, Lakshminarayana Jan. 27, 2021, 7:13 p.m. UTC | #14

I am not totally sure why shard run is not triggered here https://patchwork.freedesktop.org/series/85555/#rev2
@Latvala, Petri any help here?

Thanks,
Lakshmi.

-----Original Message-----
From: Gupta, Anshuman <[e-mail]> 
Sent: Tuesday, January 26, 2021 11:38 PM
To: Vudum, Lakshminarayana <[e-mail]>; [e-mail]
Cc: Sean Paul <[e-mail]>
Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)



> -----Original Message-----
> From: Vudum, Lakshminarayana <[e-mail]>
> Sent: Wednesday, January 27, 2021 11:00 AM
> To: Gupta, Anshuman <[e-mail]>; intel- 
> [e-mail]
> Cc: Sean Paul <[e-mail]>
> Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: 
> Disable the QSES check for HDCP 1.4 over MST (rev2)
> 
> Re-reporting will just re-report the results once more time. 
> Re-reporting will re-check if there is an existing bug for the 
> regression failures or not. If a bug is found, series shows as success (as the failure is not a regression).
> Regression failures will find a bug when a re-report as I either file 
> a new bug or I will associate the regression failure to an existing bug before I re-report.
> 
> But re-reporting will not trigger re-run to see version 2 results. Let 
> me know if you have any further questions.
We don't have CI-IGT (full) results for the series https://patchwork.freedesktop.org/series/85555/#rev2 yet.
In order to merge this patch we would require CI pre merge results.
Thanks,
Anshuman Gupta.
> 
> Thanks,
> Lakshmi.
> -----Original Message-----
> From: Gupta, Anshuman <[e-mail]>
> Sent: Tuesday, January 26, 2021 9:20 PM
> To: Vudum, Lakshminarayana <[e-mail]>; intel- 
> [e-mail]
> Cc: Sean Paul <[e-mail]>
> Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: 
> Disable the QSES check for HDCP 1.4 over MST (rev2)
> 
> Thanks Lakshmi for re-reporting it.
> May I know that re-reporting will also trigger a CI-IGT run.
> I am not able to see this series in CI Queue https://intel-gfx- 
> ci.01.org/queue/index.html Currently this patch Rev2 is not showing 
> any CI-IGT results.
> 
> Br,
> Anshuman
> 
> > -----Original Message-----
> > From: Vudum, Lakshminarayana <[e-mail]>
> > Sent: Monday, January 25, 2021 10:40 PM
> > To: Gupta, Anshuman <[e-mail]>; intel- 
> > [e-mail]
> > Cc: Sean Paul <[e-mail]>
> > Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp:
> > Disable the QSES check for HDCP 1.4 over MST (rev2)
> >
> > Re-reported.
> >
> > -----Original Message-----
> > From: Gupta, Anshuman <[e-mail]>
> > Sent: Monday, January 25, 2021 7:26 AM
> > To: [e-mail]; Vudum, Lakshminarayana 
> > <[e-mail]>
> > Cc: Sean Paul <[e-mail]>
> > Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp:
> > Disable the QSES check for HDCP 1.4 over MST (rev2)
> >
> > Hi Lakshmi ,
> > We need to merge the patch
> > https://patchwork.freedesktop.org/series/85555/
> > Below are the gem failures causing the BAT to fail , those were not 
> > seen on
> > Rev1 of this patch.
> > Could you please rereport-the results to trigger CI-IGT run.
> > Thanks,
> > Anshuman Gupta.
> >
> > From: Intel-gfx <[e-mail]> On Behalf 
> > Of Patchwork
> > Sent: Friday, January 22, 2021 8:13 AM
> > To: Sean Paul <[e-mail]>
> > Cc: [e-mail]
> > Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Disable 
> > the QSES check for HDCP 1.4 over MST (rev2)
> >
> > Patch Details
> > Series:
> > drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)
> > URL:
> > https://patchwork.freedesktop.org/series/85555/
> > State:
> > failure
> > Details:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/index.html
> > CI Bug Log - changes from CI_DRM_9666 -> Patchwork_19447 Summary 
> > FAILURE Serious unknown changes coming with Patchwork_19447
> absolutely
> > need to be verified manually.
> > If you think the reported changes have nothing to do with the 
> > changes introduced in Patchwork_19447, please notify your bug team 
> > to allow them to document this new failure mode, which will reduce 
> > false positives
> in CI.
> > External URL: https://intel-gfx-ci.01.org/tree/drm-
> > tip/Patchwork_19447/index.html
> > Possible new issues
> > Here are the unknown changes that may have been introduced in
> > Patchwork_19447:
> > IGT changes
> > Possible regressions
> > • igt@i915_selftest@live@gt_lrc:
> > o fi-bsw-n3050:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> > bsw-n3050/igt@i915_selftest@live@gt_lrc.html -> https://intel-gfx-
> > ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-
> > n3050/igt@i915_selftest@live@gt_lrc.html
> > Known issues
> > Here are the changes found in Patchwork_19447 that come from known
> > issues:
> > IGT changes
> > Issues hit
> > • igt@gem_mmap_gtt@basic:
> > o fi-tgl-y:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-
> > y/igt@[e-mail] -> https://intel-gfx-
> ci.01.org/tree/drm-
> > tip/Patchwork_19447/fi-tgl-y/igt@[e-mail]
> > (https://gitlab.freedesktop.org/drm/intel/issues/402) +2 similar 
> > issues •
> > igt@i915_selftest@live@hugepages:
> > o fi-bsw-n3050:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> > bsw-n3050/igt@i915_selftest@[e-mail] -> 
> > https://intel-gfx-
> > ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-
> > n3050/igt@i915_selftest@[e-mail]
> > (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +20 similar 
> > issues • igt@i915_selftest@live@ring_submission:
> > o fi-bsw-n3050: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-
> > tip/Patchwork_19447/fi-bsw-
> > n3050/igt@i915_selftest@live@ring_submission.html
> > (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +2 similar 
> > issues • igt@kms_chamelium@dp-crc-fast:
> > o fi-kbl-7500u:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> > kbl-7500u/igt@[e-mail] -> https://intel-gfx-
> > ci.01.org/tree/drm-tip/Patchwork_19447/fi-kbl-
> > 7500u/igt@[e-mail]
> > (https://gitlab.freedesktop.org/drm/intel/issues/1161 /
> > https://gitlab.freedesktop.org/drm/intel/issues/262)
> > Possible fixes
> > • igt@gem_tiled_blits@basic:
> > o fi-tgl-y:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-
> > y/igt@[e-mail]
> > (https://gitlab.freedesktop.org/drm/intel/issues/402) ->
> > https://intel-gfx-
> > ci.01.org/tree/drm-tip/Patchwork_19447/fi-tgl-
> > y/igt@[e-mail] +1 similar issue Warnings •
> > igt@i915_selftest@live@execlists:
> > o fi-bsw-n3050:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-
> > bsw-n3050/igt@i915_selftest@[e-mail]
> > (https://gitlab.freedesktop.org/drm/intel/issues/2940) ->
> > https://intel-gfx-
> > ci.01.org/tree/drm-tip/Patchwork_19447/fi-bsw-
> > n3050/igt@i915_selftest@[e-mail]
> > (https://bugs.freedesktop.org/show_bug.cgi?id=109271)
> > Participating hosts (41 -> 37)
> > Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u Build 
> > changes • Linux: CI_DRM_9666 -> Patchwork_19447
> > CI-20190529: 20190529
> > CI_DRM_9666: 9ccbc653bf2948d1f7e9ff300dd7679b888ffa25 @ 
> > git://anongit.freedesktop.org/gfx-ci/linux
> > IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @ 
> > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > Patchwork_19447: 69d7db003fa406df7851ab08239dd409a78f4421 @ 
> > git://anongit.freedesktop.org/gfx-ci/linux
> > == Linux commits ==
> > 69d7db003fa4 drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over 
> > MST

Petri Latvala Jan. 28, 2021, 7:09 a.m. UTC | #15

On Wed, Jan 27, 2021 at 09:13:36PM +0200, Vudum, Lakshminarayana wrote:
> I am not totally sure why shard run is not triggered here https://patchwork.freedesktop.org/series/85555/#rev2
> @Latvala, Petri any help here?

The results were there but reporting it failed. Re-reported it and
it's now on patchwork.

Gupta, Anshuman Jan. 28, 2021, 7:22 a.m. UTC | #16

Pushed to drm-intel-next.

From: Intel-gfx <[e-mail]> On Behalf Of Patchwork
Sent: Thursday, January 28, 2021 12:36 PM
To: Sean Paul <[e-mail]>
Cc: [e-mail]
Subject: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)

Patch Details
Series:

drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST (rev2)

URL:

https://patchwork.freedesktop.org/series/85555/

State:

success

Details:

https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/index.html

CI Bug Log - changes from CI_DRM_9666_full -> Patchwork_19447_full
Summary

SUCCESS

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19447/index.html

Changes

No changes found

Participating hosts (10 -> 8)

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes

  *   CI: CI-20190529 -> None
  *   Linux: CI_DRM_9666 -> Patchwork_19447
  *   Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_9666: 9ccbc653bf2948d1f7e9ff300dd7679b888ffa25 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19447: 69d7db003fa406df7851ab08239dd409a78f4421 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
index 03424d20e9f7..b6a9606bf09a 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
@@ -640,30 +640,6 @@  intel_dp_mst_hdcp_toggle_signalling(struct intel_digital_port *dig_port,
 	return ret;
 }
 
-static
-bool intel_dp_mst_hdcp_check_link(struct intel_digital_port *dig_port,
-				  struct intel_connector *connector)
-{
-	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
-	struct intel_dp *intel_dp = &dig_port->dp;
-	struct drm_dp_query_stream_enc_status_ack_reply reply;
-	int ret;
-
-	if (!intel_dp_hdcp_check_link(dig_port, connector))
-		return false;
-
-	ret = drm_dp_send_query_stream_enc_status(&intel_dp->mst_mgr,
-						  connector->port, &reply);
-	if (ret) {
-		drm_dbg_kms(&i915->drm,
-			    "[CONNECTOR:%d:%s] failed QSES ret=%d\n",
-			    connector->base.base.id, connector->base.name, ret);
-		return false;
-	}
-
-	return reply.auth_completed && reply.encryption_enabled;
-}
-
 static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
 	.write_an_aksv = intel_dp_hdcp_write_an_aksv,
 	.read_bksv = intel_dp_hdcp_read_bksv,
@@ -674,7 +650,7 @@  static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
 	.read_ksv_fifo = intel_dp_hdcp_read_ksv_fifo,
 	.read_v_prime_part = intel_dp_hdcp_read_v_prime_part,
 	.toggle_signalling = intel_dp_mst_hdcp_toggle_signalling,
-	.check_link = intel_dp_mst_hdcp_check_link,
+	.check_link = intel_dp_hdcp_check_link,
 	.hdcp_capable = intel_dp_hdcp_capable,
 
 	.protocol = HDCP_PROTOCOL_DP,