| Message ID | 1610564400-29788-1-git-send-email-khsieh@codeaurora.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | fix missing unplug interrupt problem | expand |
Quoting Kuogee Hsieh (2021-01-13 10:59:58) > Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts. > Therefore irq_hpd handler should not issues either aux or sw reset > to avoid following unplug interrupt be cleared accidentally. > > Kuogee Hsieh (2): > drm/msm/dp: return fail when both link lane and rate are 0 at dpcd > read > drm/msm/dp: unplug interrupt missed after irq_hpd handler It won't apply to the drm msm tree. Please rebase and resend.
On 2021-01-13 12:25, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-01-13 10:59:58) >> Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts. >> Therefore irq_hpd handler should not issues either aux or sw reset >> to avoid following unplug interrupt be cleared accidentally. >> >> Kuogee Hsieh (2): >> drm/msm/dp: return fail when both link lane and rate are 0 at dpcd >> read >> drm/msm/dp: unplug interrupt missed after irq_hpd handler > > It won't apply to the drm msm tree. Please rebase and resend. Both V1 two patches are picked by Rob already. I will drop V2 patches.
Quoting khsieh@codeaurora.org (2021-01-13 15:52:37) > On 2021-01-13 12:25, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-01-13 10:59:58) > >> Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts. > >> Therefore irq_hpd handler should not issues either aux or sw reset > >> to avoid following unplug interrupt be cleared accidentally. > >> > >> Kuogee Hsieh (2): > >> drm/msm/dp: return fail when both link lane and rate are 0 at dpcd > >> read > >> drm/msm/dp: unplug interrupt missed after irq_hpd handler > > > > It won't apply to the drm msm tree. Please rebase and resend. > Both V1 two patches are picked by Rob already. > I will drop V2 patches. I only see the first patch, not the second one. Rob?
Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts. Therefore irq_hpd handler should not issues either aux or sw reset to avoid following unplug interrupt be cleared accidentally. Kuogee Hsieh (2): drm/msm/dp: return fail when both link lane and rate are 0 at dpcd read drm/msm/dp: unplug interrupt missed after irq_hpd handler drivers/gpu/drm/msm/dp/dp_aux.c | 7 ------- drivers/gpu/drm/msm/dp/dp_catalog.c | 24 ++++++++++++++++++++++++ drivers/gpu/drm/msm/dp/dp_ctrl.c | 15 ++++++++++----- drivers/gpu/drm/msm/dp/dp_display.c | 7 +++++++ drivers/gpu/drm/msm/dp/dp_panel.c | 12 +++++++++--- 5 files changed, 50 insertions(+), 15 deletions(-)