| Message ID | 6b58bc1e-7ab8-0d5b-be9e-a8c29df2c252@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: logitech-hidpp: Add product ID for MX Ergo in Bluetooth mode | expand |
Hi, On 1/11/21 7:09 AM, Nicholas Miell wrote: > The Logitech MX Ergo trackball supports HID++ 4.5 over Bluetooth. Add its > product ID to the table so we can get battery monitoring support. > (The hid-logitech-hidpp driver already recognizes it when connected via > a Unifying Receiver.) > > Signed-off-by: Nicholas Miell <nmiell@gmail.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/hid/hid-logitech-hidpp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > index f85781464807d..7eb9a6ddb46a6 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -4053,6 +4053,8 @@ static const struct hid_device_id hidpp_devices[] = { > { /* MX Master mouse over Bluetooth */ > HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb012), > .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 }, > + { /* MX Ergo trackball over Bluetooth */ > + HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb01d) }, > { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb01e), > .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 }, > { /* MX Master 3 mouse over Bluetooth */ >
On Sun, 10 Jan 2021, Nicholas Miell wrote: > The Logitech MX Ergo trackball supports HID++ 4.5 over Bluetooth. Add its > product ID to the table so we can get battery monitoring support. > (The hid-logitech-hidpp driver already recognizes it when connected via > a Unifying Receiver.) > > Signed-off-by: Nicholas Miell <nmiell@gmail.com> Thanks for the patch. It was whitespace damaged by your mail client though. I've fixed it manually and applied, but please look into fixing this for any future patch submissions.
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index f85781464807d..7eb9a6ddb46a6 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -4053,6 +4053,8 @@ static const struct hid_device_id hidpp_devices[] = { { /* MX Master mouse over Bluetooth */ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb012), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 }, + { /* MX Ergo trackball over Bluetooth */ + HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb01d) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb01e), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 }, { /* MX Master 3 mouse over Bluetooth */
The Logitech MX Ergo trackball supports HID++ 4.5 over Bluetooth. Add its product ID to the table so we can get battery monitoring support. (The hid-logitech-hidpp driver already recognizes it when connected via a Unifying Receiver.) Signed-off-by: Nicholas Miell <nmiell@gmail.com> --- drivers/hid/hid-logitech-hidpp.c | 2 ++ 1 file changed, 2 insertions(+)