| Message ID | 20210114153803.2591-3-jgross@suse.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tools/xenstore: support live update for xenstored | expand |
On 14/01/2021 15:37, Juergen Gross wrote: > Rename the xenevtchn_open() parameter open_flags to flags as it might > be used for things not passed on to open(). > > No functional change. > > Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> Possibly worth stating "No API/ABI changes" seeing as this is a public header?
On 14.01.21 20:22, Andrew Cooper wrote: > On 14/01/2021 15:37, Juergen Gross wrote: >> Rename the xenevtchn_open() parameter open_flags to flags as it might >> be used for things not passed on to open(). >> >> No functional change. >> >> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com> >> Signed-off-by: Juergen Gross <jgross@suse.com> > > Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> > > Possibly worth stating "No API/ABI changes" seeing as this is a public > header? > Yes.
diff --git a/tools/include/xenevtchn.h b/tools/include/xenevtchn.h index 91821ee56d..3e9b6e7323 100644 --- a/tools/include/xenevtchn.h +++ b/tools/include/xenevtchn.h @@ -67,7 +67,7 @@ struct xentoollog_logger; */ /* Currently no flags are defined */ xenevtchn_handle *xenevtchn_open(struct xentoollog_logger *logger, - unsigned open_flags); + unsigned int flags); /* * Close a handle previously allocated with xenevtchn_open(). diff --git a/tools/libs/evtchn/core.c b/tools/libs/evtchn/core.c index 5008810f4f..50bae8ec0d 100644 --- a/tools/libs/evtchn/core.c +++ b/tools/libs/evtchn/core.c @@ -29,7 +29,7 @@ static int all_restrict_cb(Xentoolcore__Active_Handle *ah, domid_t domid) return xenevtchn_restrict(xce, domid); } -xenevtchn_handle *xenevtchn_open(xentoollog_logger *logger, unsigned open_flags) +xenevtchn_handle *xenevtchn_open(xentoollog_logger *logger, unsigned int flags) { xenevtchn_handle *xce = malloc(sizeof(*xce)); int rc;
Rename the xenevtchn_open() parameter open_flags to flags as it might be used for things not passed on to open(). No functional change. Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Juergen Gross <jgross@suse.com> --- V11: - new patch (Andrew Cooper) --- tools/include/xenevtchn.h | 2 +- tools/libs/evtchn/core.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)