| Message ID | 1593197633-9014-1-git-send-email-pillair@codeaurora.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ath10k: Fixes during subsystem recovery | expand |
> -----Original Message----- > From: Rakesh Pillai <pillair@codeaurora.org> > Sent: Saturday, June 27, 2020 12:24 AM > To: ath10k@lists.infradead.org > Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; Rakesh > Pillai <pillair@codeaurora.org> > Subject: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery > > This patch series includes some fixes when the device > is in recovery mode, i.e. when the firmware goes down. > > - Pausing TX queues when FW goes down > - Removed unwanted/extra error logging in pkt TX path > - Skipping wait for FW response for delete cmds > - Handling the -ESHUTDOWN error code in case of SSR. > > Rakesh Pillai (2): > ath10k: Pause the tx queues when firmware is down > ath10k: Skip wait for delete response if firmware is down > > drivers/net/wireless/ath/ath10k/core.h | 1 + > drivers/net/wireless/ath/ath10k/mac.c | 36 ++++++++++++++++++++++--- > --------- > drivers/net/wireless/ath/ath10k/snoc.c | 3 +++ > 3 files changed, 28 insertions(+), 12 deletions(-) Hi Kalle, I see that this patch series is in Deferred state. Is there something missing or blocking this ? > > -- > 2.7.4
"Rakesh Pillai" <pillair@codeaurora.org> writes: >> -----Original Message----- >> From: Rakesh Pillai <pillair@codeaurora.org> >> Sent: Saturday, June 27, 2020 12:24 AM >> To: ath10k@lists.infradead.org >> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; Rakesh >> Pillai <pillair@codeaurora.org> >> Subject: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery >> >> This patch series includes some fixes when the device >> is in recovery mode, i.e. when the firmware goes down. >> >> - Pausing TX queues when FW goes down >> - Removed unwanted/extra error logging in pkt TX path >> - Skipping wait for FW response for delete cmds >> - Handling the -ESHUTDOWN error code in case of SSR. >> >> Rakesh Pillai (2): >> ath10k: Pause the tx queues when firmware is down >> ath10k: Skip wait for delete response if firmware is down >> >> drivers/net/wireless/ath/ath10k/core.h | 1 + >> drivers/net/wireless/ath/ath10k/mac.c | 36 ++++++++++++++++++++++--- >> --------- >> drivers/net/wireless/ath/ath10k/snoc.c | 3 +++ >> 3 files changed, 28 insertions(+), 12 deletions(-) > > Hi Kalle, > I see that this patch series is in Deferred state. Is there something > missing or blocking this ? Yeah, time to review it ;) I still have quite a lot of patches in deferred state but I'm trying to go through it, albeit slowly.
Rakesh Pillai <pillair@codeaurora.org> writes: > This patch series includes some fixes when the device > is in recovery mode, i.e. when the firmware goes down. > > - Pausing TX queues when FW goes down > - Removed unwanted/extra error logging in pkt TX path > - Skipping wait for FW response for delete cmds > - Handling the -ESHUTDOWN error code in case of SSR. > > Rakesh Pillai (2): > ath10k: Pause the tx queues when firmware is down > ath10k: Skip wait for delete response if firmware is down This has been tested only on WCN3990. How do I know that this doesn't break other hardware families?
> -----Original Message----- > From: Kalle Valo <kvalo@codeaurora.org> > Sent: Tuesday, December 22, 2020 12:07 AM > To: Rakesh Pillai <pillair@codeaurora.org> > Cc: ath10k@lists.infradead.org; linux-wireless@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery > > Rakesh Pillai <pillair@codeaurora.org> writes: > > > This patch series includes some fixes when the device > > is in recovery mode, i.e. when the firmware goes down. > > > > - Pausing TX queues when FW goes down > > - Removed unwanted/extra error logging in pkt TX path > > - Skipping wait for FW response for delete cmds > > - Handling the -ESHUTDOWN error code in case of SSR. > > > > Rakesh Pillai (2): > > ath10k: Pause the tx queues when firmware is down > > ath10k: Skip wait for delete response if firmware is down > > This has been tested only on WCN3990. How do I know that this doesn't > break other hardware families? " ath10k: Pause the tx queues when firmware is down" This is done only for SNOC (wcn3990) target and does not affect other targets. " ath10k: Skip wait for delete response if firmware is down" The skip for wmi responses is done based on the flag "ATH10K_FLAG_CRASH_FLUSH", which is generic for all targets. Since if the FW is down, there wont be any response from the FW for any target. > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingp > atches
> -----Original Message----- > From: Rakesh Pillai <pillair@codeaurora.org> > Sent: Friday, January 15, 2021 6:56 PM > To: 'Kalle Valo' <kvalo@codeaurora.org> > Cc: 'ath10k@lists.infradead.org' <ath10k@lists.infradead.org>; 'linux- > wireless@vger.kernel.org' <linux-wireless@vger.kernel.org>; 'linux- > kernel@vger.kernel.org' <linux-kernel@vger.kernel.org> > Subject: RE: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery > > > > -----Original Message----- > > From: Kalle Valo <kvalo@codeaurora.org> > > Sent: Tuesday, December 22, 2020 12:07 AM > > To: Rakesh Pillai <pillair@codeaurora.org> > > Cc: ath10k@lists.infradead.org; linux-wireless@vger.kernel.org; linux- > > kernel@vger.kernel.org > > Subject: Re: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery > > > > Rakesh Pillai <pillair@codeaurora.org> writes: > > > > > This patch series includes some fixes when the device > > > is in recovery mode, i.e. when the firmware goes down. > > > > > > - Pausing TX queues when FW goes down > > > - Removed unwanted/extra error logging in pkt TX path > > > - Skipping wait for FW response for delete cmds > > > - Handling the -ESHUTDOWN error code in case of SSR. > > > > > > Rakesh Pillai (2): > > > ath10k: Pause the tx queues when firmware is down > > > ath10k: Skip wait for delete response if firmware is down > > > > This has been tested only on WCN3990. How do I know that this doesn't > > break other hardware families? > > " ath10k: Pause the tx queues when firmware is down" > This is done only for SNOC (wcn3990) target and does not affect other > targets. > > " ath10k: Skip wait for delete response if firmware is down" > The skip for wmi responses is done based on the flag > "ATH10K_FLAG_CRASH_FLUSH", which is generic for all targets. > Since if the FW is down, there wont be any response from the FW for any > target. > Hi Kalle, I see that these patches are in "deferred" state. Is there any info/change needed in this patch ? Thanks, Rakesh Pillai.