| Message ID | 20210116090656.11752-12-chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [next,01/15] dt-bindings: usb: fix yamllint check warning | expand |
On 16.01.2021 12:06, Chunfeng Yun wrote: > Harmonize node names, compatibles and properties. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 5b782a4769e7..a69a033a68ac 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi [...] > @@ -908,11 +908,11 @@ > status = "disabled"; > }; > > - mipi_tx0: mipi-dphy@11e50000 { > + mipi_tx0: dsi-phy@11e50000 { Again, why not just "phy@..."? [...] > @@ -931,11 +931,10 @@ > }; > }; > > - u3phy: usb-phy@11f40000 { > + u3phy: t-phy@11f40000 { Here as well... [...] MBR, Sergei
On Sat, Jan 16, 2021 at 5:07 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > > Harmonize node names, compatibles and properties. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 5b782a4769e7..a69a033a68ac 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -865,7 +865,7 @@ > ranges; > status = "disabled"; > > - usb_host: xhci@11200000 { > + usb_host: usb@11200000 { > compatible = "mediatek,mt8183-xhci", > "mediatek,mtk-xhci"; > reg = <0 0x11200000 0 0x1000>; > @@ -908,11 +908,11 @@ > status = "disabled"; > }; > > - mipi_tx0: mipi-dphy@11e50000 { > + mipi_tx0: dsi-phy@11e50000 { > compatible = "mediatek,mt8183-mipi-tx"; > reg = <0 0x11e50000 0 0x1000>; > clocks = <&apmixedsys CLK_APMIXED_MIPID0_26M>; > - clock-names = "ref_clk"; > + clock-names = "ref"; > #clock-cells = <0>; > #phy-cells = <0>; > clock-output-names = "mipi_tx0_pll"; This is unrelated to USB, so this should probably be a separate patch. > @@ -931,11 +931,10 @@ > }; > }; > > - u3phy: usb-phy@11f40000 { > + u3phy: t-phy@11f40000 { > compatible = "mediatek,mt8183-tphy", > "mediatek,generic-tphy-v2"; > #address-cells = <1>; > - #phy-cells = <1>; > #size-cells = <1>; > ranges = <0 0 0x11f40000 0x1000>; > status = "okay"; > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
On Sun, Jan 17, 2021 at 9:58 AM Nicolas Boichat <drinkcat@chromium.org> wrote: > > On Sat, Jan 16, 2021 at 5:07 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > > > > Harmonize node names, compatibles and properties. > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > index 5b782a4769e7..a69a033a68ac 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > @@ -865,7 +865,7 @@ > > ranges; > > status = "disabled"; > > > > - usb_host: xhci@11200000 { > > + usb_host: usb@11200000 { > > compatible = "mediatek,mt8183-xhci", > > "mediatek,mtk-xhci"; > > reg = <0 0x11200000 0 0x1000>; > > @@ -908,11 +908,11 @@ > > status = "disabled"; > > }; > > > > - mipi_tx0: mipi-dphy@11e50000 { > > + mipi_tx0: dsi-phy@11e50000 { > > compatible = "mediatek,mt8183-mipi-tx"; > > reg = <0 0x11e50000 0 0x1000>; > > clocks = <&apmixedsys CLK_APMIXED_MIPID0_26M>; > > - clock-names = "ref_clk"; > > + clock-names = "ref"; > > #clock-cells = <0>; > > #phy-cells = <0>; > > clock-output-names = "mipi_tx0_pll"; > > This is unrelated to USB, so this should probably be a separate patch. Actually, after looking again at the complete stack of patches, I think this might be ok as part of this overall cleanup (I'll let the maintainer speak up). > > > @@ -931,11 +931,10 @@ > > }; > > }; > > > > - u3phy: usb-phy@11f40000 { > > + u3phy: t-phy@11f40000 { > > compatible = "mediatek,mt8183-tphy", > > "mediatek,generic-tphy-v2"; > > #address-cells = <1>; > > - #phy-cells = <1>; > > #size-cells = <1>; > > ranges = <0 0 0x11f40000 0x1000>; > > status = "okay"; > > -- > > 2.18.0 > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-mediatek
On Sat, 2021-01-16 at 12:43 +0300, Sergei Shtylyov wrote: > On 16.01.2021 12:06, Chunfeng Yun wrote: > > > Harmonize node names, compatibles and properties. > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > index 5b782a4769e7..a69a033a68ac 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > [...] > > @@ -908,11 +908,11 @@ > > status = "disabled"; > > }; > > > > - mipi_tx0: mipi-dphy@11e50000 { > > + mipi_tx0: dsi-phy@11e50000 { > > Again, why not just "phy@..."? This following the style as usb-phy, pcie-phy etc. but is not yet a standard prefix for Display serial interface PHY > > [...] > > @@ -931,11 +931,10 @@ > > }; > > }; > > > > - u3phy: usb-phy@11f40000 { > > + u3phy: t-phy@11f40000 { > > Here as well... Already explain it in [11/15] > > [...] > > MBR, Sergei
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 5b782a4769e7..a69a033a68ac 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi @@ -865,7 +865,7 @@ ranges; status = "disabled"; - usb_host: xhci@11200000 { + usb_host: usb@11200000 { compatible = "mediatek,mt8183-xhci", "mediatek,mtk-xhci"; reg = <0 0x11200000 0 0x1000>; @@ -908,11 +908,11 @@ status = "disabled"; }; - mipi_tx0: mipi-dphy@11e50000 { + mipi_tx0: dsi-phy@11e50000 { compatible = "mediatek,mt8183-mipi-tx"; reg = <0 0x11e50000 0 0x1000>; clocks = <&apmixedsys CLK_APMIXED_MIPID0_26M>; - clock-names = "ref_clk"; + clock-names = "ref"; #clock-cells = <0>; #phy-cells = <0>; clock-output-names = "mipi_tx0_pll"; @@ -931,11 +931,10 @@ }; }; - u3phy: usb-phy@11f40000 { + u3phy: t-phy@11f40000 { compatible = "mediatek,mt8183-tphy", "mediatek,generic-tphy-v2"; #address-cells = <1>; - #phy-cells = <1>; #size-cells = <1>; ranges = <0 0 0x11f40000 0x1000>; status = "okay";
Harmonize node names, compatibles and properties. Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)