diff mbox series

[v2] edac: remove redundant error print in xgene_edac_probe

Message ID 20210112103540.7818-1-dong.menglong@zte.com.cn (mailing list archive)
State New, archived
Headers show
Series [v2] edac: remove redundant error print in xgene_edac_probe | expand

Commit Message

Menglong Dong Jan. 12, 2021, 10:35 a.m. UTC 
From: Menglong Dong <dong.menglong@zte.com.cn>

Coccinelle reports a redundant error print in xgene_edac_probe.
As 'platform_get_irq' already prints the error message, error
print here is redundant.

Fix it by using 'platform_get_irq_optional' in place of
'platform_get_irq', as Robert suggested.

Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
---
v2:
- use 'platform_get_irq_optional' instead of 'platform_get_irq'
---
 drivers/edac/xgene_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Robert Richter Jan. 12, 2021, 11:40 a.m. UTC | #1 
On 12.01.21 02:35:40, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <dong.menglong@zte.com.cn>
> 
> Coccinelle reports a redundant error print in xgene_edac_probe.
> As 'platform_get_irq' already prints the error message, error
> print here is redundant.
> 
> Fix it by using 'platform_get_irq_optional' in place of
> 'platform_get_irq', as Robert suggested.
> 
> Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
> ---
> v2:
> - use 'platform_get_irq_optional' instead of 'platform_get_irq'
> ---

Reviewed-by: Robert Richter <rric@kernel.org>
Borislav Petkov Jan. 19, 2021, 9:32 a.m. UTC | #2 
On Tue, Jan 12, 2021 at 02:35:40AM -0800, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <dong.menglong@zte.com.cn>
> 
> Coccinelle reports a redundant error print in xgene_edac_probe.
> As 'platform_get_irq' already prints the error message, error
> print here is redundant.
> 
> Fix it by using 'platform_get_irq_optional' in place of
> 'platform_get_irq', as Robert suggested.
> 
> Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
> ---
> v2:
> - use 'platform_get_irq_optional' instead of 'platform_get_irq'
> ---
>  drivers/edac/xgene_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
> index 1d2c27a00a4a..2ccd1db5e98f 100644
> --- a/drivers/edac/xgene_edac.c
> +++ b/drivers/edac/xgene_edac.c
> @@ -1916,7 +1916,7 @@ static int xgene_edac_probe(struct platform_device *pdev)
>  		int i;
>  
>  		for (i = 0; i < 3; i++) {
> -			irq = platform_get_irq(pdev, i);
> +			irq = platform_get_irq_optional(pdev, i);
>  			if (irq < 0) {
>  				dev_err(&pdev->dev, "No IRQ resource\n");
>  				rc = -EINVAL;
> -- 

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
index 1d2c27a00a4a..2ccd1db5e98f 100644
--- a/drivers/edac/xgene_edac.c
+++ b/drivers/edac/xgene_edac.c
@@ -1916,7 +1916,7 @@  static int xgene_edac_probe(struct platform_device *pdev)
 		int i;
 
 		for (i = 0; i < 3; i++) {
-			irq = platform_get_irq(pdev, i);
+			irq = platform_get_irq_optional(pdev, i);
 			if (irq < 0) {
 				dev_err(&pdev->dev, "No IRQ resource\n");
 				rc = -EINVAL;