| Message ID | 20210118205522.317087-1-bongsu.jeon@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4964e5a1e080f785f5518b402a9e48c527fe6cbd |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: nfc: nci: fix the wrong NCI_CORE_INIT parameters | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | fail | Series targets non-next tree, but doesn't contain any Fixes tags |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: andrew@lunn.ch wanghai38@huawei.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Tue, 19 Jan 2021 05:55:22 +0900 Bongsu Jeon wrote: > From: Bongsu Jeon <bongsu.jeon@samsung.com> > > Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0 > but there is no parameters in NCI1.x. > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> What's the Fixes tag for this change?
On Tue, Jan 19, 2021 at 6:01 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Tue, 19 Jan 2021 05:55:22 +0900 Bongsu Jeon wrote: > > From: Bongsu Jeon <bongsu.jeon@samsung.com> > > > > Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0 > > but there is no parameters in NCI1.x. > > > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > > What's the Fixes tag for this change? Sorry to miss the Fixes tag. This is the Fixes tag ( Fixes: bcd684aace34 ("net/nfc/nci: Support NCI 2.x initial sequence") ) Could I resend this patch after adding that tag?
On Tue, 19 Jan 2021 06:19:23 +0900 Bongsu Jeon wrote: > On Tue, Jan 19, 2021 at 6:01 AM Jakub Kicinski <kuba@kernel.org> wrote: > > > > On Tue, 19 Jan 2021 05:55:22 +0900 Bongsu Jeon wrote: > > > From: Bongsu Jeon <bongsu.jeon@samsung.com> > > > > > > Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0 > > > but there is no parameters in NCI1.x. > > > > > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > > > > What's the Fixes tag for this change? > Sorry to miss the Fixes tag. > This is the Fixes tag ( Fixes: bcd684aace34 ("net/nfc/nci: Support NCI > 2.x initial sequence") ) > Could I resend this patch after adding that tag? It's fine no need to repost, I can add the tag when applying the patch, let's wait for reviews. Let me just place it on a line of its own, patchwork is supposed to pick that up automatically: Fixes: bcd684aace34 ("net/nfc/nci: Support NCI 2.x initial sequence")
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 19 Jan 2021 05:55:22 +0900 you wrote: > From: Bongsu Jeon <bongsu.jeon@samsung.com> > > Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0 > but there is no parameters in NCI1.x. > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > > [...] Here is the summary with links: - [net] net: nfc: nci: fix the wrong NCI_CORE_INIT parameters https://git.kernel.org/netdev/net/c/4964e5a1e080 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
On Wed, Jan 20, 2021 at 10:00 AM <patchwork-bot+netdevbpf@kernel.org> wrote: > > Hello: > > This patch was applied to netdev/net.git (refs/heads/master): > > On Tue, 19 Jan 2021 05:55:22 +0900 you wrote: > > From: Bongsu Jeon <bongsu.jeon@samsung.com> > > > > Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0 > > but there is no parameters in NCI1.x. > > > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > > > > [...] > > Here is the summary with links: > - [net] net: nfc: nci: fix the wrong NCI_CORE_INIT parameters > https://git.kernel.org/netdev/net/c/4964e5a1e080 > > You are awesome, thank you! > -- > Deet-doot-dot, I am a bot. > https://korg.docs.kernel.org/patchwork/pwbot.html > > Could you merge this patch to net-next repo?? NCI selftest that i will send will fail if this patch isn't merged.
On Wed, 20 Jan 2021 18:54:17 +0900 Bongsu Jeon wrote: > On Wed, Jan 20, 2021 at 10:00 AM <patchwork-bot+netdevbpf@kernel.org> wrote: > > This patch was applied to netdev/net.git (refs/heads/master): > > > > On Tue, 19 Jan 2021 05:55:22 +0900 you wrote: > > > From: Bongsu Jeon <bongsu.jeon@samsung.com> > > > > > > Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0 > > > but there is no parameters in NCI1.x. > > > > > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > > Could you merge this patch to net-next repo?? > NCI selftest that i will send will fail if this patch isn't merged. It happens periodically, should happen today or tomorrow.
diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c index e64727e1a72f..02a1f13f0798 100644 --- a/net/nfc/nci/core.c +++ b/net/nfc/nci/core.c @@ -508,7 +508,7 @@ static int nci_open_device(struct nci_dev *ndev) }; unsigned long opt = 0; - if (!(ndev->nci_ver & NCI_VER_2_MASK)) + if (ndev->nci_ver & NCI_VER_2_MASK) opt = (unsigned long)&nci_init_v2_cmd; rc = __nci_request(ndev, nci_init_req, opt,