diff mbox series

[RFC,31/37] eros: use bio_init_fields in data

Message ID 20210119050631.57073-32-chaitanya.kulkarni@wdc.com (mailing list archive)
State Deferred, archived
Headers show
Series block: introduce bio_init_fields() | expand

Commit Message

Chaitanya Kulkarni Jan. 19, 2021, 5:06 a.m. UTC 
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
 fs/erofs/data.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Gao Xiang Jan. 20, 2021, 4:05 a.m. UTC | #1 
Hi Chaitanya,

(drop in-person Cc..)

On Mon, Jan 18, 2021 at 09:06:25PM -0800, Chaitanya Kulkarni wrote:

...it would be nice if you could update the subject line to
"erofs: use bio_init_fields xxxx"

The same to the following patch [RFC PATCH 32/37]... Also, IMHO,
these two patches could be merged as one patch if possible,
although just my own thoughts.

Thanks,
Gao Xiang

> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
>  fs/erofs/data.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
> index ea4f693bee22..15f3a3f01fa3 100644
> --- a/fs/erofs/data.c
> +++ b/fs/erofs/data.c
> @@ -220,10 +220,8 @@ static inline struct bio *erofs_read_raw_page(struct bio *bio,
>  
>  		bio = bio_alloc(GFP_NOIO, nblocks);
>  
> -		bio->bi_end_io = erofs_readendio;
> -		bio_set_dev(bio, sb->s_bdev);
> -		bio->bi_iter.bi_sector = (sector_t)blknr <<
> -			LOG_SECTORS_PER_BLOCK;
> +		bio_init_fields(bio, sb->s_bdev, (sector_t)blknr <<
> +			LOG_SECTORS_PER_BLOCK, NULL, erofs_readendio, 0, 0);
>  		bio->bi_opf = REQ_OP_READ | (ra ? REQ_RAHEAD : 0);
>  	}
>  
> -- 
> 2.22.1
>
Chaitanya Kulkarni Jan. 20, 2021, 4:08 a.m. UTC | #2 
On 1/19/21 20:06, Gao Xiang wrote:
> Hi Chaitanya,
>
> (drop in-person Cc..)
>
> On Mon, Jan 18, 2021 at 09:06:25PM -0800, Chaitanya Kulkarni wrote:
>
> ...it would be nice if you could update the subject line to
> "erofs: use bio_init_fields xxxx"
Sure, if new helper is accepted and can be used in erosfs
then I'll make that change. Thanks for pointing out.
> The same to the following patch [RFC PATCH 32/37]... Also, IMHO,
> these two patches could be merged as one patch if possible,
> although just my own thoughts.
>
> Thanks,
> Gao Xiang
diff mbox series

Patch

diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index ea4f693bee22..15f3a3f01fa3 100644
--- a/fs/erofs/data.c
+++ b/fs/erofs/data.c
@@ -220,10 +220,8 @@  static inline struct bio *erofs_read_raw_page(struct bio *bio,
 
 		bio = bio_alloc(GFP_NOIO, nblocks);
 
-		bio->bi_end_io = erofs_readendio;
-		bio_set_dev(bio, sb->s_bdev);
-		bio->bi_iter.bi_sector = (sector_t)blknr <<
-			LOG_SECTORS_PER_BLOCK;
+		bio_init_fields(bio, sb->s_bdev, (sector_t)blknr <<
+			LOG_SECTORS_PER_BLOCK, NULL, erofs_readendio, 0, 0);
 		bio->bi_opf = REQ_OP_READ | (ra ? REQ_RAHEAD : 0);
 	}