| Message ID | 20210119155029.18943-1-aurabindo.pillai@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Experimental freesync video mode optimization | expand |
On Tue, 19 Jan 2021 10:50:26 -0500 Aurabindo Pillai <aurabindo.pillai@amd.com> wrote: > Changes in V5 > ============= > > * More info in commit messages on the rationale of changes being added > to the kernel. > * Minor fixes Hi, thank you for adding the explanations in the commit messages I asked for. It is now up to DRM maintainers to determine if this is conceptually fine. I do see that apparently setting the opt-in option does not yet taint the kernel although Daniel Vetter suggested it might be a good idea. I guess tainting the kernel would make it easier to remove this feature in the future because it would be easier to dismiss people that claim a kernel regression due to the removal. Thanks, pq > -- > > This patchset enables freesync video mode usecase where the userspace > can request a freesync compatible video mode such that switching to this > mode does not trigger blanking. > > This feature is guarded by a module parameter which is disabled by > default. Enabling this paramters adds additional modes to the driver > modelist, and also enables the optimization to skip modeset when using > one of these modes. > > -- > > Aurabindo Pillai (3): > drm/amd/display: Add module parameter for freesync video mode > drm/amd/display: Add freesync video modes based on preferred modes > drm/amd/display: Skip modeset for front porch change > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 + > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 401 ++++++++++++++++-- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 + > 4 files changed, 382 insertions(+), 35 deletions(-) >
On Fri, Jan 22, 2021 at 10:32:48AM +0200, Pekka Paalanen wrote: > On Tue, 19 Jan 2021 10:50:26 -0500 > Aurabindo Pillai <aurabindo.pillai@amd.com> wrote: > > > Changes in V5 > > ============= > > > > * More info in commit messages on the rationale of changes being added > > to the kernel. > > * Minor fixes > > Hi, > > thank you for adding the explanations in the commit messages I asked > for. It is now up to DRM maintainers to determine if this is > conceptually fine. > > I do see that apparently setting the opt-in option does not yet taint > the kernel although Daniel Vetter suggested it might be a good idea. I > guess tainting the kernel would make it easier to remove this feature > in the future because it would be easier to dismiss people that claim a > kernel regression due to the removal. Reading the descriptions I'm honestly not sure why this isn't enabled by default? Maybe the explanations should also capture why this is maybe not a good idea ... -Daniel > > > Thanks, > pq > > > > -- > > > > This patchset enables freesync video mode usecase where the userspace > > can request a freesync compatible video mode such that switching to this > > mode does not trigger blanking. > > > > This feature is guarded by a module parameter which is disabled by > > default. Enabling this paramters adds additional modes to the driver > > modelist, and also enables the optimization to skip modeset when using > > one of these modes. > > > > -- > > > > Aurabindo Pillai (3): > > drm/amd/display: Add module parameter for freesync video mode > > drm/amd/display: Add freesync video modes based on preferred modes > > drm/amd/display: Skip modeset for front porch change > > > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 + > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 401 ++++++++++++++++-- > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 + > > 4 files changed, 382 insertions(+), 35 deletions(-) > > >
On Fri, Jan 22, 2021 at 10:42:53AM +0100, Daniel Vetter wrote: > On Fri, Jan 22, 2021 at 10:32:48AM +0200, Pekka Paalanen wrote: > > On Tue, 19 Jan 2021 10:50:26 -0500 > > Aurabindo Pillai <aurabindo.pillai@amd.com> wrote: > > > > > Changes in V5 > > > ============= > > > > > > * More info in commit messages on the rationale of changes being added > > > to the kernel. > > > * Minor fixes > > > > Hi, > > > > thank you for adding the explanations in the commit messages I asked > > for. It is now up to DRM maintainers to determine if this is > > conceptually fine. > > > > I do see that apparently setting the opt-in option does not yet taint > > the kernel although Daniel Vetter suggested it might be a good idea. I > > guess tainting the kernel would make it easier to remove this feature > > in the future because it would be easier to dismiss people that claim a > > kernel regression due to the removal. > > Reading the descriptions I'm honestly not sure why this isn't enabled by > default? > > Maybe the explanations should also capture why this is maybe not a good > idea ... And also, if this is a bad idea uapi-vise, then it definitely needs to be behind the tainting module option until we've sorted it out (and then just enable it by default once that's done). -Daniel > -Daniel > > > > > > > Thanks, > > pq > > > > > > > -- > > > > > > This patchset enables freesync video mode usecase where the userspace > > > can request a freesync compatible video mode such that switching to this > > > mode does not trigger blanking. > > > > > > This feature is guarded by a module parameter which is disabled by > > > default. Enabling this paramters adds additional modes to the driver > > > modelist, and also enables the optimization to skip modeset when using > > > one of these modes. > > > > > > -- > > > > > > Aurabindo Pillai (3): > > > drm/amd/display: Add module parameter for freesync video mode > > > drm/amd/display: Add freesync video modes based on preferred modes > > > drm/amd/display: Skip modeset for front porch change > > > > > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + > > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 + > > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 401 ++++++++++++++++-- > > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 + > > > 4 files changed, 382 insertions(+), 35 deletions(-) > > > > > > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
On Fri, Jan 22, 2021 at 4:43 AM Daniel Vetter <daniel@ffwll.ch> wrote: > > On Fri, Jan 22, 2021 at 10:32:48AM +0200, Pekka Paalanen wrote: > > On Tue, 19 Jan 2021 10:50:26 -0500 > > Aurabindo Pillai <aurabindo.pillai@amd.com> wrote: > > > > > Changes in V5 > > > ============= > > > > > > * More info in commit messages on the rationale of changes being added > > > to the kernel. > > > * Minor fixes > > > > Hi, > > > > thank you for adding the explanations in the commit messages I asked > > for. It is now up to DRM maintainers to determine if this is > > conceptually fine. > > > > I do see that apparently setting the opt-in option does not yet taint > > the kernel although Daniel Vetter suggested it might be a good idea. I > > guess tainting the kernel would make it easier to remove this feature > > in the future because it would be easier to dismiss people that claim a > > kernel regression due to the removal. > > Reading the descriptions I'm honestly not sure why this isn't enabled by > default? > > Maybe the explanations should also capture why this is maybe not a good > idea ... I don't know that it's a bad idea, I guess we are just cautious to avoid unforeseen consequences until we have more real world experience using the feature. One issue brought up as a possible problem, but not actually verified to my knowledge, was the possibility of using a bit more power with freesync modes. E.g., if you just change the front porch to set the refresh to 48 Hz on a 90Hz mode, you are technically running the display phys at the higher clock speed so you can seamlessly transition to 90Hz or whatever. I don't know that it uses that much additional power and lets you get some nice features in a relatively seamless manner that already works today with most media players. I guess for media player folks, is this something you'd like as is? A more explicit API may be nicer, but I think I think the ultimate solution will end up getting tied up in what are plans are for bigger features like more advanced flip queues and stuff like that. So this seems like a nice intermediate step. Alex > -Daniel > > > > > > > Thanks, > > pq > > > > > > > -- > > > > > > This patchset enables freesync video mode usecase where the userspace > > > can request a freesync compatible video mode such that switching to this > > > mode does not trigger blanking. > > > > > > This feature is guarded by a module parameter which is disabled by > > > default. Enabling this paramters adds additional modes to the driver > > > modelist, and also enables the optimization to skip modeset when using > > > one of these modes. > > > > > > -- > > > > > > Aurabindo Pillai (3): > > > drm/amd/display: Add module parameter for freesync video mode > > > drm/amd/display: Add freesync video modes based on preferred modes > > > drm/amd/display: Skip modeset for front porch change > > > > > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + > > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 + > > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 401 ++++++++++++++++-- > > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 + > > > 4 files changed, 382 insertions(+), 35 deletions(-) > > > > > > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, Jan 22, 2021 at 10:16:45AM -0500, Alex Deucher wrote: > On Fri, Jan 22, 2021 at 4:43 AM Daniel Vetter <daniel@ffwll.ch> wrote: > > > > On Fri, Jan 22, 2021 at 10:32:48AM +0200, Pekka Paalanen wrote: > > > On Tue, 19 Jan 2021 10:50:26 -0500 > > > Aurabindo Pillai <aurabindo.pillai@amd.com> wrote: > > > > > > > Changes in V5 > > > > ============= > > > > > > > > * More info in commit messages on the rationale of changes being added > > > > to the kernel. > > > > * Minor fixes > > > > > > Hi, > > > > > > thank you for adding the explanations in the commit messages I asked > > > for. It is now up to DRM maintainers to determine if this is > > > conceptually fine. > > > > > > I do see that apparently setting the opt-in option does not yet taint > > > the kernel although Daniel Vetter suggested it might be a good idea. I > > > guess tainting the kernel would make it easier to remove this feature > > > in the future because it would be easier to dismiss people that claim a > > > kernel regression due to the removal. > > > > Reading the descriptions I'm honestly not sure why this isn't enabled by > > default? > > > > Maybe the explanations should also capture why this is maybe not a good > > idea ... > > I don't know that it's a bad idea, I guess we are just cautious to > avoid unforeseen consequences until we have more real world experience > using the feature. One issue brought up as a possible problem, but > not actually verified to my knowledge, was the possibility of using a > bit more power with freesync modes. E.g., if you just change the > front porch to set the refresh to 48 Hz on a 90Hz mode, you are > technically running the display phys at the higher clock speed so you > can seamlessly transition to 90Hz or whatever. I don't know that it > uses that much additional power and lets you get some nice features in > a relatively seamless manner that already works today with most media > players. Hm yeah that's a good point. You can't change the dotclock to something lower on the fly? We have that on some intel laptops, but it's kinda been superseeded with manual update (PSR on DP) in most places, and then everything is shut down anyway. But either of these happen automatically, and we even have self refresh helpers now if you don't have hw assitance for these to automatically ramp back up to max refresh rate (Intel loves baking stuff into hw a bit too much, so drm/i915 isn't using it). > I guess for media player folks, is this something you'd like as is? A > more explicit API may be nicer, but I think I think the ultimate > solution will end up getting tied up in what are plans are for bigger > features like more advanced flip queues and stuff like that. So this > seems like a nice intermediate step. Yeah I think knobs to figure out details is good, but ime they're just have a tendency to stay around forever and eventually we suffer from combinatorial explosion and also a bit (for this one here) uapi fragmentation. Which isn't nice if the solution to a user problem is "add this obscure kernel cmdline to your grub file". That's why I think the taining module param is a good interim step for figuring stuff out, while reducing a bit the risk it'll become a permanent thing users have to fiddle. Cheers, Daniel > > Alex > > > > -Daniel > > > > > > > > > > > Thanks, > > > pq > > > > > > > > > > -- > > > > > > > > This patchset enables freesync video mode usecase where the userspace > > > > can request a freesync compatible video mode such that switching to this > > > > mode does not trigger blanking. > > > > > > > > This feature is guarded by a module parameter which is disabled by > > > > default. Enabling this paramters adds additional modes to the driver > > > > modelist, and also enables the optimization to skip modeset when using > > > > one of these modes. > > > > > > > > -- > > > > > > > > Aurabindo Pillai (3): > > > > drm/amd/display: Add module parameter for freesync video mode > > > > drm/amd/display: Add freesync video modes based on preferred modes > > > > drm/amd/display: Skip modeset for front porch change > > > > > > > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 + > > > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 401 ++++++++++++++++-- > > > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 + > > > > 4 files changed, 382 insertions(+), 35 deletions(-) > > > > > > > > > > > > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel