| Message ID | 20201120191720.5a2320cf@xhacker.debian (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: dwc: remove useless dw_pcie_ops | expand |
On Fri, 2020-11-20 at 19:17 +0800, Jisheng Zhang wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > We have removed the dw_pcie_ops always exists assumption in dwc > core driver, we can remove the useless dw_pcie_ops now. > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> > --- > drivers/pci/controller/dwc/pcie-al.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-al.c > b/drivers/pci/controller/dwc/pcie-al.c > index 7ac8a37d9ce0..36977c48a7ae 100644 > --- a/drivers/pci/controller/dwc/pcie-al.c > +++ b/drivers/pci/controller/dwc/pcie-al.c > @@ -322,9 +322,6 @@ static const struct dw_pcie_host_ops > al_pcie_host_ops = { > .host_init = al_pcie_host_init, > }; > > -static const struct dw_pcie_ops dw_pcie_ops = { > -}; > - > static int al_pcie_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -342,7 +339,6 @@ static int al_pcie_probe(struct platform_device > *pdev) > return -ENOMEM; > > pci->dev = dev; > - pci->ops = &dw_pcie_ops; > pci->pp.ops = &al_pcie_host_ops; > > al_pcie->pci = pci; > -- > 2.29.2 > Acked-by: Jonathan Chocron <jonnyc@amazon.com> Thanks, Jonathan
diff --git a/drivers/pci/controller/dwc/pcie-al.c b/drivers/pci/controller/dwc/pcie-al.c index 7ac8a37d9ce0..36977c48a7ae 100644 --- a/drivers/pci/controller/dwc/pcie-al.c +++ b/drivers/pci/controller/dwc/pcie-al.c @@ -322,9 +322,6 @@ static const struct dw_pcie_host_ops al_pcie_host_ops = { .host_init = al_pcie_host_init, }; -static const struct dw_pcie_ops dw_pcie_ops = { -}; - static int al_pcie_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -342,7 +339,6 @@ static int al_pcie_probe(struct platform_device *pdev) return -ENOMEM; pci->dev = dev; - pci->ops = &dw_pcie_ops; pci->pp.ops = &al_pcie_host_ops; al_pcie->pci = pci;
We have removed the dw_pcie_ops always exists assumption in dwc core driver, we can remove the useless dw_pcie_ops now. Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> --- drivers/pci/controller/dwc/pcie-al.c | 4 ---- 1 file changed, 4 deletions(-)