diff mbox

Fix wrong initializer for "locked" variable

Message ID 201108251537.45999.thomas.jarosch@intra2net.com (mailing list archive)
State Accepted
Headers show

Commit Message

Thomas Jarosch Aug. 25, 2011, 1:37 p.m. UTC 
Otherwise it just contains random memory.

Issue detected by cppcheck.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Jesse Barnes Aug. 25, 2011, 4:22 p.m. UTC | #1 
On Thu, 25 Aug 2011 15:37:45 +0200
Thomas Jarosch <thomas.jarosch@intra2net.com> wrote:

> Otherwise it just contains random memory.
> 
> Issue detected by cppcheck.
> 
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index ee1d701..f6da4e4 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -878,7 +878,7 @@ static void assert_panel_unlocked(struct drm_i915_private *dev_priv,
>  	int pp_reg, lvds_reg;
>  	u32 val;
>  	enum pipe panel_pipe = PIPE_A;
> -	bool locked = locked;
> +	bool locked = true;
>  
>  	if (HAS_PCH_SPLIT(dev_priv->dev)) {
>  		pp_reg = PCH_PP_CONTROL;

Hah yeah that's a good one, thanks for the fix.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index ee1d701..f6da4e4 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -878,7 +878,7 @@  static void assert_panel_unlocked(struct drm_i915_private *dev_priv,
 	int pp_reg, lvds_reg;
 	u32 val;
 	enum pipe panel_pipe = PIPE_A;
-	bool locked = locked;
+	bool locked = true;
 
 	if (HAS_PCH_SPLIT(dev_priv->dev)) {
 		pp_reg = PCH_PP_CONTROL;