mbox series

[0/3] bfq: Two fixes and a cleanup for sequential readers

Message ID 20200605140837.5394-1-jack@suse.cz (mailing list archive)
Headers show
Series bfq: Two fixes and a cleanup for sequential readers | expand

Message

Jan Kara June 5, 2020, 2:16 p.m. UTC
Hello,

this patch series contains one tiny cleanup and two relatively simple fixes
for BFQ I've uncovered when analyzing behavior of four parallel sequential
readers on one machine. The fio jobfile is like:

[global]
direct=0
ioengine=sync
invalidate=1
size=16g
rw=read
bs=4k

[reader]
numjobs=4
directory=/mnt

The first patch fixes a problem due to which the four bfq queues were getting
merged without a reason. The third patch fixes a problem where we were unfairly
raising bfq queue think time (leading to clearing of short_ttime and subsequent
reduction in throughput).

What do people think about these?

								Honza

Comments

Jan Kara Jan. 27, 2021, 3:27 p.m. UTC | #1
On Wed 13-01-21 11:09:24, Jan Kara wrote:
> Hello,
> 
> this patch series contains one tiny cleanup and two relatively simple fixes
> for BFQ I've uncovered when analyzing behavior of four parallel sequential
> readers on one machine. The fio jobfile is like:
> 
> [global]
> direct=0
> ioengine=sync
> invalidate=1
> size=16g
> rw=read
> bs=4k
> 
> [reader]
> numjobs=4
> directory=/mnt
> 
> The first patch fixes a problem due to which the four bfq queues were getting
> merged without a reason. The third patch fixes a problem where we were unfairly
> raising bfq queue think time (leading to clearing of short_ttime and subsequent
> reduction in throughput).
> 
> Jens, since Paolo has acked all the patches, can you please merge them?

Jens, ping? Can you please pick up these fixes? Thanks!

								Honza
Jens Axboe Jan. 27, 2021, 4:16 p.m. UTC | #2
On 1/27/21 8:27 AM, Jan Kara wrote:
> On Wed 13-01-21 11:09:24, Jan Kara wrote:
>> Hello,
>>
>> this patch series contains one tiny cleanup and two relatively simple fixes
>> for BFQ I've uncovered when analyzing behavior of four parallel sequential
>> readers on one machine. The fio jobfile is like:
>>
>> [global]
>> direct=0
>> ioengine=sync
>> invalidate=1
>> size=16g
>> rw=read
>> bs=4k
>>
>> [reader]
>> numjobs=4
>> directory=/mnt
>>
>> The first patch fixes a problem due to which the four bfq queues were getting
>> merged without a reason. The third patch fixes a problem where we were unfairly
>> raising bfq queue think time (leading to clearing of short_ttime and subsequent
>> reduction in throughput).
>>
>> Jens, since Paolo has acked all the patches, can you please merge them?
> 
> Jens, ping? Can you please pick up these fixes? Thanks!

Yep, I've queued them up, thanks.