| Message ID | 20210107223926.35284-1-song.bao.hua@hisilicon.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add IRQF_NO_AUTOEN for request_irq | expand |
Hi Thomas, Greg, Dmitry, Marc, Any further comment on this new API? Thanks Barry > -----Original Message----- > From: Song Bao Hua (Barry Song) > Sent: Friday, January 8, 2021 11:39 AM > To: dmitry.torokhov@gmail.com; tglx@linutronix.de; maz@kernel.org; > gregkh@linuxfoundation.org; linux-input@vger.kernel.org; > linux-kernel@vger.kernel.org > Cc: linuxarm@openeuler.org; Song Bao Hua (Barry Song) > <song.bao.hua@hisilicon.com> > Subject: [PATCH v3 00/12] add IRQF_NO_AUTOEN for request_irq > > This patchset added IRQF_NO_AUTOEN for request_irq() and converted > drivers/input to this new API. > Other drivers will be handled afterwards. > > -v3: > added examples with respect to Greg's comment > > Barry Song (12): > genirq: add IRQF_NO_AUTOEN for request_irq > Input: ar1021 - request_irq by IRQF_NO_AUTOEN and remove disable_irq > Input: atmel_mxt_ts - request_irq by IRQF_NO_AUTOEN and remove > disable_irq > Input: melfas_mip4 - request_irq by IRQF_NO_AUTOEN and remove > disable_irq > Input: bu21029_ts - request_irq by IRQF_NO_AUTOEN and remove > irq_set_status_flags > Input: stmfts - request_irq by IRQF_NO_AUTOEN and remove > irq_set_status_flags > Input: zinitix - request_irq by IRQF_NO_AUTOEN and remove > irq_set_status_flags > Input: mms114 - request_irq by IRQF_NO_AUTOEN and remove disable_irq > Input: wm831x-ts - request_irq by IRQF_NO_AUTOEN and remove > disable_irq > Input: cyttsp - request_irq by IRQF_NO_AUTOEN and remove disable_irq > Input: tegra-kbc - request_irq by IRQF_NO_AUTOEN and remove > disable_irq > Input: tca6416-keypad - request_irq by IRQF_NO_AUTOEN and remove > disable_irq > > drivers/input/keyboard/tca6416-keypad.c | 3 +-- > drivers/input/keyboard/tegra-kbc.c | 5 ++--- > drivers/input/touchscreen/ar1021_i2c.c | 5 +---- > drivers/input/touchscreen/atmel_mxt_ts.c | 5 ++--- > drivers/input/touchscreen/bu21029_ts.c | 4 ++-- > drivers/input/touchscreen/cyttsp_core.c | 5 ++--- > drivers/input/touchscreen/melfas_mip4.c | 5 ++--- > drivers/input/touchscreen/mms114.c | 4 ++-- > drivers/input/touchscreen/stmfts.c | 3 +-- > drivers/input/touchscreen/wm831x-ts.c | 3 +-- > drivers/input/touchscreen/zinitix.c | 4 ++-- > include/linux/interrupt.h | 3 +++ > kernel/irq/manage.c | 8 ++++++++ > kernel/irq/settings.h | 10 ++++++++++ > 14 files changed, 39 insertions(+), 28 deletions(-) > > -- > 2.25.1
On Thu, Jan 21, 2021 at 09:38:28PM +0000, Song Bao Hua (Barry Song) wrote: > Hi Thomas, Greg, Dmitry, Marc, > Any further comment on this new API? It's not my subsystem, I'll let the irq maintainers handle it :) thanks, greg k-h
On Wed, Jan 27, 2021 at 02:49:21PM +0100, gregkh@linuxfoundation.org wrote: > On Thu, Jan 21, 2021 at 09:38:28PM +0000, Song Bao Hua (Barry Song) wrote: > > Hi Thomas, Greg, Dmitry, Marc, > > Any further comment on this new API? > > It's not my subsystem, I'll let the irq maintainers handle it :) Not my subsystem either, but I would like to have this feature available. I do not like calling irq_set_status_flags() before request_irq() as at that time we are not ensured of irq ownership, and using disable_irq() afterwards is indeed awkward. Thanks.
On Wed, 27 Jan 2021 11:45:45 -0800 "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com> wrote: > On Wed, Jan 27, 2021 at 02:49:21PM +0100, gregkh@linuxfoundation.org wrote: > > On Thu, Jan 21, 2021 at 09:38:28PM +0000, Song Bao Hua (Barry Song) wrote: > > > Hi Thomas, Greg, Dmitry, Marc, > > > Any further comment on this new API? > > > > It's not my subsystem, I'll let the irq maintainers handle it :) > > Not my subsystem either, but I would like to have this feature > available. I do not like calling irq_set_status_flags() before > request_irq() as at that time we are not ensured of irq ownership, and > using disable_irq() afterwards is indeed awkward. > Likewise, keen on having this available. Jonathan > Thanks. >
This patchset added IRQF_NO_AUTOEN for request_irq() and converted drivers/input to this new API. Other drivers will be handled afterwards. -v3: added examples with respect to Greg's comment Barry Song (12): genirq: add IRQF_NO_AUTOEN for request_irq Input: ar1021 - request_irq by IRQF_NO_AUTOEN and remove disable_irq Input: atmel_mxt_ts - request_irq by IRQF_NO_AUTOEN and remove disable_irq Input: melfas_mip4 - request_irq by IRQF_NO_AUTOEN and remove disable_irq Input: bu21029_ts - request_irq by IRQF_NO_AUTOEN and remove irq_set_status_flags Input: stmfts - request_irq by IRQF_NO_AUTOEN and remove irq_set_status_flags Input: zinitix - request_irq by IRQF_NO_AUTOEN and remove irq_set_status_flags Input: mms114 - request_irq by IRQF_NO_AUTOEN and remove disable_irq Input: wm831x-ts - request_irq by IRQF_NO_AUTOEN and remove disable_irq Input: cyttsp - request_irq by IRQF_NO_AUTOEN and remove disable_irq Input: tegra-kbc - request_irq by IRQF_NO_AUTOEN and remove disable_irq Input: tca6416-keypad - request_irq by IRQF_NO_AUTOEN and remove disable_irq drivers/input/keyboard/tca6416-keypad.c | 3 +-- drivers/input/keyboard/tegra-kbc.c | 5 ++--- drivers/input/touchscreen/ar1021_i2c.c | 5 +---- drivers/input/touchscreen/atmel_mxt_ts.c | 5 ++--- drivers/input/touchscreen/bu21029_ts.c | 4 ++-- drivers/input/touchscreen/cyttsp_core.c | 5 ++--- drivers/input/touchscreen/melfas_mip4.c | 5 ++--- drivers/input/touchscreen/mms114.c | 4 ++-- drivers/input/touchscreen/stmfts.c | 3 +-- drivers/input/touchscreen/wm831x-ts.c | 3 +-- drivers/input/touchscreen/zinitix.c | 4 ++-- include/linux/interrupt.h | 3 +++ kernel/irq/manage.c | 8 ++++++++ kernel/irq/settings.h | 10 ++++++++++ 14 files changed, 39 insertions(+), 28 deletions(-)