[v9,00/11] iOS and Apple Silicon host support

Message

Joelle van Dyne Jan. 26, 2021, 1:24 a.m. UTC

These set of changes brings QEMU TCG to iOS devices and future Apple Silicon
devices. They were originally developed last year and have been working in the
UTM app. Recently, we ported the changes to master, re-wrote a lot of the build
script changes for meson, and broke up the patches into more distinct units.

The bulk of the changes allow for cross-compiling for both iOS and macOS running
Apple Silicon and adds feature detection for parts of QEMU that are not
compatible with iOS.

Since v9:

* system() feature check moved to meson.build

Since v8:

* Moved some feature checks to meson.build
* system() stub return error instead of assertion

Since v7:

* Removed libucontext (will be submitted in another patchset)
* Removed slirp build flags update (superseded by subproject patchset)
* Reworked all patches to use feature detection instead of #ifdef CONFIG_IOS
* Added feature detection for CoreAudio
* Fix various cross compiling issues on macOS

Since v6:

* Dropped the Apple Silicon JIT support patch (superseded by another patchset)
* Changed libucontext to be a Meson subproject
* Cache availablity check for preadv/pwritev on macOS 11 and iOS 14

Since v5:

* Fixed some more instances of QAPI define of CONFIG_HOST_BLOCK_DEVICE
* Fixed libucontext build on newer version of GCC

Since v4:

* Updated QAPI schema for CONFIG_HOST_BLOCK_DEVICE
* Updated maintainers file for iOS host support
* Moved system() changes to osdep.h
* Fixed typo in libucontext meson.build change

Since v3:

* Moved mirror JIT support to a different patch set.
* Removed dependency on `pthread_jit_write_protect_np` because it was redundent
  and also crashes if called on a non-jailbroken iOS device.
* Removed `--enable-cross-compile` option
* Fixed checkpatch errors
* Fixed iOS build on master due to new test recently added which calls system()

Since v2:

* Changed getting mirror pointer from a macro to inline functions
* Split constification of TCG code pointers to separate patch
* Removed slirp updates (will send future patch once slirp changes are in)
* Removed shared library patch (will send future patch)

-j

Joelle van Dyne (11):
  block: feature detection for host block support
  configure: cross-compiling with empty cross_prefix
  configure: check for sys/disk.h
  slirp: feature detection for smbd
  osdep: build with non-working system() function
  darwin: remove redundant dependency declaration
  darwin: fix cross-compiling for Darwin
  configure: cross compile should use x86_64 cpu_family
  block: check availablity for preadv/pwritev on mac
  darwin: detect CoreAudio for build
  darwin: remove 64-bit build detection on 32-bit OS

 configure            | 84 ++++++++++++++++++++++++++++++++++----------
 meson.build          | 10 ++++--
 qapi/block-core.json | 10 ++++--
 include/qemu/osdep.h | 12 +++++++
 block.c              |  2 +-
 block/file-posix.c   | 68 ++++++++++++++++++++++++++++-------
 net/slirp.c          | 16 ++++-----
 7 files changed, 158 insertions(+), 44 deletions(-)

Comments

Peter Maydell Jan. 28, 2021, 12:27 p.m. UTC | #1

On Tue, 26 Jan 2021 at 01:29, Joelle van Dyne <[e-mail]> wrote:
>
> These set of changes brings QEMU TCG to iOS devices and future Apple Silicon
> devices. They were originally developed last year and have been working in the
> UTM app. Recently, we ported the changes to master, re-wrote a lot of the build
> script changes for meson, and broke up the patches into more distinct units.
>
> The bulk of the changes allow for cross-compiling for both iOS and macOS running
> Apple Silicon and adds feature detection for parts of QEMU that are not
> compatible with iOS.

Hi; more than half of this series has been reviewed, so given that
the patches are all more-or-less independent fixes I'm going to
take the reviewed patches into target-arm.next (which I'm planning to
do a pullreq for on Friday), so you don't have to keep carrying
those parts around as you revise the series.

Specifically, I'm taking:

>   configure: cross-compiling with empty cross_prefix
>   osdep: build with non-working system() function
>   darwin: remove redundant dependency declaration
>   darwin: fix cross-compiling for Darwin
>   configure: cross compile should use x86_64 cpu_family
>   darwin: detect CoreAudio for build
>   darwin: remove 64-bit build detection on 32-bit OS

thanks
-- PMM