| Message ID | 20210127112554.3770172-1-lee.jones@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Rid W=1 warnings from Thunderbolt | expand |
Hi Lee, On Wed, Jan 27, 2021 at 11:25:42AM +0000, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Only 1 small set required for Thunderbolt. Pretty good! > > Lee Jones (12): > thunderbolt: dma_port: Remove unused variable 'ret' > thunderbolt: cap: Fix kernel-doc formatting issue > thunderbolt: ctl: Demote non-conformant kernel-doc headers > thunderbolt: eeprom: Demote non-conformant kernel-doc headers to > standard comment blocks > thunderbolt: pa: Demote non-conformant kernel-doc headers > thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv' > param > thunderbolt: nhi: Demote some non-conformant kernel-doc headers > thunderbolt: tb: Kernel-doc function headers should document their > parameters > thunderbolt: swit: Demote a bunch of non-conformant kernel-doc headers > thunderbolt: icm: Fix a couple of formatting issues > thunderbolt: tunnel: Fix misspelling of 'receive_path' > thunderbolt: swit: Fix function name in the header I applied all of the changes that touch static functions. For non-static functions I will send a patch set shortly that adds the missing bits for the kernel-doc descriptions. I also fixed $subject lines of few patches ("switch:" instead of "swit:"). Please check that I got everything correct in git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git next Thanks!
On Thu, 28 Jan 2021, Mika Westerberg wrote: > Hi Lee, > > On Wed, Jan 27, 2021 at 11:25:42AM +0000, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Only 1 small set required for Thunderbolt. Pretty good! > > > > Lee Jones (12): > > thunderbolt: dma_port: Remove unused variable 'ret' > > thunderbolt: cap: Fix kernel-doc formatting issue > > thunderbolt: ctl: Demote non-conformant kernel-doc headers > > thunderbolt: eeprom: Demote non-conformant kernel-doc headers to > > standard comment blocks > > thunderbolt: pa: Demote non-conformant kernel-doc headers > > thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv' > > param > > thunderbolt: nhi: Demote some non-conformant kernel-doc headers > > thunderbolt: tb: Kernel-doc function headers should document their > > parameters > > thunderbolt: swit: Demote a bunch of non-conformant kernel-doc headers > > thunderbolt: icm: Fix a couple of formatting issues > > thunderbolt: tunnel: Fix misspelling of 'receive_path' > > thunderbolt: swit: Fix function name in the header > > I applied all of the changes that touch static functions. For non-static > functions I will send a patch set shortly that adds the missing bits for > the kernel-doc descriptions. I also fixed $subject lines of few patches > ("switch:" instead of "swit:"). Oh, that's odd. This must be a bug in my script. As I strip [ch], as in *.c and *.h. Thanks for noticing. > Please check that I got everything correct in > > git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git next > > Thanks!
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Only 1 small set required for Thunderbolt. Pretty good! Lee Jones (12): thunderbolt: dma_port: Remove unused variable 'ret' thunderbolt: cap: Fix kernel-doc formatting issue thunderbolt: ctl: Demote non-conformant kernel-doc headers thunderbolt: eeprom: Demote non-conformant kernel-doc headers to standard comment blocks thunderbolt: pa: Demote non-conformant kernel-doc headers thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv' param thunderbolt: nhi: Demote some non-conformant kernel-doc headers thunderbolt: tb: Kernel-doc function headers should document their parameters thunderbolt: swit: Demote a bunch of non-conformant kernel-doc headers thunderbolt: icm: Fix a couple of formatting issues thunderbolt: tunnel: Fix misspelling of 'receive_path' thunderbolt: swit: Fix function name in the header drivers/thunderbolt/cap.c | 2 +- drivers/thunderbolt/ctl.c | 22 +++++++++++----------- drivers/thunderbolt/dma_port.c | 5 ++--- drivers/thunderbolt/eeprom.c | 24 ++++++++++++------------ drivers/thunderbolt/icm.c | 4 ++-- drivers/thunderbolt/nhi.c | 14 +++++++------- drivers/thunderbolt/path.c | 4 ++-- drivers/thunderbolt/switch.c | 14 +++++++------- drivers/thunderbolt/tb.c | 12 ++++++------ drivers/thunderbolt/tunnel.c | 2 +- drivers/thunderbolt/xdomain.c | 2 +- 11 files changed, 52 insertions(+), 53 deletions(-) Cc: Alexei Starovoitov <ast@kernel.org> Cc: Andreas Noever <andreas.noever@gmail.com> Cc: bpf@vger.kernel.org Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Jesper Dangaard Brouer <hawk@kernel.org> Cc: John Fastabend <john.fastabend@gmail.com> Cc: linux-usb@vger.kernel.org Cc: Michael Jamet <michael.jamet@intel.com> Cc: Mika Westerberg <mika.westerberg@linux.intel.com> Cc: netdev@vger.kernel.org Cc: Yehezkel Bernat <YehezkelShB@gmail.com>