| Message ID | 20201203022321.19952-1-rosenp@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs | expand |
Hi Rosen, > Split up the pins to match earlier definitions. Allows LEDs to flash > properly. > > Fixes: ced8025b569e ("ARM: dts: armada388-helios4") > > Signed-off-by: Rosen Penev <rosenp@gmail.com> Applied on mvebu/dt Thanks, Gregory > --- > arch/arm/boot/dts/armada-388-helios4.dts | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts > index b3728de3bd3f..5a6af7e83e44 100644 > --- a/arch/arm/boot/dts/armada-388-helios4.dts > +++ b/arch/arm/boot/dts/armada-388-helios4.dts > @@ -70,6 +70,9 @@ > > system-leds { > compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&helios_system_led_pins>; > + > status-led { > label = "helios4:green:status"; > gpios = <&gpio0 24 GPIO_ACTIVE_LOW>; > @@ -86,6 +89,9 @@ > > io-leds { > compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&helios_io_led_pins>; > + > sata1-led { > label = "helios4:green:ata1"; > gpios = <&gpio1 17 GPIO_ACTIVE_LOW>; > @@ -286,9 +292,12 @@ > "mpp39", "mpp40"; > marvell,function = "sd0"; > }; > - helios_led_pins: helios-led-pins { > - marvell,pins = "mpp24", "mpp25", > - "mpp49", "mpp50", > + helios_system_led_pins: helios-system-led-pins { > + marvell,pins = "mpp24", "mpp25"; > + marvell,function = "gpio"; > + }; > + helios_io_led_pins: helios-io-led-pins { > + marvell,pins = "mpp49", "mpp50", > "mpp52", "mpp53", > "mpp54"; > marvell,function = "gpio"; > -- > 2.17.1 >
diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts index b3728de3bd3f..5a6af7e83e44 100644 --- a/arch/arm/boot/dts/armada-388-helios4.dts +++ b/arch/arm/boot/dts/armada-388-helios4.dts @@ -70,6 +70,9 @@ system-leds { compatible = "gpio-leds"; + pinctrl-names = "default"; + pinctrl-0 = <&helios_system_led_pins>; + status-led { label = "helios4:green:status"; gpios = <&gpio0 24 GPIO_ACTIVE_LOW>; @@ -86,6 +89,9 @@ io-leds { compatible = "gpio-leds"; + pinctrl-names = "default"; + pinctrl-0 = <&helios_io_led_pins>; + sata1-led { label = "helios4:green:ata1"; gpios = <&gpio1 17 GPIO_ACTIVE_LOW>; @@ -286,9 +292,12 @@ "mpp39", "mpp40"; marvell,function = "sd0"; }; - helios_led_pins: helios-led-pins { - marvell,pins = "mpp24", "mpp25", - "mpp49", "mpp50", + helios_system_led_pins: helios-system-led-pins { + marvell,pins = "mpp24", "mpp25"; + marvell,function = "gpio"; + }; + helios_io_led_pins: helios-io-led-pins { + marvell,pins = "mpp49", "mpp50", "mpp52", "mpp53", "mpp54"; marvell,function = "gpio";
Split up the pins to match earlier definitions. Allows LEDs to flash properly. Fixes: ced8025b569e ("ARM: dts: armada388-helios4") Signed-off-by: Rosen Penev <rosenp@gmail.com> --- arch/arm/boot/dts/armada-388-helios4.dts | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)