diff mbox series

[2/2] ARM: dts: armada388-helios4: assign pinctrl to each fan

Message ID 20201203022321.19952-2-rosenp@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs | expand

Commit Message

Rosen Penev Dec. 3, 2020, 2:23 a.m. UTC
Split up the pins for each fan. This is needed in order to control them

Fixes: ced8025b569e ("ARM: dts: armada388-helios4")

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/arm/boot/dts/armada-388-helios4.dts | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

Comments

Gregory CLEMENT Jan. 29, 2021, 3:27 p.m. UTC | #1
Hi Rosen,

> Split up the pins for each fan. This is needed in order to control them
>
> Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Applied on mvebu/dt

Thanks,

Gregory

> ---
>  arch/arm/boot/dts/armada-388-helios4.dts | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts
> index 5a6af7e83e44..ec134e22bae3 100644
> --- a/arch/arm/boot/dts/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/armada-388-helios4.dts
> @@ -127,11 +127,15 @@
>  	fan1: j10-pwm {
>  		compatible = "pwm-fan";
>  		pwms = <&gpio1 9 40000>;	/* Target freq:25 kHz */
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&helios_fan1_pins>;
>  	};
>  
>  	fan2: j17-pwm {
>  		compatible = "pwm-fan";
>  		pwms = <&gpio1 23 40000>;	/* Target freq:25 kHz */
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&helios_fan2_pins>;
>  	};
>  
>  	usb2_phy: usb2-phy {
> @@ -302,9 +306,12 @@
>  						       "mpp54";
>  					marvell,function = "gpio";
>  				};
> -				helios_fan_pins: helios-fan-pins {
> -					marvell,pins = "mpp41", "mpp43",
> -						       "mpp48", "mpp55";
> +				helios_fan1_pins: helios_fan1_pins {
> +					marvell,pins = "mpp41", "mpp43";
> +					marvell,function = "gpio";
> +				};
> +				helios_fan2_pins: helios_fan2_pins {
> +					marvell,pins = "mpp48", "mpp55";
>  					marvell,function = "gpio";
>  				};
>  				microsom_spi1_cs_pins: spi1-cs-pins {
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts
index 5a6af7e83e44..ec134e22bae3 100644
--- a/arch/arm/boot/dts/armada-388-helios4.dts
+++ b/arch/arm/boot/dts/armada-388-helios4.dts
@@ -127,11 +127,15 @@ 
 	fan1: j10-pwm {
 		compatible = "pwm-fan";
 		pwms = <&gpio1 9 40000>;	/* Target freq:25 kHz */
+		pinctrl-names = "default";
+		pinctrl-0 = <&helios_fan1_pins>;
 	};
 
 	fan2: j17-pwm {
 		compatible = "pwm-fan";
 		pwms = <&gpio1 23 40000>;	/* Target freq:25 kHz */
+		pinctrl-names = "default";
+		pinctrl-0 = <&helios_fan2_pins>;
 	};
 
 	usb2_phy: usb2-phy {
@@ -302,9 +306,12 @@ 
 						       "mpp54";
 					marvell,function = "gpio";
 				};
-				helios_fan_pins: helios-fan-pins {
-					marvell,pins = "mpp41", "mpp43",
-						       "mpp48", "mpp55";
+				helios_fan1_pins: helios_fan1_pins {
+					marvell,pins = "mpp41", "mpp43";
+					marvell,function = "gpio";
+				};
+				helios_fan2_pins: helios_fan2_pins {
+					marvell,pins = "mpp48", "mpp55";
 					marvell,function = "gpio";
 				};
 				microsom_spi1_cs_pins: spi1-cs-pins {