| Message ID | 20210130105717.2628781-4-vincent.knecht@mailoo.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Alcatel Idol 3 (4.7") smartphone support | expand |
On Sat, Jan 30, 2021 at 11:57:12AM +0100, Vincent Knecht wrote: > Disable MDSS (Mobile Display Subsystem) by default in msm8916.dtsi > and only explicitly enable it in devices' DT which actually use it. > > This leads to faster boot and cleaner logs for other devices, > which also won't have to explicitly disable MDSS to use framebuffer. > > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> Thanks for the patch! I think this is a good thing because normally most things are disabled by default in msm8916.dtsi (e.g. eMMC, SD card, WCNSS, ....). Also, there are actually some devices that don't have a display (e.g. the 4IoT board [1]). Having to disable it specifically is kind of weird. So: Reviewed-by: Stephan Gerhold <stephan@gerhold.net> [1]: https://www.96boards.org/product/4iot/ > --- > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 4 ++++ > arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 4 ++++ > arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 + > 3 files changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > index 3a9538e1ec97..6aef0c2e4f0a 100644 > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > @@ -301,6 +301,10 @@ &lpass { > status = "okay"; > }; > > +&mdss { > + status = "okay"; > +}; > + > &pm8916_resin { > status = "okay"; > linux,code = <KEY_VOLUMEDOWN>; > diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi > index f1af798abd74..230ba3ce3277 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi > @@ -132,6 +132,10 @@ &dsi0 { > pinctrl-1 = <&mdss_sleep>; > }; > > +&mdss { > + status = "okay"; > +}; > + > &pm8916_resin { > status = "okay"; > linux,code = <KEY_VOLUMEDOWN>; > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 402e891a84ab..8f9a651d3827 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -913,6 +913,7 @@ tcsr: syscon@1937000 { > }; > > mdss: mdss@1a00000 { > + status = "disabled"; > compatible = "qcom,mdss"; > reg = <0x01a00000 0x1000>, > <0x01ac8000 0x3000>; > -- > 2.29.2 > > >
On 30.01.2021 11:57, Vincent Knecht wrote: > Disable MDSS (Mobile Display Subsystem) by default in msm8916.dtsi > and only explicitly enable it in devices' DT which actually use it. > > This leads to faster boot and cleaner logs for other devices, > which also won't have to explicitly disable MDSS to use framebuffer. > > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> > Reviewed-by: Stephan Gerhold <stephan@gerhold.net> > --- > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 4 ++++ > arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 4 ++++ > arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 + > 3 files changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > index 3a9538e1ec97..6aef0c2e4f0a 100644 > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > @@ -301,6 +301,10 @@ &lpass { > status = "okay"; > }; > > +&mdss { > + status = "okay"; > +}; > + > &pm8916_resin { > status = "okay"; > linux,code = <KEY_VOLUMEDOWN>; > diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi > index f1af798abd74..230ba3ce3277 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi > @@ -132,6 +132,10 @@ &dsi0 { > pinctrl-1 = <&mdss_sleep>; > }; > > +&mdss { > + status = "okay"; > +}; > + > &pm8916_resin { > status = "okay"; > linux,code = <KEY_VOLUMEDOWN>; > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 402e891a84ab..8f9a651d3827 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -913,6 +913,7 @@ tcsr: syscon@1937000 { > }; > > mdss: mdss@1a00000 { > + status = "disabled"; > compatible = "qcom,mdss"; > reg = <0x01a00000 0x1000>, > <0x01ac8000 0x3000>; > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi index 3a9538e1ec97..6aef0c2e4f0a 100644 --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi @@ -301,6 +301,10 @@ &lpass { status = "okay"; }; +&mdss { + status = "okay"; +}; + &pm8916_resin { status = "okay"; linux,code = <KEY_VOLUMEDOWN>; diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi index f1af798abd74..230ba3ce3277 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi @@ -132,6 +132,10 @@ &dsi0 { pinctrl-1 = <&mdss_sleep>; }; +&mdss { + status = "okay"; +}; + &pm8916_resin { status = "okay"; linux,code = <KEY_VOLUMEDOWN>; diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 402e891a84ab..8f9a651d3827 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -913,6 +913,7 @@ tcsr: syscon@1937000 { }; mdss: mdss@1a00000 { + status = "disabled"; compatible = "qcom,mdss"; reg = <0x01a00000 0x1000>, <0x01ac8000 0x3000>;
Disable MDSS (Mobile Display Subsystem) by default in msm8916.dtsi and only explicitly enable it in devices' DT which actually use it. This leads to faster boot and cleaner logs for other devices, which also won't have to explicitly disable MDSS to use framebuffer. Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> --- arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 4 ++++ arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 4 ++++ arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 + 3 files changed, 9 insertions(+)