diff mbox series

[1/2] ALSA: ac97: Constify static struct attribute_group

Message ID 20210131001241.2278-2-rikard.falkeborn@gmail.com (mailing list archive)
State Accepted
Commit fa2e5a647ed2ed299974ea5916c1e7648f81030b
Headers show
Series ALSA: Constify static attribute_group structs | expand

Commit Message

Rikard Falkeborn Jan. 31, 2021, 12:12 a.m. UTC 
The only usage of ac97_adapter_attr_group is to put its address in an
array of pointers to const attribute_group structs. Make it const to
allow the compiler to put it in read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
 sound/ac97/bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai Jan. 31, 2021, 8:50 a.m. UTC | #1 
On Sun, 31 Jan 2021 01:12:40 +0100,
Rikard Falkeborn wrote:
> 
> The only usage of ac97_adapter_attr_group is to put its address in an
> array of pointers to const attribute_group structs. Make it const to
> allow the compiler to put it in read-only memory.
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Thanks, applied.


Takashi
diff mbox series

Patch

diff --git a/sound/ac97/bus.c b/sound/ac97/bus.c
index 7985dd8198b6..d9077e91382b 100644
--- a/sound/ac97/bus.c
+++ b/sound/ac97/bus.c
@@ -273,7 +273,7 @@  static struct attribute *ac97_controller_device_attrs[] = {
 	NULL
 };
 
-static struct attribute_group ac97_adapter_attr_group = {
+static const struct attribute_group ac97_adapter_attr_group = {
 	.name	= "ac97_operations",
 	.attrs	= ac97_controller_device_attrs,
 };