| Message ID | 1612175042-56866-1-git-send-email-john.garry@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3 | expand |
On 2021-02-01 10:24, John Garry wrote: > The ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3_PMU was added with the idea > that a SMMUv3 PMCG would only exist on a system with an associated SMMUv3. > > However it is not the job of Kconfig to make these sorts of decisions (even > if it were true), so remove the dependency. Reviewed-by: Robin Murphy <robin.murphy@arm.com> > Signed-off-by: John Garry <john.garry@huawei.com> > > diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig > index 3075cf171f78..77522e5efe11 100644 > --- a/drivers/perf/Kconfig > +++ b/drivers/perf/Kconfig > @@ -62,7 +62,7 @@ config ARM_PMU_ACPI > > config ARM_SMMU_V3_PMU > tristate "ARM SMMUv3 Performance Monitors Extension" > - depends on ARM64 && ACPI && ARM_SMMU_V3 > + depends on ARM64 && ACPI > help > Provides support for the ARM SMMUv3 Performance Monitor Counter > Groups (PMCG), which provide monitoring of transactions passing >
On Mon, 1 Feb 2021 18:24:02 +0800, John Garry wrote: > The ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3_PMU was added with the idea > that a SMMUv3 PMCG would only exist on a system with an associated SMMUv3. > > However it is not the job of Kconfig to make these sorts of decisions (even > if it were true), so remove the dependency. Applied to will (for-joerg/arm-smmu/updates), thanks! [1/1] driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3 https://git.kernel.org/will/c/34eb9359c111 Cheers,
diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig index 3075cf171f78..77522e5efe11 100644 --- a/drivers/perf/Kconfig +++ b/drivers/perf/Kconfig @@ -62,7 +62,7 @@ config ARM_PMU_ACPI config ARM_SMMU_V3_PMU tristate "ARM SMMUv3 Performance Monitors Extension" - depends on ARM64 && ACPI && ARM_SMMU_V3 + depends on ARM64 && ACPI help Provides support for the ARM SMMUv3 Performance Monitor Counter Groups (PMCG), which provide monitoring of transactions passing
The ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3_PMU was added with the idea that a SMMUv3 PMCG would only exist on a system with an associated SMMUv3. However it is not the job of Kconfig to make these sorts of decisions (even if it were true), so remove the dependency. Signed-off-by: John Garry <john.garry@huawei.com>