| Message ID | d128216d3b0aea0b4178e11978f5dd3e8dbeb590.1612208222.git.andreyknvl@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kasan: optimizations and fixes for HW_TAGS | expand |
On Mon, Feb 01, 2021 at 08:43:36PM +0100, Andrey Konovalov wrote: > Export mte_enable_kernel() and mte_set_report_once() to fix: > > ERROR: modpost: "mte_enable_kernel" [lib/test_kasan.ko] undefined! > ERROR: modpost: "mte_set_report_once" [lib/test_kasan.ko] undefined! > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > --- > arch/arm64/kernel/mte.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > index 8b27b70e1aac..2c91bd288ea4 100644 > --- a/arch/arm64/kernel/mte.c > +++ b/arch/arm64/kernel/mte.c > @@ -120,6 +120,7 @@ void mte_enable_kernel_sync(void) > { > __mte_enable_kernel("synchronous", SCTLR_ELx_TCF_SYNC); > } > +EXPORT_SYMBOL(mte_enable_kernel_sync); > > void mte_enable_kernel_async(void) > { > @@ -130,6 +131,7 @@ void mte_set_report_once(bool state) > { > WRITE_ONCE(report_fault_once, state); > } > +EXPORT_SYMBOL(mte_set_report_once); EXPORT_SYMBOL_GPL ? Will
On Tue, Feb 2, 2021 at 11:46 AM Will Deacon <will@kernel.org> wrote: > > On Mon, Feb 01, 2021 at 08:43:36PM +0100, Andrey Konovalov wrote: > > Export mte_enable_kernel() and mte_set_report_once() to fix: > > > > ERROR: modpost: "mte_enable_kernel" [lib/test_kasan.ko] undefined! > > ERROR: modpost: "mte_set_report_once" [lib/test_kasan.ko] undefined! > > > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > > --- > > arch/arm64/kernel/mte.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > > index 8b27b70e1aac..2c91bd288ea4 100644 > > --- a/arch/arm64/kernel/mte.c > > +++ b/arch/arm64/kernel/mte.c > > @@ -120,6 +120,7 @@ void mte_enable_kernel_sync(void) > > { > > __mte_enable_kernel("synchronous", SCTLR_ELx_TCF_SYNC); > > } > > +EXPORT_SYMBOL(mte_enable_kernel_sync); > > > > void mte_enable_kernel_async(void) > > { > > @@ -130,6 +131,7 @@ void mte_set_report_once(bool state) > > { > > WRITE_ONCE(report_fault_once, state); > > } > > +EXPORT_SYMBOL(mte_set_report_once); > > EXPORT_SYMBOL_GPL ? SGTM, will do in v2, thanks!
On Mon, Feb 01, 2021 at 08:43:36PM +0100, Andrey Konovalov wrote: > Export mte_enable_kernel() and mte_set_report_once() to fix: > > ERROR: modpost: "mte_enable_kernel" [lib/test_kasan.ko] undefined! > ERROR: modpost: "mte_set_report_once" [lib/test_kasan.ko] undefined! > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > --- > arch/arm64/kernel/mte.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > index 8b27b70e1aac..2c91bd288ea4 100644 > --- a/arch/arm64/kernel/mte.c > +++ b/arch/arm64/kernel/mte.c > @@ -120,6 +120,7 @@ void mte_enable_kernel_sync(void) > { > __mte_enable_kernel("synchronous", SCTLR_ELx_TCF_SYNC); > } > +EXPORT_SYMBOL(mte_enable_kernel_sync); > > void mte_enable_kernel_async(void) > { > @@ -130,6 +131,7 @@ void mte_set_report_once(bool state) > { > WRITE_ONCE(report_fault_once, state); > } > +EXPORT_SYMBOL(mte_set_report_once); With EXPORT_SYMBOL_GPL: Acked-by: Catalin Marinas <catalin.marinas@arm.com>
diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c index 8b27b70e1aac..2c91bd288ea4 100644 --- a/arch/arm64/kernel/mte.c +++ b/arch/arm64/kernel/mte.c @@ -120,6 +120,7 @@ void mte_enable_kernel_sync(void) { __mte_enable_kernel("synchronous", SCTLR_ELx_TCF_SYNC); } +EXPORT_SYMBOL(mte_enable_kernel_sync); void mte_enable_kernel_async(void) { @@ -130,6 +131,7 @@ void mte_set_report_once(bool state) { WRITE_ONCE(report_fault_once, state); } +EXPORT_SYMBOL(mte_set_report_once); bool mte_report_once(void) {
Export mte_enable_kernel() and mte_set_report_once() to fix: ERROR: modpost: "mte_enable_kernel" [lib/test_kasan.ko] undefined! ERROR: modpost: "mte_set_report_once" [lib/test_kasan.ko] undefined! Signed-off-by: Andrey Konovalov <andreyknvl@google.com> --- arch/arm64/kernel/mte.c | 2 ++ 1 file changed, 2 insertions(+)