| Message ID | 20210126083746.3238-3-yung-chuan.liao@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soundwire: clear bus clash/parity interrupt before the mask is enabled | expand |
On 26-01-21, 16:37, Bard Liao wrote: > There is nothing we can do to handle the bus clash interrupt before > interrupt mask is enabled. > > Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> > Reviewed-by: Rander Wang <rander.wang@linux.intel.com> > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > drivers/soundwire/intel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index a2d5cdaa9998..f7ba1a77a1df 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -1286,6 +1286,8 @@ static int sdw_master_read_intel_prop(struct sdw_bus *bus) > if (quirk_mask & SDW_INTEL_QUIRK_MASK_BUS_DISABLE) > prop->hw_disabled = true; > > + prop->quirks = SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH; Should this not be last 'enabling' the quirk patch in series :)
On 2/1/21 4:42 AM, Vinod Koul wrote: > On 26-01-21, 16:37, Bard Liao wrote: >> There is nothing we can do to handle the bus clash interrupt before >> interrupt mask is enabled. >> >> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> >> Reviewed-by: Rander Wang <rander.wang@linux.intel.com> >> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> >> --- >> drivers/soundwire/intel.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c >> index a2d5cdaa9998..f7ba1a77a1df 100644 >> --- a/drivers/soundwire/intel.c >> +++ b/drivers/soundwire/intel.c >> @@ -1286,6 +1286,8 @@ static int sdw_master_read_intel_prop(struct sdw_bus *bus) >> if (quirk_mask & SDW_INTEL_QUIRK_MASK_BUS_DISABLE) >> prop->hw_disabled = true; >> >> + prop->quirks = SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH; > > Should this not be last 'enabling' the quirk patch in series :) Sorry, I don't understand the comment. Do you mind clarifying Vinod?
On 01-02-21, 10:20, Pierre-Louis Bossart wrote: > > > On 2/1/21 4:42 AM, Vinod Koul wrote: > > On 26-01-21, 16:37, Bard Liao wrote: > > > There is nothing we can do to handle the bus clash interrupt before > > > interrupt mask is enabled. > > > > > > Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> > > > Reviewed-by: Rander Wang <rander.wang@linux.intel.com> > > > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > > --- > > > drivers/soundwire/intel.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > > > index a2d5cdaa9998..f7ba1a77a1df 100644 > > > --- a/drivers/soundwire/intel.c > > > +++ b/drivers/soundwire/intel.c > > > @@ -1286,6 +1286,8 @@ static int sdw_master_read_intel_prop(struct sdw_bus *bus) > > > if (quirk_mask & SDW_INTEL_QUIRK_MASK_BUS_DISABLE) > > > prop->hw_disabled = true; > > > + prop->quirks = SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH; > > > > Should this not be last 'enabling' the quirk patch in series :) > > Sorry, I don't understand the comment. Do you mind clarifying Vinod? Sure, I would like to series built as, first defining the quirk along/followed by bus changes. Then the last patch should be intel controller changes and setting the quirks (like above) in the last patch. Let me know if you would need further clarification
>>>> + prop->quirks = SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH; >>> >>> Should this not be last 'enabling' the quirk patch in series :) >> >> Sorry, I don't understand the comment. Do you mind clarifying Vinod? > > Sure, I would like to series built as, first defining the quirk > along/followed by bus changes. Then the last patch should be intel > controller changes and setting the quirks (like above) in the last > patch. > > Let me know if you would need further clarification Got it, thanks.
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index a2d5cdaa9998..f7ba1a77a1df 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -1286,6 +1286,8 @@ static int sdw_master_read_intel_prop(struct sdw_bus *bus) if (quirk_mask & SDW_INTEL_QUIRK_MASK_BUS_DISABLE) prop->hw_disabled = true; + prop->quirks = SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH; + return 0; }