| Message ID | 20210203093215.31990-1-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm/rmap: Correct obsolete comment of page_get_anon_vma() | expand |
On Wed, Feb 03, 2021 at 04:32:15AM -0500, Miaohe Lin wrote: > * Since there is no serialization what so ever against page_remove_rmap() > - * the best this function can do is return a locked anon_vma that might > - * have been relevant to this page. > + * the best this function can do is return a refcount increased anon_vma > + * that might have been relevant to this page. Just s/a locked/an/ there's no need to mention again that the refcount is increased.
Hi: On 2021/2/4 20:38, Matthew Wilcox wrote: > On Wed, Feb 03, 2021 at 04:32:15AM -0500, Miaohe Lin wrote: >> * Since there is no serialization what so ever against page_remove_rmap() >> - * the best this function can do is return a locked anon_vma that might >> - * have been relevant to this page. >> + * the best this function can do is return a refcount increased anon_vma >> + * that might have been relevant to this page. > > Just s/a locked/an/ Many thanks for your review and reply. > there's no need to mention again that the refcount> is increased. I think it's ok to mention again that the refcount is increased although I didn't find out where this is first mentioned. Thanks again. > . >
diff --git a/mm/rmap.c b/mm/rmap.c index b49e85605f8f..b0fc27e77d6d 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -462,8 +462,8 @@ void __init anon_vma_init(void) * Getting a lock on a stable anon_vma from a page off the LRU is tricky! * * Since there is no serialization what so ever against page_remove_rmap() - * the best this function can do is return a locked anon_vma that might - * have been relevant to this page. + * the best this function can do is return a refcount increased anon_vma + * that might have been relevant to this page. * * The page might have been remapped to a different anon_vma or the anon_vma * returned may already be freed (and even reused).
Since commit 746b18d421da ("mm: use refcounts for page_lock_anon_vma()"), page_lock_anon_vma() is renamed to page_get_anon_vma() and converted to return a refcount increased anon_vma. But it forgot to change the relevant comment. Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/rmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)