| Message ID | 20210204084343.207847-1-damien.lemoal@wdc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | block: Remove skd driver | expand |
On 2/4/21 1:43 AM, Damien Le Moal wrote: > Hi Jens, > > Instead of spending time fixing the skd driver to (at the very least) > fix the call to set_capacity() with IRQ disabled, I am proposing to > simply remove this driver. The STEC S1220 cards are EOL since 2014 and > not supported by the vendor since several years ago. Given that these > SSDs are very slow by today's NVMe standard, I do not think it is > worthwhile to maintain this driver with newer kernel versions. I will > keep addressing any problem that shows up with LTS versions. > > The first patch removes the skd driver and the second patch reverts > commit 0fe37724f8e7 ("block: fix bd_size_lock use") as the skd driver > was the one driver that needed this (not so nice) fix. > > Please let me know what you think about this. I'm fine with removing it. The 5.12 branch doesn't have the later fix for the bd_size_lock issue, so could you just resend that once the merge window opens and the block bits have gone in? In case I forget...
On 2021/02/04 23:46, Jens Axboe wrote: > On 2/4/21 1:43 AM, Damien Le Moal wrote: >> Hi Jens, >> >> Instead of spending time fixing the skd driver to (at the very least) >> fix the call to set_capacity() with IRQ disabled, I am proposing to >> simply remove this driver. The STEC S1220 cards are EOL since 2014 and >> not supported by the vendor since several years ago. Given that these >> SSDs are very slow by today's NVMe standard, I do not think it is >> worthwhile to maintain this driver with newer kernel versions. I will >> keep addressing any problem that shows up with LTS versions. >> >> The first patch removes the skd driver and the second patch reverts >> commit 0fe37724f8e7 ("block: fix bd_size_lock use") as the skd driver >> was the one driver that needed this (not so nice) fix. >> >> Please let me know what you think about this. > > I'm fine with removing it. The 5.12 branch doesn't have the later > fix for the bd_size_lock issue, so could you just resend that once > the merge window opens and the block bits have gone in? In case I > forget... OK. Will do. Could you confirm if you received patch #1 ? It looks like the list server is dropping it likely because it is too big.
On 2/4/21 7:52 AM, Damien Le Moal wrote: > On 2021/02/04 23:46, Jens Axboe wrote: >> On 2/4/21 1:43 AM, Damien Le Moal wrote: >>> Hi Jens, >>> >>> Instead of spending time fixing the skd driver to (at the very least) >>> fix the call to set_capacity() with IRQ disabled, I am proposing to >>> simply remove this driver. The STEC S1220 cards are EOL since 2014 and >>> not supported by the vendor since several years ago. Given that these >>> SSDs are very slow by today's NVMe standard, I do not think it is >>> worthwhile to maintain this driver with newer kernel versions. I will >>> keep addressing any problem that shows up with LTS versions. >>> >>> The first patch removes the skd driver and the second patch reverts >>> commit 0fe37724f8e7 ("block: fix bd_size_lock use") as the skd driver >>> was the one driver that needed this (not so nice) fix. >>> >>> Please let me know what you think about this. >> >> I'm fine with removing it. The 5.12 branch doesn't have the later >> fix for the bd_size_lock issue, so could you just resend that once >> the merge window opens and the block bits have gone in? In case I >> forget... > > OK. Will do. > > Could you confirm if you received patch #1 ? It looks like the list server is > dropping it likely because it is too big. The list is a huge mess these days, including lore. So not sure what is going on. I did receive it, but it wasn't on lore, hence probably only because I was CC'ed on it.
On 2021/02/04 23:55, Jens Axboe wrote: > On 2/4/21 7:52 AM, Damien Le Moal wrote: >> On 2021/02/04 23:46, Jens Axboe wrote: >>> On 2/4/21 1:43 AM, Damien Le Moal wrote: >>>> Hi Jens, >>>> >>>> Instead of spending time fixing the skd driver to (at the very least) >>>> fix the call to set_capacity() with IRQ disabled, I am proposing to >>>> simply remove this driver. The STEC S1220 cards are EOL since 2014 and >>>> not supported by the vendor since several years ago. Given that these >>>> SSDs are very slow by today's NVMe standard, I do not think it is >>>> worthwhile to maintain this driver with newer kernel versions. I will >>>> keep addressing any problem that shows up with LTS versions. >>>> >>>> The first patch removes the skd driver and the second patch reverts >>>> commit 0fe37724f8e7 ("block: fix bd_size_lock use") as the skd driver >>>> was the one driver that needed this (not so nice) fix. >>>> >>>> Please let me know what you think about this. >>> >>> I'm fine with removing it. The 5.12 branch doesn't have the later >>> fix for the bd_size_lock issue, so could you just resend that once >>> the merge window opens and the block bits have gone in? In case I >>> forget... >> >> OK. Will do. >> >> Could you confirm if you received patch #1 ? It looks like the list server is >> dropping it likely because it is too big. > > The list is a huge mess these days, including lore. So not sure what is > going on. I did receive it, but it wasn't on lore, hence probably only > because I was CC'ed on it. Thanks for the confirmation. I will make sure to keep you in cc.
Hi Jens, Instead of spending time fixing the skd driver to (at the very least) fix the call to set_capacity() with IRQ disabled, I am proposing to simply remove this driver. The STEC S1220 cards are EOL since 2014 and not supported by the vendor since several years ago. Given that these SSDs are very slow by today's NVMe standard, I do not think it is worthwhile to maintain this driver with newer kernel versions. I will keep addressing any problem that shows up with LTS versions. The first patch removes the skd driver and the second patch reverts commit 0fe37724f8e7 ("block: fix bd_size_lock use") as the skd driver was the one driver that needed this (not so nice) fix. Please let me know what you think about this. Damien Le Moal (2): block: remove skd driver block: revert "block: fix bd_size_lock use" MAINTAINERS | 6 - block/genhd.c | 5 +- block/partitions/core.c | 6 +- drivers/block/Kconfig | 10 - drivers/block/Makefile | 2 - drivers/block/skd_main.c | 3670 ------------------------------------- drivers/block/skd_s1120.h | 322 ---- 7 files changed, 4 insertions(+), 4017 deletions(-) delete mode 100644 drivers/block/skd_main.c delete mode 100644 drivers/block/skd_s1120.h