[1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules.

Commit Message

Ivan J. Feb. 3, 2021, 11:34 a.m. UTC

Enable the majority of the Netfilter components as loadable modules
in the omap2plus_defconfig file.

Signed-off-by: Ivan Jelincic <[e-mail]>
Cc: Tony Lindgren <[e-mail]>
Signed-off-by: parazyd <[e-mail]>
---
 arch/arm/configs/omap2plus_defconfig | 149 +++++++++++++++++++++++++++
 1 file changed, 149 insertions(+)

Comments

Grygorii Strashko Feb. 5, 2021, 1:18 p.m. UTC | #1

Hi Tony, Ivan

On 03/02/2021 13:34, Ivan Jelincic wrote:
> Enable the majority of the Netfilter components as loadable modules
> in the omap2plus_defconfig file.
> 
> Signed-off-by: Ivan Jelincic <[e-mail]>
> Cc: Tony Lindgren <[e-mail]>
> Signed-off-by: parazyd <[e-mail]>
> ---
>   arch/arm/configs/omap2plus_defconfig | 149 +++++++++++++++++++++++++++
>   1 file changed, 149 insertions(+)
> 
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index f250bf1cc022..9847502d2c97 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -87,6 +87,155 @@ CONFIG_IP_PNP_DHCP=y
>   CONFIG_IP_PNP_BOOTP=y
>   CONFIG_IP_PNP_RARP=y
>   CONFIG_NETFILTER=y
> +CONFIG_NF_CONNTRACK=m
> +CONFIG_NF_LOG_NETDEV=m
> +CONFIG_NF_CONNTRACK_ZONES=y
> +CONFIG_NF_CONNTRACK_EVENTS=y
> +CONFIG_NF_CONNTRACK_TIMEOUT=y
> +CONFIG_NF_CONNTRACK_TIMESTAMP=y
> +CONFIG_NF_CT_NETLINK=m

[..]

Do we really want to enable all these not TI specific configs?
The main purpose of omap2plus_defconfig is to enable TI specific HW and HW features and
config options required to tests/demonstrate these features - like support for some networking
HW offloads.

Tony Lindgren Feb. 5, 2021, 1:33 p.m. UTC | #2

* Grygorii Strashko <[e-mail]> [210205 13:18]:
> On 03/02/2021 13:34, Ivan Jelincic wrote:
> > Enable the majority of the Netfilter components as loadable modules
> > in the omap2plus_defconfig file.
...
> > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > index f250bf1cc022..9847502d2c97 100644
> > --- a/arch/arm/configs/omap2plus_defconfig
> > +++ b/arch/arm/configs/omap2plus_defconfig
> > @@ -87,6 +87,155 @@ CONFIG_IP_PNP_DHCP=y
> >   CONFIG_IP_PNP_BOOTP=y
> >   CONFIG_IP_PNP_RARP=y
> >   CONFIG_NETFILTER=y
> > +CONFIG_NF_CONNTRACK=m
> > +CONFIG_NF_LOG_NETDEV=m
> > +CONFIG_NF_CONNTRACK_ZONES=y
> > +CONFIG_NF_CONNTRACK_EVENTS=y
> > +CONFIG_NF_CONNTRACK_TIMEOUT=y
> > +CONFIG_NF_CONNTRACK_TIMESTAMP=y
> > +CONFIG_NF_CT_NETLINK=m
> 
> [..]
> 
> Do we really want to enable all these not TI specific configs?
> The main purpose of omap2plus_defconfig is to enable TI specific HW and HW features and
> config options required to tests/demonstrate these features - like support for some networking
> HW offloads.

Well these are loadable modules. And I'd like to have omap2plus_defconfig
and multi_v7_defconfig usable as a base config for distros to use.

For built-in options I agree. We should only enable absolute minimum
for built-in optoins as otherwise things get even more bloated.

Regards,

Tony

Grygorii Strashko Feb. 5, 2021, 2:01 p.m. UTC | #3

On 05/02/2021 15:33, Tony Lindgren wrote:
> * Grygorii Strashko <[e-mail]> [210205 13:18]:
>> On 03/02/2021 13:34, Ivan Jelincic wrote:
>>> Enable the majority of the Netfilter components as loadable modules
>>> in the omap2plus_defconfig file.
> ...
>>> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
>>> index f250bf1cc022..9847502d2c97 100644
>>> --- a/arch/arm/configs/omap2plus_defconfig
>>> +++ b/arch/arm/configs/omap2plus_defconfig
>>> @@ -87,6 +87,155 @@ CONFIG_IP_PNP_DHCP=y
>>>    CONFIG_IP_PNP_BOOTP=y
>>>    CONFIG_IP_PNP_RARP=y
>>>    CONFIG_NETFILTER=y
>>> +CONFIG_NF_CONNTRACK=m
>>> +CONFIG_NF_LOG_NETDEV=m
>>> +CONFIG_NF_CONNTRACK_ZONES=y
>>> +CONFIG_NF_CONNTRACK_EVENTS=y
>>> +CONFIG_NF_CONNTRACK_TIMEOUT=y
>>> +CONFIG_NF_CONNTRACK_TIMESTAMP=y
>>> +CONFIG_NF_CT_NETLINK=m
>>
>> [..]
>>
>> Do we really want to enable all these not TI specific configs?
>> The main purpose of omap2plus_defconfig is to enable TI specific HW and HW features and
>> config options required to tests/demonstrate these features - like support for some networking
>> HW offloads.
> 
> Well these are loadable modules. And I'd like to have omap2plus_defconfig
> and multi_v7_defconfig usable as a base config for distros to use.
> 
> For built-in options I agree. We should only enable absolute minimum
> for built-in optoins as otherwise things get even more bloated.

Ok. Up to you.

Patch

diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index f250bf1cc022..9847502d2c97 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -87,6 +87,155 @@  CONFIG_IP_PNP_DHCP=y
 CONFIG_IP_PNP_BOOTP=y
 CONFIG_IP_PNP_RARP=y
 CONFIG_NETFILTER=y
+CONFIG_NF_CONNTRACK=m
+CONFIG_NF_LOG_NETDEV=m
+CONFIG_NF_CONNTRACK_ZONES=y
+CONFIG_NF_CONNTRACK_EVENTS=y
+CONFIG_NF_CONNTRACK_TIMEOUT=y
+CONFIG_NF_CONNTRACK_TIMESTAMP=y
+CONFIG_NF_CT_NETLINK=m
+CONFIG_NF_CT_NETLINK_TIMEOUT=m
+CONFIG_NF_CT_NETLINK_HELPER=m
+CONFIG_NETFILTER_NETLINK_GLUE_CT=y
+CONFIG_NF_TABLES=m
+CONFIG_NF_TABLES_INET=y
+CONFIG_NF_TABLES_NETDEV=y
+CONFIG_NFT_NUMGEN=m
+CONFIG_NFT_CT=m
+CONFIG_NFT_COUNTER=m
+CONFIG_NFT_CONNLIMIT=m
+CONFIG_NFT_LOG=m
+CONFIG_NFT_LIMIT=m
+CONFIG_NFT_MASQ=m
+CONFIG_NFT_REDIR=m
+CONFIG_NFT_NAT=m
+CONFIG_NFT_TUNNEL=m
+CONFIG_NFT_OBJREF=m
+CONFIG_NFT_QUEUE=m
+CONFIG_NFT_QUOTA=m
+CONFIG_NFT_REJECT=m
+CONFIG_NFT_COMPAT=m
+CONFIG_NFT_HASH=m
+CONFIG_NFT_FIB_INET=m
+CONFIG_NFT_XFRM=m
+CONFIG_NFT_SOCKET=m
+CONFIG_NFT_OSF=m
+CONFIG_NFT_TPROXY=m
+CONFIG_NFT_SYNPROXY=m
+CONFIG_NFT_DUP_NETDEV=m
+CONFIG_NFT_FWD_NETDEV=m
+CONFIG_NFT_FIB_NETDEV=m
+CONFIG_NFT_REJECT_NETDEV=m
+CONFIG_NF_FLOW_TABLE_INET=m
+CONFIG_NF_FLOW_TABLE=m
+CONFIG_NETFILTER_XT_TARGET_AUDIT=m
+CONFIG_NETFILTER_XT_TARGET_CLASSIFY=m
+CONFIG_NETFILTER_XT_TARGET_CONNMARK=m
+CONFIG_NETFILTER_XT_TARGET_CT=m
+CONFIG_NETFILTER_XT_TARGET_DSCP=m
+CONFIG_NETFILTER_XT_TARGET_HMARK=m
+CONFIG_NETFILTER_XT_TARGET_IDLETIMER=m
+CONFIG_NETFILTER_XT_TARGET_LED=m
+CONFIG_NETFILTER_XT_TARGET_LOG=m
+CONFIG_NETFILTER_XT_TARGET_MARK=m
+CONFIG_NETFILTER_XT_TARGET_NFLOG=m
+CONFIG_NETFILTER_XT_TARGET_NFQUEUE=m
+CONFIG_NETFILTER_XT_TARGET_TEE=m
+CONFIG_NETFILTER_XT_TARGET_TPROXY=m
+CONFIG_NETFILTER_XT_TARGET_TRACE=m
+CONFIG_NETFILTER_XT_TARGET_TCPMSS=m
+CONFIG_NETFILTER_XT_TARGET_TCPOPTSTRIP=m
+CONFIG_NETFILTER_XT_MATCH_ADDRTYPE=m
+CONFIG_NETFILTER_XT_MATCH_BPF=m
+CONFIG_NETFILTER_XT_MATCH_CGROUP=m
+CONFIG_NETFILTER_XT_MATCH_CLUSTER=m
+CONFIG_NETFILTER_XT_MATCH_COMMENT=m
+CONFIG_NETFILTER_XT_MATCH_CONNBYTES=m
+CONFIG_NETFILTER_XT_MATCH_CONNLABEL=m
+CONFIG_NETFILTER_XT_MATCH_CONNLIMIT=m
+CONFIG_NETFILTER_XT_MATCH_CONNMARK=m
+CONFIG_NETFILTER_XT_MATCH_CONNTRACK=m
+CONFIG_NETFILTER_XT_MATCH_CPU=m
+CONFIG_NETFILTER_XT_MATCH_DCCP=m
+CONFIG_NETFILTER_XT_MATCH_DEVGROUP=m
+CONFIG_NETFILTER_XT_MATCH_DSCP=m
+CONFIG_NETFILTER_XT_MATCH_ESP=m
+CONFIG_NETFILTER_XT_MATCH_HASHLIMIT=m
+CONFIG_NETFILTER_XT_MATCH_HELPER=m
+CONFIG_NETFILTER_XT_MATCH_IPCOMP=m
+CONFIG_NETFILTER_XT_MATCH_IPRANGE=m
+CONFIG_NETFILTER_XT_MATCH_L2TP=m
+CONFIG_NETFILTER_XT_MATCH_LENGTH=m
+CONFIG_NETFILTER_XT_MATCH_LIMIT=m
+CONFIG_NETFILTER_XT_MATCH_MAC=m
+CONFIG_NETFILTER_XT_MATCH_MARK=m
+CONFIG_NETFILTER_XT_MATCH_MULTIPORT=m
+CONFIG_NETFILTER_XT_MATCH_NFACCT=m
+CONFIG_NETFILTER_XT_MATCH_OSF=m
+CONFIG_NETFILTER_XT_MATCH_OWNER=m
+CONFIG_NETFILTER_XT_MATCH_POLICY=m
+CONFIG_NETFILTER_XT_MATCH_PKTTYPE=m
+CONFIG_NETFILTER_XT_MATCH_QUOTA=m
+CONFIG_NETFILTER_XT_MATCH_RATEEST=m
+CONFIG_NETFILTER_XT_MATCH_REALM=m
+CONFIG_NETFILTER_XT_MATCH_RECENT=m
+CONFIG_NETFILTER_XT_MATCH_SCTP=m
+CONFIG_NETFILTER_XT_MATCH_SOCKET=m
+CONFIG_NETFILTER_XT_MATCH_STATE=m
+CONFIG_NETFILTER_XT_MATCH_STATISTIC=m
+CONFIG_NETFILTER_XT_MATCH_STRING=m
+CONFIG_NETFILTER_XT_MATCH_TCPMSS=m
+CONFIG_NETFILTER_XT_MATCH_TIME=m
+CONFIG_NETFILTER_XT_MATCH_U32=m
+CONFIG_NFT_DUP_IPV4=m
+CONFIG_NFT_FIB_IPV4=m
+CONFIG_NF_FLOW_TABLE_IPV4=m
+CONFIG_IP_NF_IPTABLES=m
+CONFIG_IP_NF_MATCH_AH=m
+CONFIG_IP_NF_MATCH_ECN=m
+CONFIG_IP_NF_MATCH_RPFILTER=m
+CONFIG_IP_NF_MATCH_TTL=m
+CONFIG_IP_NF_FILTER=m
+CONFIG_IP_NF_TARGET_REJECT=m
+CONFIG_IP_NF_TARGET_SYNPROXY=m
+CONFIG_IP_NF_NAT=m
+CONFIG_IP_NF_TARGET_MASQUERADE=m
+CONFIG_IP_NF_TARGET_NETMAP=m
+CONFIG_IP_NF_TARGET_REDIRECT=m
+CONFIG_IP_NF_MANGLE=m
+CONFIG_IP_NF_TARGET_CLUSTERIP=m
+CONFIG_IP_NF_TARGET_ECN=m
+CONFIG_IP_NF_TARGET_TTL=m
+CONFIG_IP_NF_RAW=m
+CONFIG_IP_NF_SECURITY=m
+CONFIG_NFT_DUP_IPV6=m
+CONFIG_NFT_FIB_IPV6=m
+CONFIG_NF_FLOW_TABLE_IPV6=m
+CONFIG_IP6_NF_IPTABLES=m
+CONFIG_IP6_NF_MATCH_AH=m
+CONFIG_IP6_NF_MATCH_EUI64=m
+CONFIG_IP6_NF_MATCH_FRAG=m
+CONFIG_IP6_NF_MATCH_OPTS=m
+CONFIG_IP6_NF_MATCH_HL=m
+CONFIG_IP6_NF_MATCH_IPV6HEADER=m
+CONFIG_IP6_NF_MATCH_MH=m
+CONFIG_IP6_NF_MATCH_RPFILTER=m
+CONFIG_IP6_NF_MATCH_RT=m
+CONFIG_IP6_NF_MATCH_SRH=m
+CONFIG_IP6_NF_TARGET_HL=m
+CONFIG_IP6_NF_FILTER=m
+CONFIG_IP6_NF_TARGET_REJECT=m
+CONFIG_IP6_NF_TARGET_SYNPROXY=m
+CONFIG_IP6_NF_MANGLE=m
+CONFIG_IP6_NF_RAW=m
+CONFIG_IP6_NF_SECURITY=m
+CONFIG_IP6_NF_NAT=m
+CONFIG_IP6_NF_TARGET_MASQUERADE=m
+CONFIG_IP6_NF_TARGET_NPT=m
+CONFIG_NF_TABLES_BRIDGE=m
+CONFIG_NFT_BRIDGE_META=m
+CONFIG_NFT_BRIDGE_REJECT=m
+CONFIG_NF_LOG_BRIDGE=m
 CONFIG_BRIDGE=m
 CONFIG_BRIDGE_VLAN_FILTERING=y
 CONFIG_VLAN_8021Q=m