| Message ID | 20210206140320.GA601846@ubuntu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: ad7949: fix wrong ADC result due to incorrect bit mask | expand |
On Sat, Feb 06, 2021 at 03:03:20PM +0100, Wilfried Wessner wrote: > Signed-off-by: Wilfried Wessner <wilfried.wessner@gmail.com> This needs to go after the changelog text. > > Fixes a wrong bit mask used for the ADC's result, which was caused by an > improper usage of the GENMASK() macro. The bits higher than ADC's > resolution are undefined and if not masked out correctly, a wrong result > can be given. The GENMASK() macro indexing is zero based, so the mask has > to go from [resolution -1 , 0]. You have trailing whitespace in your text, perhaps get your editor to show you this? Also, this is a new version of the patch, it needs to be marked as such so we know which is the "latest". The documentation says how to do that. thanks, greg k-h
diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c index 5d597e5050f6..1b4b3203e428 100644 --- a/drivers/iio/adc/ad7949.c +++ b/drivers/iio/adc/ad7949.c @@ -91,7 +91,7 @@ static int ad7949_spi_read_channel(struct ad7949_adc_chip *ad7949_adc, int *val, int ret; int i; int bits_per_word = ad7949_adc->resolution; - int mask = GENMASK(ad7949_adc->resolution, 0); + int mask = GENMASK(ad7949_adc->resolution - 1, 0); struct spi_message msg; struct spi_transfer tx[] = { {
Signed-off-by: Wilfried Wessner <wilfried.wessner@gmail.com> Fixes a wrong bit mask used for the ADC's result, which was caused by an improper usage of the GENMASK() macro. The bits higher than ADC's resolution are undefined and if not masked out correctly, a wrong result can be given. The GENMASK() macro indexing is zero based, so the mask has to go from [resolution -1 , 0]. --- drivers/iio/adc/ad7949.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)