| Message ID | 20210209142414.12768-1-georgi.djakov@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] mm: cma: Print region name on failure | expand |
On Tue, Feb 09, 2021 at 04:24:14PM +0200, Georgi Djakov wrote: > From: Patrick Daly <pdaly@codeaurora.org> > > Print the name of the CMA region for convenience. This is useful > information to have when cma_alloc() fails. > > Signed-off-by: Patrick Daly <pdaly@codeaurora.org> > Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> Acked-by: Minchan Kim <minchan@kernel.org>
On 09.02.21 15:24, Georgi Djakov wrote: > From: Patrick Daly <pdaly@codeaurora.org> > > Print the name of the CMA region for convenience. This is useful > information to have when cma_alloc() fails. > > Signed-off-by: Patrick Daly <pdaly@codeaurora.org> > Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> > --- > v2: > * Print the "count" variable, as it was originally in the code. (Randy) > * Fix spelling s/convienience/convenience/ in the commit text (Randy) > > v1: https://lore.kernel.org/r/20210208115200.20286-1-georgi.djakov@linaro.org/ > > mm/cma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 23d4a97c834a..54eee2119822 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -500,8 +500,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align, > } > > if (ret && !no_warn) { > - pr_err("%s: alloc failed, req-size: %zu pages, ret: %d\n", > - __func__, count, ret); > + pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n", > + __func__, cma->name, count, ret); > cma_debug_show_areas(cma); > } > > Reviewed-by: David Hildenbrand <david@redhat.com>
On 2/9/21 6:24 AM, Georgi Djakov wrote: > From: Patrick Daly <pdaly@codeaurora.org> > > Print the name of the CMA region for convenience. This is useful > information to have when cma_alloc() fails. > > Signed-off-by: Patrick Daly <pdaly@codeaurora.org> > Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > v2: > * Print the "count" variable, as it was originally in the code. (Randy) > * Fix spelling s/convienience/convenience/ in the commit text (Randy) > > v1: https://lore.kernel.org/r/20210208115200.20286-1-georgi.djakov@linaro.org/ > > mm/cma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 23d4a97c834a..54eee2119822 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -500,8 +500,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align, > } > > if (ret && !no_warn) { > - pr_err("%s: alloc failed, req-size: %zu pages, ret: %d\n", > - __func__, count, ret); > + pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n", > + __func__, cma->name, count, ret); > cma_debug_show_areas(cma); > } > >
diff --git a/mm/cma.c b/mm/cma.c index 23d4a97c834a..54eee2119822 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -500,8 +500,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align, } if (ret && !no_warn) { - pr_err("%s: alloc failed, req-size: %zu pages, ret: %d\n", - __func__, count, ret); + pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n", + __func__, cma->name, count, ret); cma_debug_show_areas(cma); }