| Message ID | 20210209151936.97382-8-olteanv@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Cleanup in brport flags switchdev offload for DSA | expand |
On Tue, Feb 09, 2021 at 05:19:32PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean <vladimir.oltean@nxp.com> > > The bridge offloads the port flags through a single bit mask using > switchdev, which among others, contains learning and flooding settings. > > The commit 57652796aa97 ("net: dsa: add support for bridge flags") > missed one crucial aspect of the SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS API > when designing the API one level lower, towards the drivers. > This is that the bitmask of passed brport flags never has more than one > bit set at a time. On the other hand, the prototype passed to the driver > is .port_egress_floods(int port, bool unicast, bool multicast), which > configures two flags at a time. > > DSA currently checks if .port_egress_floods is implemented, and if it > is, reports both BR_FLOOD and BR_MCAST_FLOOD as supported. So the driver > has no choice if it wants to inform the bridge that, for example, it > can't configure unicast flooding independently of multicast flooding - > the DSA mid layer is standing in the way. Or the other way around: a new > driver wants to start configuring BR_BCAST_FLOOD separately, but what do > we do with the rest, which only support unicast and multicast flooding? > Do we report broadcast flooding configuration as supported for those > too, and silently do nothing? > > Secondly, currently DSA deems the driver too dumb to deserve knowing that > a SWITCHDEV_ATTR_ID_BRIDGE_MROUTER attribute was offloaded, because it > just calls .port_egress_floods for the CPU port. When we'll add support > for the plain SWITCHDEV_ATTR_ID_PORT_MROUTER, that will become a real > problem because the flood settings will need to be held statefully in > the DSA middle layer, otherwise changing the mrouter port attribute will > impact the flooding attribute. And that's _assuming_ that the underlying > hardware doesn't have anything else to do when a multicast router > attaches to a port than flood unknown traffic to it. If it does, there > will need to be a dedicated .port_set_mrouter anyway. > > Lastly, we have DSA drivers that have a backlink into a pure switchdev > driver (felix -> ocelot). It seems reasonable that the other switchdev > drivers should not have to suffer from the oddities of DSA overengineering, > so keeping DSA a pass-through layer makes more sense there. > > To simplify the brport flags situation we just delete .port_egress_floods > and we introduce a simple .port_bridge_flags which is passed to the > driver. Also, the logic from dsa_port_mrouter is removed and a > .port_set_mrouter is created. > > Functionally speaking, we simply move the calls to .port_egress_floods > one step lower, in the two drivers that implement it: mv88e6xxx and b53, > so things should work just as before. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- Florian, Andrew, what are your opinions on this patch? I guess what I dislike the most about .port_egress_floods is that it combines the unicast and multicast settings in the same callback, for no good apparent reason. So that, at the very least, needs to change. What do you prefer between having: .port_set_unicast_floods .port_set_multicast_floods .port_set_broadcast_floods .port_set_learning and a single: .port_bridge_flags ?
On 2/9/21 12:37 PM, Vladimir Oltean wrote: > On Tue, Feb 09, 2021 at 05:19:32PM +0200, Vladimir Oltean wrote: >> From: Vladimir Oltean <vladimir.oltean@nxp.com> >> >> The bridge offloads the port flags through a single bit mask using >> switchdev, which among others, contains learning and flooding settings. >> >> The commit 57652796aa97 ("net: dsa: add support for bridge flags") >> missed one crucial aspect of the SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS API >> when designing the API one level lower, towards the drivers. >> This is that the bitmask of passed brport flags never has more than one >> bit set at a time. On the other hand, the prototype passed to the driver >> is .port_egress_floods(int port, bool unicast, bool multicast), which >> configures two flags at a time. >> >> DSA currently checks if .port_egress_floods is implemented, and if it >> is, reports both BR_FLOOD and BR_MCAST_FLOOD as supported. So the driver >> has no choice if it wants to inform the bridge that, for example, it >> can't configure unicast flooding independently of multicast flooding - >> the DSA mid layer is standing in the way. Or the other way around: a new >> driver wants to start configuring BR_BCAST_FLOOD separately, but what do >> we do with the rest, which only support unicast and multicast flooding? >> Do we report broadcast flooding configuration as supported for those >> too, and silently do nothing? >> >> Secondly, currently DSA deems the driver too dumb to deserve knowing that >> a SWITCHDEV_ATTR_ID_BRIDGE_MROUTER attribute was offloaded, because it >> just calls .port_egress_floods for the CPU port. When we'll add support >> for the plain SWITCHDEV_ATTR_ID_PORT_MROUTER, that will become a real >> problem because the flood settings will need to be held statefully in >> the DSA middle layer, otherwise changing the mrouter port attribute will >> impact the flooding attribute. And that's _assuming_ that the underlying >> hardware doesn't have anything else to do when a multicast router >> attaches to a port than flood unknown traffic to it. If it does, there >> will need to be a dedicated .port_set_mrouter anyway. >> >> Lastly, we have DSA drivers that have a backlink into a pure switchdev >> driver (felix -> ocelot). It seems reasonable that the other switchdev >> drivers should not have to suffer from the oddities of DSA overengineering, >> so keeping DSA a pass-through layer makes more sense there. >> >> To simplify the brport flags situation we just delete .port_egress_floods >> and we introduce a simple .port_bridge_flags which is passed to the >> driver. Also, the logic from dsa_port_mrouter is removed and a >> .port_set_mrouter is created. >> >> Functionally speaking, we simply move the calls to .port_egress_floods >> one step lower, in the two drivers that implement it: mv88e6xxx and b53, >> so things should work just as before. >> >> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> >> --- > > Florian, Andrew, what are your opinions on this patch? I guess what I > dislike the most about .port_egress_floods is that it combines the > unicast and multicast settings in the same callback, for no good > apparent reason. So that, at the very least, needs to change. > What do you prefer between having: > .port_set_unicast_floods > .port_set_multicast_floods > .port_set_broadcast_floods > .port_set_learning > and a single: > .port_bridge_flags Tough one, from a driver writer perspective the fewer callbacks to wire up the better, but from a framework perspective it is certainly easier to audit drivers if there is a callback for a narrow and specific use case. My vote goes for the single callback, that would lead to an easier patch set to review IMHO.
diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 23fc7225c8d1..d480493cb64d 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1948,6 +1948,23 @@ int b53_br_egress_floods(struct dsa_switch *ds, int port, } EXPORT_SYMBOL(b53_br_egress_floods); +static int b53_br_flags(struct dsa_switch *ds, int port, + struct switchdev_brport_flags flags, + struct netlink_ext_ack *extack) +{ + if (flags.mask & ~(BR_FLOOD | BR_MCAST_FLOOD)) + return -EINVAL; + + return b53_br_egress_floods(ds, port, flags.val & BR_FLOOD, + flags.val & BR_MCAST_FLOOD); +} + +static int b53_set_mrouter(struct dsa_switch *ds, int port, bool mrouter, + struct netlink_ext_ack *extack) +{ + return b53_br_egress_floods(ds, port, true, mrouter); +} + static bool b53_possible_cpu_port(struct dsa_switch *ds, int port) { /* Broadcom switches will accept enabling Broadcom tags on the @@ -2187,9 +2204,10 @@ static const struct dsa_switch_ops b53_switch_ops = { .set_mac_eee = b53_set_mac_eee, .port_bridge_join = b53_br_join, .port_bridge_leave = b53_br_leave, + .port_bridge_flags = b53_br_flags, + .port_set_mrouter = b53_set_mrouter, .port_stp_state_set = b53_br_set_stp_state, .port_fast_age = b53_br_fast_age, - .port_egress_floods = b53_br_egress_floods, .port_vlan_filtering = b53_vlan_filtering, .port_vlan_add = b53_vlan_add, .port_vlan_del = b53_vlan_del, diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index ae0b490f00cd..b230bfcc4050 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -5380,6 +5380,24 @@ static int mv88e6xxx_port_egress_floods(struct dsa_switch *ds, int port, return err; } +static int mv88e6xxx_port_bridge_flags(struct dsa_switch *ds, int port, + struct switchdev_brport_flags flags, + struct netlink_ext_ack *extack) +{ + if (flags.mask & ~(BR_FLOOD | BR_MCAST_FLOOD)) + return -EINVAL; + + return mv88e6xxx_port_egress_floods(ds, port, flags.val & BR_FLOOD, + flags.val & BR_MCAST_FLOOD); +} + +static int mv88e6xxx_port_set_mrouter(struct dsa_switch *ds, int port, + bool mrouter, + struct netlink_ext_ack *extack) +{ + return mv88e6xxx_port_egress_floods(ds, port, true, mrouter); +} + static bool mv88e6xxx_lag_can_offload(struct dsa_switch *ds, struct net_device *lag, struct netdev_lag_upper_info *info) @@ -5678,7 +5696,8 @@ static const struct dsa_switch_ops mv88e6xxx_switch_ops = { .set_ageing_time = mv88e6xxx_set_ageing_time, .port_bridge_join = mv88e6xxx_port_bridge_join, .port_bridge_leave = mv88e6xxx_port_bridge_leave, - .port_egress_floods = mv88e6xxx_port_egress_floods, + .port_bridge_flags = mv88e6xxx_port_bridge_flags, + .port_set_mrouter = mv88e6xxx_port_set_mrouter, .port_stp_state_set = mv88e6xxx_port_stp_state_set, .port_fast_age = mv88e6xxx_port_fast_age, .port_vlan_filtering = mv88e6xxx_port_vlan_filtering, diff --git a/include/net/dsa.h b/include/net/dsa.h index 60acb9fca124..09aa28e667c7 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h @@ -621,8 +621,11 @@ struct dsa_switch_ops { void (*port_stp_state_set)(struct dsa_switch *ds, int port, u8 state); void (*port_fast_age)(struct dsa_switch *ds, int port); - int (*port_egress_floods)(struct dsa_switch *ds, int port, - bool unicast, bool multicast); + int (*port_bridge_flags)(struct dsa_switch *ds, int port, + struct switchdev_brport_flags flags, + struct netlink_ext_ack *extack); + int (*port_set_mrouter)(struct dsa_switch *ds, int port, bool mrouter, + struct netlink_ext_ack *extack); /* * VLAN support diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h index 63770e421e4d..8125806ee135 100644 --- a/net/dsa/dsa_priv.h +++ b/net/dsa/dsa_priv.h @@ -175,8 +175,10 @@ int dsa_port_mdb_add(const struct dsa_port *dp, int dsa_port_mdb_del(const struct dsa_port *dp, const struct switchdev_obj_port_mdb *mdb); int dsa_port_bridge_flags(const struct dsa_port *dp, - struct switchdev_brport_flags flags); -int dsa_port_mrouter(struct dsa_port *dp, bool mrouter); + struct switchdev_brport_flags flags, + struct netlink_ext_ack *extack); +int dsa_port_mrouter(struct dsa_port *dp, bool mrouter, + struct netlink_ext_ack *extack); int dsa_port_vlan_add(struct dsa_port *dp, const struct switchdev_obj_port_vlan *vlan); int dsa_port_vlan_del(struct dsa_port *dp, diff --git a/net/dsa/port.c b/net/dsa/port.c index 597d3d3eb507..be5b2244667b 100644 --- a/net/dsa/port.c +++ b/net/dsa/port.c @@ -383,28 +383,26 @@ int dsa_port_ageing_time(struct dsa_port *dp, clock_t ageing_clock) } int dsa_port_bridge_flags(const struct dsa_port *dp, - struct switchdev_brport_flags flags) + struct switchdev_brport_flags flags, + struct netlink_ext_ack *extack) { struct dsa_switch *ds = dp->ds; - int port = dp->index; - if (!ds->ops->port_egress_floods || - (flags.mask & ~(BR_FLOOD | BR_MCAST_FLOOD))) + if (!ds->ops->port_bridge_flags) return -EINVAL; - return ds->ops->port_egress_floods(ds, port, flags.val & BR_FLOOD, - flags.val & BR_MCAST_FLOOD); + return ds->ops->port_bridge_flags(ds, dp->index, flags, extack); } -int dsa_port_mrouter(struct dsa_port *dp, bool mrouter) +int dsa_port_mrouter(struct dsa_port *dp, bool mrouter, + struct netlink_ext_ack *extack) { struct dsa_switch *ds = dp->ds; - int port = dp->index; - if (!ds->ops->port_egress_floods) + if (!ds->ops->port_set_mrouter) return -EOPNOTSUPP; - return ds->ops->port_egress_floods(ds, port, true, mrouter); + return ds->ops->port_set_mrouter(ds, dp->index, mrouter, extack); } int dsa_port_mtu_change(struct dsa_port *dp, int new_mtu, diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 0e1f8f1d4e2c..4a979245e059 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -291,10 +291,10 @@ static int dsa_slave_port_attr_set(struct net_device *dev, ret = dsa_port_ageing_time(dp, attr->u.ageing_time); break; case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS: - ret = dsa_port_bridge_flags(dp, attr->u.brport_flags); + ret = dsa_port_bridge_flags(dp, attr->u.brport_flags, extack); break; case SWITCHDEV_ATTR_ID_BRIDGE_MROUTER: - ret = dsa_port_mrouter(dp->cpu_dp, attr->u.mrouter); + ret = dsa_port_mrouter(dp->cpu_dp, attr->u.mrouter, extack); break; default: ret = -EOPNOTSUPP;