| Message ID | 20210211153353.29094-8-vincenzo.frascino@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: ARMv8.5-A: MTE: Add async mode support | expand |
On Thu, Feb 11, 2021 at 03:33:53PM +0000, Vincenzo Frascino wrote: > From: Andrey Konovalov <andreyknvl@google.com> > > Asynchronous KASAN mode doesn't guarantee that a tag fault will be > detected immediately and causes tests to fail. Forbid running them > in asynchronous mode. > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> > --- > lib/test_kasan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index f8c72d3aed64..77a60592d350 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -51,6 +51,10 @@ static int kasan_test_init(struct kunit *test) > kunit_err(test, "can't run KASAN tests with KASAN disabled"); > return -1; > } > + if (kasan_flag_async) { > + kunit_err(test, "can't run KASAN tests in async mode"); > + return -1; > + } I think we have time to fix this properly ;), so I'd rather not add this patch at all.
On Fri, Feb 12, 2021 at 6:22 PM Catalin Marinas <catalin.marinas@arm.com> wrote: > > On Thu, Feb 11, 2021 at 03:33:53PM +0000, Vincenzo Frascino wrote: > > From: Andrey Konovalov <andreyknvl@google.com> > > > > Asynchronous KASAN mode doesn't guarantee that a tag fault will be > > detected immediately and causes tests to fail. Forbid running them > > in asynchronous mode. > > > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> > > --- > > lib/test_kasan.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > > index f8c72d3aed64..77a60592d350 100644 > > --- a/lib/test_kasan.c > > +++ b/lib/test_kasan.c > > @@ -51,6 +51,10 @@ static int kasan_test_init(struct kunit *test) > > kunit_err(test, "can't run KASAN tests with KASAN disabled"); > > return -1; > > } > > + if (kasan_flag_async) { > > + kunit_err(test, "can't run KASAN tests in async mode"); > > + return -1; > > + } > > I think we have time to fix this properly ;), so I'd rather not add this > patch at all. Yeah, this patch can be dropped. I have a prototype of async support for tests working. I'll apply it on top of the next version Vincenzo posts and share the patch. Vincenzo, when you post the next version, please make sure you rebase on top of the mm tree version that includes "kasan: export HW_TAGS symbols for KUnit tests" (linux-next/akpm doesn't yet have it).
On 2/12/21 9:44 PM, Andrey Konovalov wrote: >> I think we have time to fix this properly ;), so I'd rather not add this >> patch at all. > Yeah, this patch can be dropped. > > I have a prototype of async support for tests working. I'll apply it > on top of the next version Vincenzo posts and share the patch. > > Vincenzo, when you post the next version, please make sure you rebase > on top of the mm tree version that includes "kasan: export HW_TAGS > symbols for KUnit tests" (linux-next/akpm doesn't yet have it). Fine by me, I will drop this patch when I will repost in -rc1. @Andrey: If you want me to test the series all together, you can send me your tree before I repost and then I can send the patches as single series. What do you think?
On Mon, Feb 22, 2021 at 12:13 PM Vincenzo Frascino <vincenzo.frascino@arm.com> wrote: > > On 2/12/21 9:44 PM, Andrey Konovalov wrote: > >> I think we have time to fix this properly ;), so I'd rather not add this > >> patch at all. > > Yeah, this patch can be dropped. > > > > I have a prototype of async support for tests working. I'll apply it > > on top of the next version Vincenzo posts and share the patch. > > > > Vincenzo, when you post the next version, please make sure you rebase > > on top of the mm tree version that includes "kasan: export HW_TAGS > > symbols for KUnit tests" (linux-next/akpm doesn't yet have it). > > Fine by me, I will drop this patch when I will repost in -rc1. > > @Andrey: If you want me to test the series all together, you can send me your > tree before I repost and then I can send the patches as single series. What do > you think? I'll need a rebased version of your patches first, otherwise conflicts will be a pain. Thanks!
diff --git a/lib/test_kasan.c b/lib/test_kasan.c index f8c72d3aed64..77a60592d350 100644 --- a/lib/test_kasan.c +++ b/lib/test_kasan.c @@ -51,6 +51,10 @@ static int kasan_test_init(struct kunit *test) kunit_err(test, "can't run KASAN tests with KASAN disabled"); return -1; } + if (kasan_flag_async) { + kunit_err(test, "can't run KASAN tests in async mode"); + return -1; + } multishot = kasan_save_enable_multi_shot(); hw_set_tagging_report_once(false);