| Message ID | 20210217173158.3122868-1-benjamin.tissoires@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | HID: playstation: revert LED class exposure | expand |
On Wed 2021-02-17 18:31:47, Benjamin Tissoires wrote: > [sending those patches on behalf of Roderick] > > There is a current thread on LED LKML which basically means that > we have to revert the LED class exposure until things are settled. > > I am sending here the full series that will end up in linux-next. > But with some git magic, the final PR to Linus will not have the > reverts in it, just the plain patches. Thank you! Pavel
On Wed, 17 Feb 2021, Benjamin Tissoires wrote: > [sending those patches on behalf of Roderick] > > There is a current thread on LED LKML which basically means that > we have to revert the LED class exposure until things are settled. > > I am sending here the full series that will end up in linux-next. > But with some git magic, the final PR to Linus will not have the > reverts in it, just the plain patches. > > I am queuing in for-5.12/playstation patches 1 to 6 immediately > (the reverts). > > I am also queuing in for-5.12/playstation-v2 patches 7 and 8 on > top of 51151098d7ab8 immediately. Those 2 patches have already > been reviewed the usual process. > > I am waiting 1 day for others to chime in regarding patches 9 to > 11 before applying them to for-5.12/playstation-v2. They are > basically the same patches that were already reviewed on the > linux-input LKML, but without the LED class bits. FWIW, as discussed elsewhere, I am fully in favor of this solution. Thanks!
On Wed, Feb 17, 2021 at 6:32 PM Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote: > > [sending those patches on behalf of Roderick] > > There is a current thread on LED LKML which basically means that > we have to revert the LED class exposure until things are settled. > > I am sending here the full series that will end up in linux-next. > But with some git magic, the final PR to Linus will not have the > reverts in it, just the plain patches. > > I am queuing in for-5.12/playstation patches 1 to 6 immediately > (the reverts). > > I am also queuing in for-5.12/playstation-v2 patches 7 and 8 on > top of 51151098d7ab8 immediately. Those 2 patches have already > been reviewed the usual process. > > I am waiting 1 day for others to chime in regarding patches 9 to > 11 before applying them to for-5.12/playstation-v2. They are > basically the same patches that were already reviewed on the > linux-input LKML, but without the LED class bits. And I just pushed those 3 patches to for-5.12/playstation-v2. Cheers, Benjamin > > With all that, we should have more room to discuss the exposure > of the LEDs to userspace through the LED class. > > Roderick, I made small adjustments compared to the series you sent > me privately: > - added the 2 missing reverts/re-add, so I can have clean merges > for our for-next branch, > - re-ordered the `if (ds->update_rumble)` block in > `dualsense_output_worker()` to match was was in linux-next > - removed an extra new line to match the current linux-next tree. > > Cheers, > Benjamin > > Benjamin Tissoires (2): > Revert "HID: playstation: fix unused variable in > ps_battery_get_property." > Revert "HID: playstation: report DualSense hardware and firmware > version." > > Roderick Colenbrander (9): > Revert "HID: playstation: DualSense set LEDs to default player id." > Revert "HID: playstation: add DualSense player LEDs support." > Revert "HID: playstation: add microphone mute support for DualSense." > Revert "HID: playstation: add DualSense lightbar support" > HID: playstation: report DualSense hardware and firmware version. > HID: playstation: fix unused variable in ps_battery_get_property. > HID: playstation: add initial DualSense lightbar support. > HID: playstation: add microphone mute support for DualSense. > HID: playstation: add DualSense player LED support. > > drivers/hid/Kconfig | 3 - > drivers/hid/hid-playstation.c | 177 +++------------------------------- > 2 files changed, 12 insertions(+), 168 deletions(-) > > -- > 2.29.2 >
[sending those patches on behalf of Roderick] There is a current thread on LED LKML which basically means that we have to revert the LED class exposure until things are settled. I am sending here the full series that will end up in linux-next. But with some git magic, the final PR to Linus will not have the reverts in it, just the plain patches. I am queuing in for-5.12/playstation patches 1 to 6 immediately (the reverts). I am also queuing in for-5.12/playstation-v2 patches 7 and 8 on top of 51151098d7ab8 immediately. Those 2 patches have already been reviewed the usual process. I am waiting 1 day for others to chime in regarding patches 9 to 11 before applying them to for-5.12/playstation-v2. They are basically the same patches that were already reviewed on the linux-input LKML, but without the LED class bits. With all that, we should have more room to discuss the exposure of the LEDs to userspace through the LED class. Roderick, I made small adjustments compared to the series you sent me privately: - added the 2 missing reverts/re-add, so I can have clean merges for our for-next branch, - re-ordered the `if (ds->update_rumble)` block in `dualsense_output_worker()` to match was was in linux-next - removed an extra new line to match the current linux-next tree. Cheers, Benjamin Benjamin Tissoires (2): Revert "HID: playstation: fix unused variable in ps_battery_get_property." Revert "HID: playstation: report DualSense hardware and firmware version." Roderick Colenbrander (9): Revert "HID: playstation: DualSense set LEDs to default player id." Revert "HID: playstation: add DualSense player LEDs support." Revert "HID: playstation: add microphone mute support for DualSense." Revert "HID: playstation: add DualSense lightbar support" HID: playstation: report DualSense hardware and firmware version. HID: playstation: fix unused variable in ps_battery_get_property. HID: playstation: add initial DualSense lightbar support. HID: playstation: add microphone mute support for DualSense. HID: playstation: add DualSense player LED support. drivers/hid/Kconfig | 3 - drivers/hid/hid-playstation.c | 177 +++------------------------------- 2 files changed, 12 insertions(+), 168 deletions(-)