| Message ID | 20210218092316.1624-1-zbestahu@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | cpufreq: schedutil: Correct comment to update_lock of struct sugov_policy | expand |
On 18-02-21, 17:23, Yue Hu wrote: > From: Yue Hu <huyue2@yulong.com> > > Currently, update_lock is also used in sugov_update_single_freq(). > > Signed-off-by: Yue Hu <huyue2@yulong.com> > --- > kernel/sched/cpufreq_schedutil.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c > index add8081..cc0308c 100644 > --- a/kernel/sched/cpufreq_schedutil.c > +++ b/kernel/sched/cpufreq_schedutil.c > @@ -26,7 +26,7 @@ struct sugov_policy { > struct sugov_tunables *tunables; > struct list_head tunables_hook; > > - raw_spinlock_t update_lock; /* For shared policies */ > + raw_spinlock_t update_lock; /* For single + shared policies */ I will just remove the comments, its pretty much useless anyway.
On Thu, 18 Feb 2021 14:56:58 +0530 Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 18-02-21, 17:23, Yue Hu wrote: > > From: Yue Hu <huyue2@yulong.com> > > > > Currently, update_lock is also used in sugov_update_single_freq(). > > > > Signed-off-by: Yue Hu <huyue2@yulong.com> > > --- > > kernel/sched/cpufreq_schedutil.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/sched/cpufreq_schedutil.c > > b/kernel/sched/cpufreq_schedutil.c index add8081..cc0308c 100644 > > --- a/kernel/sched/cpufreq_schedutil.c > > +++ b/kernel/sched/cpufreq_schedutil.c > > @@ -26,7 +26,7 @@ struct sugov_policy { > > struct sugov_tunables *tunables; > > struct list_head tunables_hook; > > > > - raw_spinlock_t update_lock; /* For > > shared policies */ > > + raw_spinlock_t update_lock; /* For > > single + shared policies */ > > I will just remove the comments, its pretty much useless anyway. > ok, i will do it. Thx.
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index add8081..cc0308c 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -26,7 +26,7 @@ struct sugov_policy { struct sugov_tunables *tunables; struct list_head tunables_hook; - raw_spinlock_t update_lock; /* For shared policies */ + raw_spinlock_t update_lock; /* For single + shared policies */ u64 last_freq_update_time; s64 freq_update_delay_ns; unsigned int next_freq;