mbox series

[v4,0/3] Add npcm7xx emc model

Message ID 20210213002520.1374134-1-dje@google.com (mailing list archive)
Headers show
Series Add npcm7xx emc model | expand

Message

Doug Evans Feb. 13, 2021, 12:25 a.m. UTC 
This is a 10/100 ethernet device that has several features.
Only the ones needed by the Linux driver have been implemented.
See npcm7xx_emc.c for a list of unimplemented features.

Doug Evans (3):
  hw/net: Add npcm7xx emc model
  hw/arm: Add npcm7xx emc model
  tests/qtests: Add npcm7xx emc model test

 docs/system/arm/nuvoton.rst    |   3 +-
 hw/arm/npcm7xx.c               |  50 +-
 hw/net/meson.build             |   1 +
 hw/net/npcm7xx_emc.c           | 857 ++++++++++++++++++++++++++++++++
 hw/net/trace-events            |  17 +
 include/hw/arm/npcm7xx.h       |   2 +
 include/hw/net/npcm7xx_emc.h   | 286 +++++++++++
 tests/qtest/meson.build        |   1 +
 tests/qtest/npcm7xx_emc-test.c | 862 +++++++++++++++++++++++++++++++++
 9 files changed, 2076 insertions(+), 3 deletions(-)
 create mode 100644 hw/net/npcm7xx_emc.c
 create mode 100644 include/hw/net/npcm7xx_emc.h
 create mode 100644 tests/qtest/npcm7xx_emc-test.c

Comments

Peter Maydell Feb. 16, 2021, 2:28 p.m. UTC | #1 
On Sat, 13 Feb 2021 at 00:25, Doug Evans <dje@google.com> wrote:
>
> This is a 10/100 ethernet device that has several features.
> Only the ones needed by the Linux driver have been implemented.
> See npcm7xx_emc.c for a list of unimplemented features.
>
> Doug Evans (3):
>   hw/net: Add npcm7xx emc model
>   hw/arm: Add npcm7xx emc model
>   tests/qtests: Add npcm7xx emc model test
>


Applied to target-arm.next, thanks.

-- PMM
Peter Maydell Feb. 17, 2021, 11:01 a.m. UTC | #2 
On Tue, 16 Feb 2021 at 14:28, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Sat, 13 Feb 2021 at 00:25, Doug Evans <dje@google.com> wrote:
> >
> > This is a 10/100 ethernet device that has several features.
> > Only the ones needed by the Linux driver have been implemented.
> > See npcm7xx_emc.c for a list of unimplemented features.
> >
> > Doug Evans (3):
> >   hw/net: Add npcm7xx emc model
> >   hw/arm: Add npcm7xx emc model
> >   tests/qtests: Add npcm7xx emc model test
> >
>
>
> Applied to target-arm.next, thanks.

Dropped again: it failed some oddball config in the gitlab CI:
https://gitlab.com/qemu-project/qemu/-/jobs/1034174731#L12

-- PMM
Doug Evans Feb. 18, 2021, 9:46 p.m. UTC | #3 
On Wed, Feb 17, 2021 at 3:01 AM Peter Maydell <peter.maydell@linaro.org>
wrote:

> On Tue, 16 Feb 2021 at 14:28, Peter Maydell <peter.maydell@linaro.org>
> wrote:
> >
> > On Sat, 13 Feb 2021 at 00:25, Doug Evans <dje@google.com> wrote:
> > >
> > > This is a 10/100 ethernet device that has several features.
> > > Only the ones needed by the Linux driver have been implemented.
> > > See npcm7xx_emc.c for a list of unimplemented features.
> > >
> > > Doug Evans (3):
> > >   hw/net: Add npcm7xx emc model
> > >   hw/arm: Add npcm7xx emc model
> > >   tests/qtests: Add npcm7xx emc model test
> > >
> >
> >
> > Applied to target-arm.next, thanks.
>
> Dropped again: it failed some oddball config in the gitlab CI:
> https://gitlab.com/qemu-project/qemu/-/jobs/1034174731#L12
>
> -- PMM
>


Yeah, the test needs to watch for --disable-slirp.
Fixed in v5:
https://lists.nongnu.org/archive/html/qemu-devel/2021-02/msg06030.html