| Message ID | 20210222091050.160161-1-me@ubique.spb.ru (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | BPF |
| Headers | show |
| Series | [v1,bpf-next] bpf: Drop imprecise log message | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: kpsingh@kernel.org netdev@vger.kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 9 this patch: 9 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 9 this patch: 9 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Mon, Feb 22, 2021 at 01:10:50PM +0400, Dmitrii Banshchikov wrote: > Now it is possible for global function to have a pointer argument that > points to something different than struct. Drop the irrelevant log > message and keep the logic same. Acked-by: Martin KaFai Lau <kafai@fb.com> > Fixes: 4ddb74165ae5 ("bpf: Extract nullable reg type conversion into a helper function") Should be this: e5069b9c23b3 ("bpf: Support pointers in global func args")?
On Mon, Feb 22, 2021 at 11:31:11AM -0800, Martin KaFai Lau wrote: > On Mon, Feb 22, 2021 at 01:10:50PM +0400, Dmitrii Banshchikov wrote: > > Now it is possible for global function to have a pointer argument that > > points to something different than struct. Drop the irrelevant log > > message and keep the logic same. > Acked-by: Martin KaFai Lau <kafai@fb.com> > > > Fixes: 4ddb74165ae5 ("bpf: Extract nullable reg type conversion into a helper function") > Should be this: e5069b9c23b3 ("bpf: Support pointers in global func args")? Yeah, sorry for it.
On Mon, Feb 22, 2021 at 11:53:38PM +0400, Dmitrii Banshchikov wrote: > On Mon, Feb 22, 2021 at 11:31:11AM -0800, Martin KaFai Lau wrote: > > On Mon, Feb 22, 2021 at 01:10:50PM +0400, Dmitrii Banshchikov wrote: > > > Now it is possible for global function to have a pointer argument that > > > points to something different than struct. Drop the irrelevant log > > > message and keep the logic same. > > Acked-by: Martin KaFai Lau <kafai@fb.com> > > > > > Fixes: 4ddb74165ae5 ("bpf: Extract nullable reg type conversion into a helper function") > > Should be this: e5069b9c23b3 ("bpf: Support pointers in global func args")? > > Yeah, sorry for it. > Shall I respin it?
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index 2efeb5f4b343..b1a76fe046cb 100644 --- a/kernel/bpf/btf.c +++ b/kernel/bpf/btf.c @@ -4321,8 +4321,6 @@ btf_get_prog_ctx_type(struct bpf_verifier_log *log, struct btf *btf, * is not supported yet. * BPF_PROG_TYPE_RAW_TRACEPOINT is fine. */ - if (log->level & BPF_LOG_LEVEL) - bpf_log(log, "arg#%d type is not a struct\n", arg); return NULL; } tname = btf_name_by_offset(btf, t->name_off);
Now it is possible for global function to have a pointer argument that points to something different than struct. Drop the irrelevant log message and keep the logic same. Fixes: 4ddb74165ae5 ("bpf: Extract nullable reg type conversion into a helper function") Signed-off-by: Dmitrii Banshchikov <me@ubique.spb.ru> --- v0 -> v1: drop redundant commit hash mention kernel/bpf/btf.c | 2 -- 1 file changed, 2 deletions(-)