| Message ID | 20210218034514.3421-1-dqfext@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 04b385f325080157ab1b5f8ce1b1de07ce0d9e27 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: ag71xx: remove unnecessary MTU reservation | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 1 blamed authors not CCed: andrew@lunn.ch; 1 maintainers not CCed: andrew@lunn.ch |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 16 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Thu, Feb 18, 2021 at 11:45:14AM +0800, DENG Qingfang wrote: > 2 bytes of the MTU are reserved for Atheros DSA tag, but DSA core > has already handled that since commit dc0fe7d47f9f. > Remove the unnecessary reservation. > > Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") > Signed-off-by: DENG Qingfang <dqfext@gmail.com> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de> Thank you! > --- > drivers/net/ethernet/atheros/ag71xx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c > index dd5c8a9038bb..a60ce9030581 100644 > --- a/drivers/net/ethernet/atheros/ag71xx.c > +++ b/drivers/net/ethernet/atheros/ag71xx.c > @@ -223,8 +223,6 @@ > #define AG71XX_REG_RX_SM 0x01b0 > #define AG71XX_REG_TX_SM 0x01b4 > > -#define ETH_SWITCH_HEADER_LEN 2 > - > #define AG71XX_DEFAULT_MSG_ENABLE \ > (NETIF_MSG_DRV \ > | NETIF_MSG_PROBE \ > @@ -933,7 +931,7 @@ static void ag71xx_hw_setup(struct ag71xx *ag) > > static unsigned int ag71xx_max_frame_len(unsigned int mtu) > { > - return ETH_SWITCH_HEADER_LEN + ETH_HLEN + VLAN_HLEN + mtu + ETH_FCS_LEN; > + return ETH_HLEN + VLAN_HLEN + mtu + ETH_FCS_LEN; > } > > static void ag71xx_hw_set_macaddr(struct ag71xx *ag, unsigned char *mac) > -- > 2.25.1 > >
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 18 Feb 2021 11:45:14 +0800 you wrote: > 2 bytes of the MTU are reserved for Atheros DSA tag, but DSA core > has already handled that since commit dc0fe7d47f9f. > Remove the unnecessary reservation. > > Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") > Signed-off-by: DENG Qingfang <dqfext@gmail.com> > > [...] Here is the summary with links: - [net] net: ag71xx: remove unnecessary MTU reservation https://git.kernel.org/netdev/net/c/04b385f32508 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index dd5c8a9038bb..a60ce9030581 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -223,8 +223,6 @@ #define AG71XX_REG_RX_SM 0x01b0 #define AG71XX_REG_TX_SM 0x01b4 -#define ETH_SWITCH_HEADER_LEN 2 - #define AG71XX_DEFAULT_MSG_ENABLE \ (NETIF_MSG_DRV \ | NETIF_MSG_PROBE \ @@ -933,7 +931,7 @@ static void ag71xx_hw_setup(struct ag71xx *ag) static unsigned int ag71xx_max_frame_len(unsigned int mtu) { - return ETH_SWITCH_HEADER_LEN + ETH_HLEN + VLAN_HLEN + mtu + ETH_FCS_LEN; + return ETH_HLEN + VLAN_HLEN + mtu + ETH_FCS_LEN; } static void ag71xx_hw_set_macaddr(struct ag71xx *ag, unsigned char *mac)
2 bytes of the MTU are reserved for Atheros DSA tag, but DSA core has already handled that since commit dc0fe7d47f9f. Remove the unnecessary reservation. Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Signed-off-by: DENG Qingfang <dqfext@gmail.com> --- drivers/net/ethernet/atheros/ag71xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)