| Message ID | 20210223055124.75882-1-laoar.shao@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] vsprintf: dump full information of page flags in pGp fix | expand |
On Tue 2021-02-23 13:51:24, Yafang Shao wrote: > The name of the flag should be printed using default_str_spec. > There's no difference in the output after this change because the string is > printed as-is with both default_dec_spec and default_flag_spec. > > This patch is a followup of the patchset > "mm, vsprintf: dump full information of page flags in pGp" [1] > > [1]. https://lore.kernel.org/linux-mm/20210215155141.47432-1-laoar.shao@gmail.com/ > Signed-off-by: Yafang Shao <laoar.shao@gmail.com> > Cc: Petr Mladek <pmladek@suse.com> > Cc: Matthew Wilcox <willy@infradead.org> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Vlastimil Babka <vbabka@suse.cz> > Cc: Miaohe Lin <linmiaohe@huawei.com> > Cc: Joe Perches <joe@perches.com> > Cc: David Hildenbrand <david@redhat.com> Reviewed-by: Petr Mladek <pmladek@suse.com> Best Regards, Petr
On Tue 2021-02-23 13:51:24, Yafang Shao wrote: > The name of the flag should be printed using default_str_spec. > There's no difference in the output after this change because the string is > printed as-is with both default_dec_spec and default_flag_spec. > > This patch is a followup of the patchset > "mm, vsprintf: dump full information of page flags in pGp" [1] > > [1]. https://lore.kernel.org/linux-mm/20210215155141.47432-1-laoar.shao@gmail.com/ > Signed-off-by: Yafang Shao <laoar.shao@gmail.com> The patch is comitted in printk/linux.git, branch for-5.13-vsprintf-pgp. Best Regards, Petr
diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 533ac5404180..5d034e799c06 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -1963,7 +1963,7 @@ char *format_page_flags(char *buf, char *end, unsigned long flags) buf++; } - buf = string(buf, end, p->name, *p->spec); + buf = string(buf, end, p->name, default_str_spec); if (buf < end) *buf = '='; buf++;
The name of the flag should be printed using default_str_spec. There's no difference in the output after this change because the string is printed as-is with both default_dec_spec and default_flag_spec. This patch is a followup of the patchset "mm, vsprintf: dump full information of page flags in pGp" [1] [1]. https://lore.kernel.org/linux-mm/20210215155141.47432-1-laoar.shao@gmail.com/ Signed-off-by: Yafang Shao <laoar.shao@gmail.com> Cc: Petr Mladek <pmladek@suse.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Miaohe Lin <linmiaohe@huawei.com> Cc: Joe Perches <joe@perches.com> Cc: David Hildenbrand <david@redhat.com> --- lib/vsprintf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)