| Message ID | 20210223204340.312-2-noltari@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | irqchip: add support for BCM6345 interrupt controller | expand |
On 2/23/2021 12:43 PM, Álvaro Fernández Rojas wrote: > Document the binding for the BCM6345 external interrupt controller. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
On Tue, 23 Feb 2021 21:43:39 +0100, Álvaro Fernández Rojas wrote: > Document the binding for the BCM6345 external interrupt controller. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> > --- > v2: fix title typo. > > .../brcm,bcm6345-ext-intc.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml: properties:interrupt-parent: False schema does not allow {'description': 'Specifies the phandle to the parent interrupt controller this one is cascaded from.'} /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml: ignoring, error in schema: properties: interrupt-parent warning: no schema found in file: ./Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml See https://patchwork.ozlabs.org/patch/1443622 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file mode 100644 index 000000000000..b29a3221a6d1 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom BCM6345 external interrupt controller + +maintainers: + - Álvaro Fernández Rojas <noltari@gmail.com> + - Jonas Gorski <jonas.gorski@gmail.com> + +properties: + compatible: + enum: + - brcm,bcm6318-ext-intc + - brcm,bcm6345-ext-intc + + interrupt-parent: + description: Specifies the phandle to the parent interrupt controller + this one is cascaded from. + + "#interrupt-cells": + const: 2 + + reg: + maxItems: 1 + + "#address-cells": + const: 0 + + interrupt-controller: true + + interrupts: + description: Specifies the interrupt line(s) in the interrupt-parent + controller node, valid values depend on the type of parent interrupt + controller. + maxItems: 4 + +required: + - compatible + - interrupt-parent + - "#interrupt-cells" + - reg + - "#address-cells" + - interrupt-controller + - interrupts + +additionalProperties: false + +examples: + - | + ext_intc: interrupt-controller@10000018 { + compatible = "brcm,bcm6345-ext-intc"; + interrupt-parent = <&periph_intc>; + #interrupt-cells = <2>; + reg = <0x10000018 0x4>; + #address-cells = <0>; + interrupt-controller; + interrupts = <24>, <25>, <26>, <27>; + };