| Message ID | 20210224094356.7606-1-julien@xen.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | xen/iommu: Collection of bug fixes for IOMMU teardown | expand |
Julien Grall writes ("[for-4.15][RESEND PATCH v4 0/2] xen/iommu: Collection of bug fixes for IOMMU teardown"):
> This series is a collection of bug fixes for the IOMMU teardown code.
> All of them are candidate for 4.15 as they can either leak memory or
> lead to host crash/host corruption.
>
> This is sent directly on xen-devel because all the issues were either
> introduced in 4.15 or happen in the domain creation code.
Thanks.
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
I'd appreciate it if reviewers would double-check the comments and
commit messages which Julien has helpfully provided, to check that the
assertions made are true. It seems this is quite complex...
Ian.
From: Julien Grall <jgrall@amazon.com> Hi all, This series is a collection of bug fixes for the IOMMU teardown code. All of them are candidate for 4.15 as they can either leak memory or lead to host crash/host corruption. This is sent directly on xen-devel because all the issues were either introduced in 4.15 or happen in the domain creation code. Major changes since v3: - Remove patch #3 "xen/iommu: x86: Harden the IOMMU page-table allocator" as it is not strictly necessary for 4.15. - Re-order the patches to avoid on a follow-up patch to fix completely the issue. Major changes since v2: - patch #1 "xen/x86: p2m: Don't map the special pages in the IOMMU page-tables" has been removed. This requires Jan's patch [1] to fully mitigate memory leaks. Cheers, [1] <90271e69-c07e-a32c-5531-a79b10ef03dd@suse.com> *** BLURB HERE *** Julien Grall (2): xen/x86: iommu: Ignore IOMMU mapping requests when a domain is dying xen/iommu: x86: Clear the root page-table before freeing the page-tables xen/drivers/passthrough/amd/iommu_map.c | 12 +++++++++++ xen/drivers/passthrough/amd/pci_amd_iommu.c | 12 ++++++++++- xen/drivers/passthrough/vtd/iommu.c | 24 ++++++++++++++++++++- xen/drivers/passthrough/x86/iommu.c | 19 ++++++++++++++++ xen/include/xen/iommu.h | 1 + 5 files changed, 66 insertions(+), 2 deletions(-)