| Message ID | 20210223104803.4047281-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 17d7fd47aa9063c2ff36988e36757ac345733e28 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: stmmac: Fix missing spin_lock_init in visconti_eth_dwmac_probe() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | fail | 1 blamed authors not CCed: davem@davemloft.net; 1 maintainers not CCed: davem@davemloft.net |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Hi, On Tue, Feb 23, 2021 at 10:48:03AM +0000, Wei Yongjun wrote: > The driver allocates the spinlock but not initialize it. > Use spin_lock_init() on it to initialize it correctly. > > Fixes: b38dd98ff8d0 ("net: stmmac: Add Toshiba Visconti SoCs glue driver") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Thanks for your fix. Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c > index b7a0c57dfbfb..d23be45a64e5 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c > @@ -218,6 +218,7 @@ static int visconti_eth_dwmac_probe(struct platform_device *pdev) > goto remove_config; > } > > + spin_lock_init(&dwmac->lock); > dwmac->reg = stmmac_res.addr; > plat_dat->bsp_priv = dwmac; > plat_dat->fix_mac_speed = visconti_eth_fix_mac_speed; > > Best regards, Nobuhiro
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 23 Feb 2021 10:48:03 +0000 you wrote: > The driver allocates the spinlock but not initialize it. > Use spin_lock_init() on it to initialize it correctly. > > Fixes: b38dd98ff8d0 ("net: stmmac: Add Toshiba Visconti SoCs glue driver") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > [...] Here is the summary with links: - net: stmmac: Fix missing spin_lock_init in visconti_eth_dwmac_probe() https://git.kernel.org/netdev/net/c/17d7fd47aa90 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c index b7a0c57dfbfb..d23be45a64e5 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c @@ -218,6 +218,7 @@ static int visconti_eth_dwmac_probe(struct platform_device *pdev) goto remove_config; } + spin_lock_init(&dwmac->lock); dwmac->reg = stmmac_res.addr; plat_dat->bsp_priv = dwmac; plat_dat->fix_mac_speed = visconti_eth_fix_mac_speed;
The driver allocates the spinlock but not initialize it. Use spin_lock_init() on it to initialize it correctly. Fixes: b38dd98ff8d0 ("net: stmmac: Add Toshiba Visconti SoCs glue driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c | 1 + 1 file changed, 1 insertion(+)