diff mbox series

xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating

Message ID 6604dec2-4460-3339-f797-e5f8a7df848f@suse.com (mailing list archive)
State Accepted
Commit 826d82170b539f16e1955ab940222543c012044e
Headers show
Series xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating | expand

Commit Message

Jan Beulich Feb. 25, 2021, 3:39 p.m. UTC 
shinfo already holds the result of skb_shinfo(skb) at this point - no
need to re-invoke the construct even twice.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

Comments

patchwork-bot+netdevbpf@kernel.org March 1, 2021, 9:10 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 25 Feb 2021 16:39:01 +0100 you wrote:
> shinfo already holds the result of skb_shinfo(skb) at this point - no
> need to re-invoke the construct even twice.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Here is the summary with links:
  - xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating
    https://git.kernel.org/netdev/net/c/826d82170b53

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -557,8 +557,8 @@  check_frags:
 	}
 
 	if (skb_has_frag_list(skb) && !first_shinfo) {
-		first_shinfo = skb_shinfo(skb);
-		shinfo = skb_shinfo(skb_shinfo(skb)->frag_list);
+		first_shinfo = shinfo;
+		shinfo = skb_shinfo(shinfo->frag_list);
 		nr_frags = shinfo->nr_frags;
 
 		goto check_frags;